On 01/19/2016 12:07 AM, Jose Ricardo Ziviani wrote:
The patch header says it has 3 commits but it is missing the commit
#2.
Hrm... I can see it in the mailing list archives:
http://lists.ovirt.org/pipermail/kimchi-devel/2016-January/013377.html
If I got it right this was moved to Wok because websocket should be
started by wok instead of kimchi, right?
More than that, with this patch + Wok patches, there is no need to open
the 64667 port on Firewall configuration. Websockets will listen on
localhost and the requests will be redirected by nginx.
Anyway I tested and reviewed the commits #1 and #3:
Reviewed by: Jose Ricardo Ziviani <joserz(a)linux.vnet.ibm.com>
Tested by: Jose Ricardo Ziviani <joserz(a)linux.vnet.ibm.com>
On 18-01-2016 22:29, Aline Manera wrote:
> This patch set depends on Wok patch: [PATCH] [Wok 0/6] Configure
> nginx to proxy connections to the websocket server
>
> V1 -> V2:
> - Update spec files to add the all the docs/ directory content
>
> Aline Manera (2):
> Update /plugins/kimchi/config API to only return information related
> to Kimchi
> Update README
>
> Rob Lemley (1):
> Start up websockify on localhost
>
> contrib/kimchi.spec.fedora.in | 6 +-
> contrib/kimchi.spec.suse.in | 6 +-
> docs/API.md | 3 +-
> docs/Makefile.am | 10 +-
> docs/README.md | 239
> +++++++++--------------------------
> docs/fedora-deps.md | 53 ++++++++
> docs/kimchi-guest.png | Bin 192281 -> 0 bytes
> docs/kimchi-guests.png | Bin 0 -> 55954 bytes
> docs/kimchi-login.png | Bin 318041 -> 0 bytes
> docs/kimchi-templates.png | Bin 329678 -> 60887 bytes
> docs/opensuse-deps.md | 48 +++++++
> docs/ubuntu-deps.md | 34 +++++
> docs/wok-login.png | Bin 0 -> 20140 bytes
> model/config.py | 10 +-
> tests/test_rest.py | 4 +-
> ui/js/src/kimchi.api.js | 29 ++---
> ui/spice-html5/pages/spice_auto.html | 2 +-
> vnc.py | 8 +-
> 18 files changed, 222 insertions(+), 230 deletions(-)
> create mode 100644 docs/fedora-deps.md
> delete mode 100644 docs/kimchi-guest.png
> create mode 100644 docs/kimchi-guests.png
> delete mode 100644 docs/kimchi-login.png
> create mode 100644 docs/opensuse-deps.md
> create mode 100644 docs/ubuntu-deps.md
> create mode 100644 docs/wok-login.png
>