Re: [Kimchi-devel] [PATCH v2 0/2] Keep UI Consistent in Guest Edit Window

On 06/09/2014 04:25 AM, Hongliang Wang wrote: > > On 06/07/2014 01:16 AM, Aline Manera wrote: >> On 06/06/2014 03:49 AM, Hongliang Wang wrote: >>> Make guest cdrom edit UI consistent with guest interface edit UI. The key point >>> is to edit cdrom properties in place. Because there is only one property can be >>> updated for a cdrom, it works fine this way. Though another inconsistence comes >>> up that in the same storage tab, there is also lines for disks, which have more >>> editable properties and it's not that easy to make all of these properties stay >>> in one line. So for disks, possibly we still need provide another window to let >>> users update properties. >>> So here are 2 choices: >>> C1) Apply this PATCH v2 to keep cdrom consistent with interface >>> C2) Apply PATCH v1 to keep cdrom consistent with disk >>> >>> Both are OK for me. >>> >>> v1 -> v2: >>> 2a) Made updating cdrom properties in place >>> (Aline's comment) >>> >>> Hongliang Wang (2): >>> Adjust Guest Edit Storage Tab Styles >>> Remove Unused Files >>> >>> ui/css/theme-default/guest-cdrom-edit.css | 57 ------------ >>> ui/css/theme-default/guest-edit.css | 99 +++++++------------- >>> ui/images/theme-default/guest-icon-sprite.png | Bin 6748 -> 0 bytes >>> ui/js/src/kimchi.guest_cdrom_edit_main.js | 85 ------------------ >>> ui/js/src/kimchi.guest_edit_main.js | 125 +++++++++++++++++++++----- >>> ui/pages/guest-cdrom-edit.html.tmpl | 70 --------------- >>> ui/pages/guest-edit.html.tmpl | 57 +++++++----- >>> 7 files changed, 166 insertions(+), 327 deletions(-) >>> delete mode 100644 ui/css/theme-default/guest-cdrom-edit.css >>> delete mode 100644 ui/images/theme-default/guest-icon-sprite.png >>> delete mode 100644 ui/js/src/kimchi.guest_cdrom_edit_main.js >>> delete mode 100644 ui/pages/guest-cdrom-edit.html.tmpl >>> >> >> We also need to keep consistence in the "+" button. >> In the network tab, it adds a new line to the list and user change >> the values accordingly. >> And in the storage tab, a new dialog is displayed to collect user input. >> >> Could you send a separate patch for that? > Hi Aline, as I was adding this feature, I found it's different from > interface that for storage, there is not only CDROMs, but also disks. > There are more settings for disks so I suggest retain the pop-up > window for attaching devices. > Good point! And if we do the following: 1) user select + and we add a new line and set the default values for cdrom Type Path cdrom <an empty input box> 2) if user changes type to "disk", we replace the input box for 2 combo boxes, one for storage pool and other for storage volume Type Path disk |storage pool| |storage volume| When user selects "Save" we will know the path based on storage pool and volume, and turns to the first UI Type Path cdrom /var/lib/libvirt/myiso.iso disk /var/lib/libvirt/mypool/mypool-vol.img What do you think?