Re: [Kimchi-devel] [PATCH 0/3] check the python code with pyflakes

Really happy to see some work on it. In order to make the transition smoothly, I think we can enable pyflakes file by file instead of in one monolithic .

2014/3/13 11:13, shaohef(a)linux.vnet.ibm.com: > From: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt; > > Pyflakes analyzes programs and detects various errors. It works by > parsing the source file, not importing it, so it is safe to use on > modules with side effects. It's also much faster. > > This is important to improve the code quality. > > ShaoHe Feng (3): > make pyflakes happly > add template_delete to rollback after create a template > run pyflakes when make check > > Makefile.am | 7 +++++++ > configure.ac | 7 +++++++ > contrib/DEBIAN/control.in | 1 + > contrib/kimchi.spec.fedora.in | 1 + > docs/README.md | 6 +++--- > src/kimchi/control/plugins.py | 2 +- > src/kimchi/featuretests.py | 2 -- > src/kimchi/mockmodel.py | 6 +++--- > src/kimchi/model/storagepools.py | 2 +- > src/kimchi/screenshot.py | 1 - > src/kimchi/template.py | 1 - > tests/test_model.py | 1 + > tests/test_server.py | 1 - > ui/pages/help/gen-index.py | 1 - > 14 files changed, 25 insertions(+), 14 deletions(-) >