Re: [Kimchi-devel] [PATCH] issue #330: Properly log the error message when login fails
On 03/04/2014 10:49 PM, Shu Ming wrote:
2014/3/5 3:35, Aline Manera:
> From: Aline Manera <alinefm(a)br.ibm.com>
>
> The error message and all its parameters must be string.
> So convert error code to string in order to accomplish it.
I think the code is str already. Why should it be converted
explicitly? Is there any error encountered?
Yes.
Take a look in github: https://github.com/kimchi-project/kimchi/issues/330
The error happens because KimchiException() converts all message and
arguments to unicode
So we need to ensure the arguments are strings or do it convert it on
KimchiException() which I think can
cause problems when a different type which does not have str representattion
>
> Signed-off-by: Aline Manera <alinefm(a)br.ibm.com>
> ---
> src/kimchi/auth.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/kimchi/auth.py b/src/kimchi/auth.py
> index af3b610..b16f2db 100644
> --- a/src/kimchi/auth.py
> +++ b/src/kimchi/auth.py
> @@ -107,7 +107,7 @@ def authenticate(username, password,
> service="passwd"):
> try:
> auth.authenticate()
> except PAM.error, (resp, code):
> - msg_args = {'userid': username, 'code': code}
> + msg_args = {'userid': username, 'code': str(code)}
> raise OperationFailed("KCHAUTH0001E", msg_args)
>
> return True