12:33 p.m.
Patch looks good. Just a question:
On 08/02/2016 02:05 AM, pkulkark(a)linux.vnet.ibm.com wrote:
From: Pooja Kulkarni <pkulkark(a)linux.vnet.ibm.com>
This patch externalises some more static
strings missed in Wok.
Signed-off-by: Pooja Kulkarni <pkulkark(a)linux.vnet.ibm.com>
---
ui/pages/login.html.tmpl | 6 +++---
ui/pages/wok-ui.html.tmpl | 8 ++++----
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/ui/pages/login.html.tmpl b/ui/pages/login.html.tmpl
index 6890d9b..d61b22b 100644
--- a/ui/pages/login.html.tmpl
+++ b/ui/pages/login.html.tmpl
@@ -111,12 +111,12 @@
<form id="form-login" class="form-horizontal"
method="post">
<div class="form-group">
<label for="username"
class="sr-only">$_("User Name")</label>
- <input type="text" class="form-control"
id="username" name="username" required="required"
placeholder="$_(" User Name ")" autofocus autocomplete="off"
/>
+ <input type="text" class="form-control"
id="username" name="username" required="required"
placeholder="$_(" User Name ")" autofocus autocomplete="off"
title="" />
<div id="username-msg"
class="msg-required"></div>
</div>
<div class="form-group">
<label for="password"
class="sr-only">$_("Password")</label>
- <input type="password"
class="form-control" id="password" name="password"
required="required" placeholder="$_(" Password ")"
autocomplete="off" />
+ <input type="password"
class="form-control" id="password" name="password"
required="required" placeholder="$_(" Password ")"
autocomplete="off" title=""/>
I've noticed the extra
title=""
In both username and password inputs. I haven't seen any difference in
the UI
with them. Why have you added this empty attribute in those tags?
<div id="password-msg"
class="msg-required"></div>
</div>
<div class="form-group">
@@ -322,7 +322,7 @@
</div>
<div class="row">
<div class="col-lg-4 delayed-fadein">
- <p class="text-muted powered hidden">Powered
by:</p>
+ <p class="text-muted powered
hidden">$_("Powered by:")</p>
<ul id="wok-logos"
class="list-inline"></ul>
</div>
</div>
diff --git a/ui/pages/wok-ui.html.tmpl b/ui/pages/wok-ui.html.tmpl
index e238a34..eaf8815 100644
--- a/ui/pages/wok-ui.html.tmpl
+++ b/ui/pages/wok-ui.html.tmpl
@@ -174,8 +174,8 @@
</div>
<div id="buildme" style="display:none">
- <div><p>Oops! It looks like I am running from a source tree and you
forgot to build!
- Please run the following command from the wok and plugins directories and reload
this page:</p>
+ <div><p>$_("Oops! It looks like I am running from a source
tree and you forgot to build!")
+ $_("Please run the following command from the wok and plugins directories and
reload this page:")</p>
<p><code>make</code></p>
</div>
</div>
@@ -221,10 +221,10 @@
</script>
<footer class="footer">
<div class="container">
- <p class="text-muted powered hidden">$_("Powered
by"):</p>
+ <p class="text-muted powered hidden">$_("Powered
by:")</p>
<ul id="plugins">
</ul>
- <span class="wok-version">Wok Version:
$get_version()</span>
+ <span class="wok-version">$_("Wok Version:")
$get_version()</span>
</div>
</footer>
</body>