November 2016 - Kimchi-devel - oVirt List Archives

[PATCH v3] [Kimchi 0/8] CPU topology setup enhancements
by dhbarboza82＠gmail.com 24 Nov '16

24 Nov '16

From: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com> * NOTE: THIS PATCH SET ISN'T COMPATIBLE WITH STABLE-2.3.X BRANCH * v3: - added an extra patch to handle a problem with the 'Save' button in the Edit Guest window - fixed a bug in the patch that turned 'threads' in a number field v2: - added an extra patch to handle the 'threads' field problem * NOTE: THIS PATCH SET IS NOT APPLICABLE IN THE STABLE-2.3.X BRANCH * This patch set contains several patches that enhances the user experience when configuring existing templates and offline guests, allowing current CPU, maximum CPU and CPU topology to be defined at all times. Daniel Henrique Barboza (8): Bug fix #1072 - changing vpus verification Adding 'sockets' field in the topology of Templates template_edit_main.js: initProcessor now a global function Adding 'Processor' tab in Edit Guest dialog CPU configuration UI: several improvements Adding CPU setup help text in Edit Guest/Template Edit Guest dialog: fixing 'Save' button on Processor tab Changing 'threads' to be a free number field i18n.py | 3 +- model/cpuinfo.py | 4 +- tests/test_model.py | 12 +-- ui/css/kimchi.css | 36 +++++-- ui/css/src/modules/_edit-guests.scss | 28 ++++- ui/css/src/modules/_templates.scss | 3 - ui/js/src/kimchi.guest_edit_main.js | 94 ++++++++--------- ui/js/src/kimchi.template_edit_main.js | 187 ++++++++++++++++++++++----------- ui/pages/guest-edit.html.tmpl | 54 ++++++++-- ui/pages/i18n.json.tmpl | 2 +- ui/pages/template-edit.html.tmpl | 27 +++-- 11 files changed, 296 insertions(+), 154 deletions(-) -- 2.7.4

2 9

[PATCH v2] [Kimchi 0/7] CPU topology setup enhancements
by dhbarboza82＠gmail.com 23 Nov '16

23 Nov '16

From: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com> v2: - added an extra patch to handle the 'threads' field problem * NOTE: THIS PATCH SET IS NOT APPLICABLE IN THE STABLE-2.3.X BRANCH * This patch set contains several patches that enhances the user experience when configuring existing templates and offline guests, allowing current CPU, maximum CPU and CPU topology to be defined at all times. Daniel Henrique Barboza (7): Bug fix #1072 - changing vpus verification Adding 'sockets' field in the topology of Templates template_edit_main.js: initProcessor now a global function Adding 'Processor' tab in Edit Guest dialog CPU configuration UI: several improvements Adding CPU setup help text in Edit Guest/Template Changing 'threads' to be a free number field i18n.py | 3 +- model/cpuinfo.py | 4 +- tests/test_model.py | 12 +-- ui/css/kimchi.css | 36 +++++-- ui/css/src/modules/_edit-guests.scss | 28 +++++- ui/css/src/modules/_templates.scss | 3 - ui/js/src/kimchi.guest_edit_main.js | 75 +++++++------- ui/js/src/kimchi.template_edit_main.js | 172 +++++++++++++++++++++------------ ui/pages/guest-edit.html.tmpl | 54 ++++++++--- ui/pages/i18n.json.tmpl | 1 + ui/pages/template-edit.html.tmpl | 27 ++++-- 11 files changed, 271 insertions(+), 144 deletions(-) -- 2.7.4

2 8

[PATCH] [Kimchi 0/6] CPU topology setup enhancements
by dhbarboza82＠gmail.com 23 Nov '16

23 Nov '16

From: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com> * NOTE: THIS PATCH SET IS NOT APPLICABLE IN THE STABLE-2.3.X BRANCH * This patch set contains several patches that enhances the user experience when configuring existing templates and offline guests, allowing current CPU, maximum CPU and CPU topology to be defined at all times. Daniel Henrique Barboza (6): Bug fix #1072 - changing vpus verification Adding 'sockets' field in the topology of Templates template_edit_main.js: initProcessor now a global function Adding 'Processor' tab in Edit Guest dialog CPU configuration UI: several improvements Adding CPU setup help text in Edit Guest/Template i18n.py | 2 +- model/cpuinfo.py | 2 +- tests/test_model.py | 12 +-- ui/css/kimchi.css | 36 +++++-- ui/css/src/modules/_edit-guests.scss | 28 +++++- ui/css/src/modules/_templates.scss | 3 - ui/js/src/kimchi.guest_edit_main.js | 75 +++++++------- ui/js/src/kimchi.template_edit_main.js | 176 +++++++++++++++++++++------------ ui/pages/guest-edit.html.tmpl | 50 +++++++--- ui/pages/template-edit.html.tmpl | 23 +++-- 10 files changed, 266 insertions(+), 141 deletions(-) -- 2.7.4

2 7

[Kimchi] [RFC] Issue #1063: Upon migrating guest to remote server, password less ssh is permanent
by Archana Singh 16 Nov '16

16 Nov '16

*Currently*: Upon migrating guest to remote server, password less ssh is permanent. Due to that, from terminal able to log on to the remote server with out prompting password *Propose*: Upon completion of migration, password-less ssh has to revoke. Option 1: As migration need password-less ssh, without which migration cannot be done, so it should be delete once migration is completed. Option 2: lets update user that on migration password-less ssh will be established till migration is not completed(May be as document or in UI). And ask user if he was to delete the password-less ssh login or not in migration UI panel. Option 3: Using libvirt.openauth. However I was not able to figure out any proper documentation on how to use openauth. As this is kind of security issue, we can go with Option - 1 to fix the issue for now, enhancement is always possible. :) Thanks, Archana Singh

3 3

[PATCH V2] [Kimchi 0/2] Fixed edit template multiple issues
by rajgupta＠linux.vnet.ibm.com 11 Nov '16

11 Nov '16

From: Rajat Gupta <rajat.triumph(a)gmail.com> Rajat Gupta (2): Fixed issue #1075 s390x : Edit Template storage tab Storage dropdown shows "default" text Fixed issue #1076 s390x : n/w shows twice same interface while adding for template ui/js/src/kimchi.template_edit_main.js | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) -- 2.1.0

3 4

[PATCH] [Kimchi] Fixed issue #1062 Disk path not taking input properly
by rajgupta＠linux.vnet.ibm.com 11 Nov '16

11 Nov '16

From: Rajat Gupta <rajat.triumph(a)gmail.com> Removed add jquery method. separated event registration for size and path text box Signed-off-by: Rajat Gupta <rajat.triumph(a)gmail.com> --- ui/js/src/kimchi.guest_storage_add.main.js | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/ui/js/src/kimchi.guest_storage_add.main.js b/ui/js/src/kimchi.guest_storage_add.main.js index b8e088e..adf4a03 100644 --- a/ui/js/src/kimchi.guest_storage_add.main.js +++ b/ui/js/src/kimchi.guest_storage_add.main.js @@ -595,7 +595,15 @@ kimchi.guest_storage_add_main = function() { if(kimchi.hostarch === s390xArch){ - $(capacityTextbox).add(directorypathTextbox).on('change input propertychange', function(event){ + $(capacityTextbox).on('change input propertychange', function(event){ + if(sourcenewTextbox.val() === 'path'){ + $(submitButton).prop('disabled', $(capacityTextbox).val() === '' || $(directorypathTextbox).val() === ''); + }else{ + $(submitButton).prop('disabled', $(capacityTextbox).val() === ''); + } + }); + + $(directorypathTextbox).on('change input propertychange', function(event){ if(sourcenewTextbox.val() === 'path'){ $(submitButton).prop('disabled', $(capacityTextbox).val() === '' || $(directorypathTextbox).val() === ''); }else{ -- 2.1.0

2 1

[PATCH v2][Wok] Bug fix #151: Wok settings page not working when locale not set
by Ramon Medeiros 11 Nov '16

11 Nov '16

Signed-off-by: Ramon Medeiros <ramonn(a)linux.vnet.ibm.com> --- v2: Check if language is available seeing the length of the return ui/js/src/wok.login.js | 24 +++++++++++++++--------- ui/pages/login.html.tmpl | 4 ++-- 2 files changed, 17 insertions(+), 11 deletions(-) diff --git a/ui/js/src/wok.login.js b/ui/js/src/wok.login.js index 0b09508..fa2a98a 100644 --- a/ui/js/src/wok.login.js +++ b/ui/js/src/wok.login.js @@ -19,18 +19,24 @@ */ wok.login_main = function() { "use strict"; + + // verify if language is available var selectedLanguage = wok.lang.get(); - $('#userLang').val(selectedLanguage); - $('#userLang option[value="'+selectedLanguage+'"]').attr("selected", "selected"); - $('.filter-option:first').parent().attr('title',$('#userLang option[value="'+selectedLanguage+'"]').text()); - $('.filter-option:first').text($('#userLang option[value="'+selectedLanguage+'"]').text()); + if ($('#userLang option[value="'+selectedLanguage+'"]').length == 1) { + $('#userLang').val(selectedLanguage); + $('#userLang option[value="'+selectedLanguage+'"]').attr("selected", "selected"); + $('.filter-option:first').parent().attr('title',$('#userLang option[value="'+selectedLanguage+'"]').text()); + $('.filter-option:first').text($('#userLang option[value="'+selectedLanguage+'"]').text()); + } + // verify if locale is available var selectedLocale = wok.lang.get_locale(); - $('#userLocale').val(selectedLocale); - $('#userLocale option[value="'+selectedLocale+'"]').attr("selected", "selected"); - $('.filter-option:last').parent().attr('title',$('#userLocale option[value="'+selectedLocale+'"]').text()); - $('.filter-option:last').text($('#userLocale option[value="'+selectedLocale+'"]').text()); - + if ($('#userLocale option[value="'+selectedLocale+'"]').length == 1) { + $('#userLocale').val(selectedLocale); + $('#userLocale option[value="'+selectedLocale+'"]').attr("selected", "selected"); + $('.filter-option:last').parent().attr('title',$('#userLocale option[value="'+selectedLocale+'"]').text()); + $('.filter-option:last').text($('#userLocale option[value="'+selectedLocale+'"]').text()); + } $('#userLang').on('change', function() { wok.lang.set($(this).val()); diff --git a/ui/pages/login.html.tmpl b/ui/pages/login.html.tmpl index 431806c..d74b795 100644 --- a/ui/pages/login.html.tmpl +++ b/ui/pages/login.html.tmpl @@ -128,7 +128,7 @@ <div class="form-group"> <label for="userLang">$_("Language")</label> <select id="userLang" class="selectpicker col-md-12 col-lg-12"> - <option value="en_US">English (US)</option> + <option value="en_US" selected="selected">English (US)</option> <option value="zh_CN">中文（简体）</option> <option value="pt_BR">Português (Brasil)</option> <option value="de_DE">Deutsch (Deutschland)</option> @@ -202,7 +202,7 @@ <option value="en-ZA">$_("English (South Africa)")</option> <option value="en-TZ">$_("English (Tanzania)")</option> <option value="en-GB">$_("English (United Kingdom)")</option> - <option value="en-US">$_("English (United States)")</option> + <option value="en-US" selected="selected">$_("English (United States)")</option> <option value="en-ZM">$_("English (Zambia)")</option> <option value="et-EE">$_("Estonian (Estonia)")</option> <option value="tl-PH">$_("Filipino (Philippines)")</option> -- 2.7.4

2 1

[PATCH v2] [Wok] Externalise missed strings in Wok.
by pkulkark＠linux.vnet.ibm.com 11 Nov '16

11 Nov '16

From: Pooja Kulkarni <pkulkark(a)linux.vnet.ibm.com> v2: Included space in title field v1: This patch externalises some more static strings missed in Wok and removes tooltip. Signed-off-by: Pooja Kulkarni <pkulkark(a)linux.vnet.ibm.com> --- ui/pages/login.html.tmpl | 6 +++--- ui/pages/wok-ui.html.tmpl | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/ui/pages/login.html.tmpl b/ui/pages/login.html.tmpl index 170f8fe..431806c 100644 --- a/ui/pages/login.html.tmpl +++ b/ui/pages/login.html.tmpl @@ -111,12 +111,12 @@ <form id="form-login" class="form-horizontal" method="post"> <div class="form-group"> <label for="username" class="sr-only">$_("User Name")</label> - <input type="text" class="form-control" id="username" name="username" required="required" placeholder="$_(" User Name ")" autofocus autocomplete="off" /> + <input type="text" class="form-control" id="username" name="username" required="required" placeholder="$_(" User Name ")" autofocus autocomplete="off" title=" " /> <div id="username-msg" class="msg-required"></div> </div> <div class="form-group"> <label for="password" class="sr-only">$_("Password")</label> - <input type="password" class="form-control" id="password" name="password" required="required" placeholder="$_(" Password ")" autocomplete="off" /> + <input type="password" class="form-control" id="password" name="password" required="required" placeholder="$_(" Password ")" autocomplete="off" title=" "/> <div id="password-msg" class="msg-required"></div> </div> <div class="form-group"> @@ -322,7 +322,7 @@ </div> <div class="row"> <div class="col-lg-4 delayed-fadein"> - <p class="text-muted powered hidden">Powered by:</p> + <p class="text-muted powered hidden">$_("Powered by:")</p> <ul id="wok-logos" class="list-inline"></ul> </div> </div> diff --git a/ui/pages/wok-ui.html.tmpl b/ui/pages/wok-ui.html.tmpl index 22a67e7..9ac7157 100644 --- a/ui/pages/wok-ui.html.tmpl +++ b/ui/pages/wok-ui.html.tmpl @@ -168,8 +168,8 @@ </div> <div id="buildme" style="display:none"> - <div><p>Oops! It looks like I am running from a source tree and you forgot to build! - Please run the following command from the wok and plugins directories and reload this page:</p> + <div><p>$_("Oops! It looks like I am running from a source tree and you forgot to build!") + $_("Please run the following command from the wok and plugins directories and reload this page:")</p> <p><code>make</code></p> </div> </div> @@ -215,10 +215,10 @@ </script> <footer class="footer"> <div class="container"> - <p class="text-muted powered hidden">$_("Powered by"):</p> + <p class="text-muted powered hidden">$_("Powered by:")</p> <ul id="plugins"> </ul> - <span class="wok-version">Wok Version: $get_version()</span> + <span class="wok-version">$_("Wok Version:") $get_version()</span> </div> </footer> </body> -- 2.1.0

2 2

[PATCH] [Wok 0/6] Bug fix #175: Do not generate nginx configuration file on the fly
by Aline Manera 11 Nov '16

11 Nov '16

Aline Manera (6): Fix 'make check' issues Remove log size information from Wok config Add nginx.service as wokd.service dependency Generate SSL self signed certificate on package post installation script Bug fix #175: Do not generate nginx configuration file on the fly Remove nginx-specific parameters from wok.conf file .gitignore | 1 - IBM-license-blacklist | 4 +- Makefile.am | 7 +- contrib/DEBIAN/control.in | 1 + contrib/DEBIAN/postinst | 1 + contrib/DEBIAN/postrm | 1 + contrib/Makefile.am | 2 +- contrib/wok.spec.fedora.in | 11 +-- contrib/wok.spec.suse.in | 41 ++++++---- contrib/wokd.service.fedora | 12 --- contrib/wokd.service.systemd | 14 ++++ docs/API/config.md | 4 +- docs/wokd.8.in | 16 ++-- src/nginx/Makefile.am | 7 +- src/nginx/wok.conf | 82 ++++++++++++++++++++ src/nginx/wok.conf.in | 75 ------------------ src/wok.conf.in | 23 +----- src/wok/config.py.in | 11 +-- src/wok/i18n.py | 2 - src/wok/model/config.py | 2 +- src/wok/plugins/sample/po/update-po | 2 +- src/wok/proxy.py | 147 ++++++++++-------------------------- src/wok/server.py | 6 +- src/wok/sslcert.py | 2 +- src/wokd.in | 18 +---- tests/test_api.py | 14 +--- tests/test_exception.py | 52 +++---------- tests/test_plugin.py | 12 +-- tests/test_server.py | 15 +--- tests/test_server_root.py | 17 ++--- tests/utils.py | 83 ++++---------------- 31 files changed, 242 insertions(+), 443 deletions(-) delete mode 100644 contrib/wokd.service.fedora create mode 100644 contrib/wokd.service.systemd create mode 100644 src/nginx/wok.conf delete mode 100644 src/nginx/wok.conf.in -- 2.7.4

3 11

[PATCH] [Kimchi] po/ja_JP.po: fix trailing whitespace
by dhbarboza82＠gmail.com 10 Nov '16

10 Nov '16

From: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com> This file is breaking make check-local of 'master' branch with a trailing whitespace. Signed-off-by: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com> --- po/ja_JP.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/po/ja_JP.po b/po/ja_JP.po index eea7131..294ea14 100644 --- a/po/ja_JP.po +++ b/po/ja_JP.po @@ -2175,7 +2175,7 @@ msgid "" msgstr "" msgid "Add Network" -msgstr "" +msgstr "" msgid "" "The %1 network is not persistent. Instead of stop, this action will " -- 2.7.4

3 2