[RFC] Use javascript libraries from rpms instead of hardcode it inside the git
by Ramon Medeiros
Hi,
i want to use javascript libraries from rpms, but, not all libraries are
available in distro repos. So let's discuss how i can do it:
Fedora case:
Fedora has jquery, lodash, moment, typeahead and es5-shim libraries
available.
Opensuse:
No library available
Ubuntu:
Ubuntu has bootstrap, jquery, jquery-ui e lodash.
As not all libraries are available, i received a suggestion to use a
parameter at configure.ac, like --with-spice, to choose libs from rpm or
from the code. So, what is best:
Use single parameter (--use-js-from-rpms)
I will need to check the distro by code and generate the html templates
with the script tag changed.
Use parameters with distros (--ubuntu-use-js-from-rpms)
Same as above, but distro will not be checked.
--
Ramon Nunes Medeiros
Kimchi Developer
Linux Technology Center Brazil
IBM Systems & Technology Group
Phone : +55 19 2132 7878
ramonn(a)br.ibm.com
8 years, 2 months
Question on https_only flag of /etc/wok/wok.conf
by Suresh Babu Angadi
Hi All,
Per default settings, 8000 is used as http port and 8001 is used as
https port.
case 1: https_only=true, was not able to browse with 8000 port, which is
as expected.
case 2: https_only=false, per my understanding, it should allow http
connections, but all the requests are rerouted to https and 8001 port.
So is it the case that, though https_only is false, no requests are
handled in 8000(http) port? please help me understand the significance
of https_only flag.
--
Regards,
Suresh Babu Angadi
8 years, 2 months
[PATCH ][Wok]Ginger Issue #376:Unable to edit the text field or click submit/cancel after press ESC or click outside the error message dialog of Add User.
by atreyee＠linux.vnet.ibm.com
From: Atreyee Mukhopadhyay <atreyee(a)linux.vnet.ibm.com>
ESC button click/blur handler was not available for wok.confirm.
---
ui/js/src/wok.confirm.js | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/ui/js/src/wok.confirm.js b/ui/js/src/wok.confirm.js
index fde76bf..9b2fdaf 100644
--- a/ui/js/src/wok.confirm.js
+++ b/ui/js/src/wok.confirm.js
@@ -32,8 +32,10 @@
* the callback function of click the confirm button.
* @param cancelCallback
* The callback function of click the cancel and X button.
+ * @param closeCallback
+ * The callback function of click the Esc button and blur.
*/
-wok.confirm = function(settings, confirmCallback, cancelCallback) {
+wok.confirm = function(settings, confirmCallback, cancelCallback, closeCallback) {
"use strict";
var modalStr = '<div id="wok-confirm-modal" class="modal fade host-modal" tabindex="-1" role="dialog" aria-labelledby="confirmModalLabel" aria-hidden="true"></div>';
if ($('#wok-confirm-modal ').size() < 1 && $('#modalWindow').size() < 1 ) {
@@ -86,6 +88,9 @@ wok.confirm = function(settings, confirmCallback, cancelCallback) {
"use strict";
$('#wok-confirm-modal').removeData('bs.modal');
$('#wok-confirm-modal').remove();
+ if (closeCallback) {
+ closeCallback();
+ }
};
-};
\ No newline at end of file
+};
--
2.1.0
8 years, 2 months
[PATCH] [Wok] Externalise missed strings in Wok.
by pkulkark＠linux.vnet.ibm.com
From: Pooja Kulkarni <pkulkark(a)linux.vnet.ibm.com>
This patch externalises some more static
strings missed in Wok.
Signed-off-by: Pooja Kulkarni <pkulkark(a)linux.vnet.ibm.com>
---
ui/pages/login.html.tmpl | 6 +++---
ui/pages/wok-ui.html.tmpl | 8 ++++----
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/ui/pages/login.html.tmpl b/ui/pages/login.html.tmpl
index 6890d9b..d61b22b 100644
--- a/ui/pages/login.html.tmpl
+++ b/ui/pages/login.html.tmpl
@@ -111,12 +111,12 @@
<form id="form-login" class="form-horizontal" method="post">
<div class="form-group">
<label for="username" class="sr-only">$_("User Name")</label>
- <input type="text" class="form-control" id="username" name="username" required="required" placeholder="$_(" User Name ")" autofocus autocomplete="off" />
+ <input type="text" class="form-control" id="username" name="username" required="required" placeholder="$_(" User Name ")" autofocus autocomplete="off" title="" />
<div id="username-msg" class="msg-required"></div>
</div>
<div class="form-group">
<label for="password" class="sr-only">$_("Password")</label>
- <input type="password" class="form-control" id="password" name="password" required="required" placeholder="$_(" Password ")" autocomplete="off" />
+ <input type="password" class="form-control" id="password" name="password" required="required" placeholder="$_(" Password ")" autocomplete="off" title=""/>
<div id="password-msg" class="msg-required"></div>
</div>
<div class="form-group">
@@ -322,7 +322,7 @@
</div>
<div class="row">
<div class="col-lg-4 delayed-fadein">
- <p class="text-muted powered hidden">Powered by:</p>
+ <p class="text-muted powered hidden">$_("Powered by:")</p>
<ul id="wok-logos" class="list-inline"></ul>
</div>
</div>
diff --git a/ui/pages/wok-ui.html.tmpl b/ui/pages/wok-ui.html.tmpl
index e238a34..eaf8815 100644
--- a/ui/pages/wok-ui.html.tmpl
+++ b/ui/pages/wok-ui.html.tmpl
@@ -174,8 +174,8 @@
</div>
<div id="buildme" style="display:none">
- <div><p>Oops! It looks like I am running from a source tree and you forgot to build!
- Please run the following command from the wok and plugins directories and reload this page:</p>
+ <div><p>$_("Oops! It looks like I am running from a source tree and you forgot to build!")
+ $_("Please run the following command from the wok and plugins directories and reload this page:")</p>
<p><code>make</code></p>
</div>
</div>
@@ -221,10 +221,10 @@
</script>
<footer class="footer">
<div class="container">
- <p class="text-muted powered hidden">$_("Powered by"):</p>
+ <p class="text-muted powered hidden">$_("Powered by:")</p>
<ul id="plugins">
</ul>
- <span class="wok-version">Wok Version: $get_version()</span>
+ <span class="wok-version">$_("Wok Version:") $get_version()</span>
</div>
</footer>
</body>
--
2.1.0
8 years, 2 months
