Some tests fail with this patch. All of them are related to VM user management - which is related to VM metadata. Please run "sudo make check" to make sure new patches don't break the application. ====================================================================== FAIL: test_nonroot_access (test_authorization.AuthorizationTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "test_authorization.py", line 146, in test_nonroot_access sorted([v['name'] for v in vms_data])) AssertionError: Lists differ: [u'test-groupa', u'test-me'] != [] First list contains 2 additional elements. First extra element 0: test-groupa - [u'test-groupa', u'test-me'] + [] ====================================================================== FAIL: test_edit_vm (test_rest.HttpsRestTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "test_rest.py", line 220, in test_edit_vm self.assertEquals(users, info['users']) AssertionError: Lists differ: [u'root', u'sync', u'shutdown'... != [] First list contains 5 additional elements. First extra element 0: root - [u'root', u'sync', u'shutdown', u'halt', u'kimchi'] + [] ====================================================================== FAIL: test_tasks (test_rest.HttpsRestTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "test_rest.py", line 1035, in test_tasks self.assertEquals(3, len(tasks)) AssertionError: 3 != 2 ====================================================================== FAIL: test_edit_vm (test_rest.RestTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "test_rest.py", line 220, in test_edit_vm self.assertEquals(users, info['users']) AssertionError: Lists differ: [u'root', u'sync', u'shutdown'... != [] First list contains 5 additional elements. First extra element 0: root - [u'root', u'sync', u'shutdown', u'halt', u'kimchi'] + [] ---------------------------------------------------------------------- On 05-05-2015 10:02, Ramon Medeiros wrote:
Changes:
v2: Improve coding to avoid code duplication
The function FeatureTests.disable_libvirt_error_logging only removes the error message that will be displayed on the console. Libvirt also logs errors on messages log. To avoid flood messages log with metadata errors, it will be verified manually if the xml has the tag.
Signed-off-by: Ramon Medeiros <ramonn@linux.vnet.ibm.com>