Re: [Kimchi-devel] [Kimchi 1/4] Create new field to create VM
On 12/24/2015 09:38 AM, Rodrigo Trujillo wrote:
On 12/23/2015 01:12 PM, Ramon Medeiros wrote:
> Create a single field to pass the installation media.
>
> Signed-off-by: Ramon Medeiros <ramonn(a)linux.vnet.ibm.com>
> ---
> API.json | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/API.json b/API.json
> index 2b64d07..13fcfd3 100644
> --- a/API.json
> +++ b/API.json
> @@ -460,6 +460,11 @@
> "minimum": 512,
> "error": "KCHTMPL0013E"
> },
> + "installation_media": {
> + "description": "Path for installation media
> (ISO, disk, remote ISO)",
> + "type" : "string",
> + "pattern" : "^[^ ]+( +[^ ]+)*$"
> + },
Two things:
1- there will be a pattern checking here, when you create the
template, so we need a error field.
2- what about the cdrom parameter below ? will it be discontinued ?
Would you have to remove it and make all adjustments need in the code ?
Like i said in the cover letter, i'm planning to remove this after the
UI code being merged. But, if you think it's better to remove now, we
can do.
> "cdrom": {
> "description": "Path for cdrom",
> "type": "string",
_______________________________________________
Kimchi-devel mailing list
Kimchi-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel
--
Ramon Nunes Medeiros
Kimchi Developer
Linux Technology Center Brazil
IBM Systems & Technology Group
Phone : +55 19 2132 7878
ramonn(a)br.ibm.com