Re: [Kimchi-devel] [PATCH 2/4] Download Remote Image UI: Add Corresponding Window

On 11-09-2014 04:37, Hongliang Wang wrote: > 1. eval() is supposed not to be abused due to security and > performance. > (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_...) ACK > > 2. We need 2 parts: downloaded size, and total size. When > eval('1024/2048') we'll get only the percentage without total size > information. I'll use regular expression to make here clearer. ACK. Also, the second number (i.e. "total") may be "-" when the HTTP header "Content-Length" is not available. This patch needs to check that case as well.