Re: [Kimchi-devel] [PATCH] bug fix: Properly set max body size to nginx proxy

On 09-09-2014 23:44, Aline Manera wrote:

+ # upload Kimchi's "COPYING" and compare its + # content to the corresponding file in the storage pool

The test below doesn't match with this description. I couldn't find where the uploaded file's content is compared to the original file's.

+ files={'file': open(vol_path, 'rb')},

You need to close the file handler opened above.

+ # Max body size is set to 4M so the upload will fail with 413

4M? Isn't it 4G?

+ r = requests.post(url, + files={'file': open(vol_path, 'rb')}, You also need to close this file handler.