Hi, The combobox() and filterselect() calls in the next line were part of the JS widgets that were removed from Wok in "Remove legacy code under ui/js/widgets". I was going to replace them by typeahead.js but due the limited amount of time we are going to skip that for now and we'll replace them for Typeahead.js later as an enhancement. I've sent a new patch reverting these two widgets and the page works as expected. Regards, Samuel -----Original Message----- From: kimchi-devel-bounces@ovirt.org [mailto:kimchi-devel-bounces@ovirt.org] On Behalf Of Aline Manera Sent: quarta-feira, 17 de fevereiro de 2016 17:24 To: peterpnns@gmail.com; Kimchi Devel <kimchi-devel@ovirt.org> Subject: Re: [Kimchi-devel] [PATCH] [Kimchi] Create logical pool from existing VG Hi Peter, I was not able to test it due a JS error when loading the new Storage Pool dialog: TypeError: $(...).combobox is not a function Could you take a look on it, please? Regards, Aline Manera On 02/15/2016 08:35 AM, peterpnns@gmail.com wrote:
From: peterpennings <peterpnns@gmail.com>
This patch adds an option to create logical pools from existing VG.
peterpennings (1): Create logical pool from existing VG
ui/js/src/kimchi.api.js | 13 ++++ ui/js/src/kimchi.storagepool_add_main.js | 103 +++++++++++++++++++++++++++---- ui/pages/storagepool-add.html.tmpl | 39 ++++++++---- 3 files changed, 132 insertions(+), 23 deletions(-)
_______________________________________________ Kimchi-devel mailing list Kimchi-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel