[PATCH] Do not show a success msg when creating a template
Tested on Fedora 20. Crístian Viana (1): Do not show a success msg when creating a template ui/js/src/kimchi.template_add_main.js | 1 - 1 file changed, 1 deletion(-) -- 1.8.5.3
When the user creates a new template, a green success message is displayed on top of the screen. This behavior is not common in Kimchi; when an operation performs successfully, nothing is shown. Actually, the templates page is the only one that does that. In order to make Kimchi more consistent, remove the code that displays a success message when the user creates a new template. Signed-off-by: Crístian Viana <vianac@linux.vnet.ibm.com> --- ui/js/src/kimchi.template_add_main.js | 1 - 1 file changed, 1 deletion(-) diff --git a/ui/js/src/kimchi.template_add_main.js b/ui/js/src/kimchi.template_add_main.js index 5fd6532..dbb3952 100644 --- a/ui/js/src/kimchi.template_add_main.js +++ b/ui/js/src/kimchi.template_add_main.js @@ -365,7 +365,6 @@ kimchi.template_add_main = function() { }; kimchi.createTemplate(data, function() { successNum++; - kimchi.message.success(i18n['KCHTMPL6001M'] + ': ' + isoInfo.name); $('input[value="' + isoInfo.isoId + '"]').prop('checked', false); $('.check-all>input').prop('checked', false); kimchi.doListTemplates(); -- 1.8.5.3
Reviewed-by: ShaoHe Feng <shaohef@linux.vnet.ibm.com> not seen this green message on my host. But agree we should keep consistent. On 03/08/2014 04:45 AM, Crístian Viana wrote:
When the user creates a new template, a green success message is displayed on top of the screen. This behavior is not common in Kimchi; when an operation performs successfully, nothing is shown. Actually, the templates page is the only one that does that.
In order to make Kimchi more consistent, remove the code that displays a success message when the user creates a new template.
Signed-off-by: Crístian Viana <vianac@linux.vnet.ibm.com> --- ui/js/src/kimchi.template_add_main.js | 1 - 1 file changed, 1 deletion(-)
diff --git a/ui/js/src/kimchi.template_add_main.js b/ui/js/src/kimchi.template_add_main.js index 5fd6532..dbb3952 100644 --- a/ui/js/src/kimchi.template_add_main.js +++ b/ui/js/src/kimchi.template_add_main.js @@ -365,7 +365,6 @@ kimchi.template_add_main = function() { }; kimchi.createTemplate(data, function() { successNum++; - kimchi.message.success(i18n['KCHTMPL6001M'] + ': ' + isoInfo.name); $('input[value="' + isoInfo.isoId + '"]').prop('checked', false); $('.check-all>input').prop('checked', false); kimchi.doListTemplates();
-- Thanks and best regards! Sheldon Feng(冯少合)<shaohef@linux.vnet.ibm.com> IBM Linux Technology Center
On 03/10/2014 09:24 PM, Crístian Viana wrote:
Am 10-03-2014 05:39, schrieb Sheldon:
not seen this green message on my host. Try to create a new template. Doesn't it happen on your system?? It does on mine every time... (and there's the code there, afterall). I have tried.
yes. I see the code. So Reviewed. :-)
-- Thanks and best regards! Sheldon Feng(冯少合)<shaohef@linux.vnet.ibm.com> IBM Linux Technology Center
participants (3)
-
Aline Manera -
Crístian Viana -
Sheldon