October 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: gluster: Fixed coverity scan failure in GetGlusterVolumeReba...
by kmayilsa＠redhat.com 15 Oct '13

15 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Fixed coverity scan failure in GetGlusterVolumeRebalanceStatusQueryTest ...................................................................... gluster: Fixed coverity scan failure in GetGlusterVolumeRebalanceStatusQueryTest Fixed an coverity scan failure issue in the test case class GetGlusterVolumeRebalanceStatusQueryTest. Change-Id: I767f981cfefa8a783cc636e96cc32675fc17aefc Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRebalanceStatusQueryTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I767f981cfefa8a783cc636e96cc32675fc17aefc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Populate host name in volume rebalance status
by kmayilsa＠redhat.com 15 Oct '13

15 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Populate host name in volume rebalance status ...................................................................... gluster: Populate host name in volume rebalance status Modified the query to set the host name instead of localhost in gluster volume rebalance status details. Change-Id: If83755d715df3cf116afa9dfa87b2f8680e8fffa Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRebalanceStatusQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRebalanceStatusQueryTest.java 2 files changed, 42 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19665 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If83755d715df3cf116afa9dfa87b2f8680e8fffa Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Included additional fields in rebalance status
by kmayilsa＠redhat.com 15 Oct '13

15 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Included additional fields in rebalance status ...................................................................... gluster: Included additional fields in rebalance status Included the adiitional fields runtime, filesSkipped and houstUuid in gluster rebalance status entity class. Change-Id: I71a20fbb93a9731ca2ff68ddd401589d319226d4 Bug-Url: https://bugzilla.redhat.com/1011883 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeTaskStatusForHost.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeTaskReturnForXmlRpc.java 2 files changed, 19 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71a20fbb93a9731ca2ff68ddd401589d319226d4 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Changed the type of numeric fields to long
by kmayilsa＠redhat.com 15 Oct '13

15 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Changed the type of numeric fields to long ...................................................................... gluster: Changed the type of numeric fields to long Changed the type fo numeric fields in class GlusterVolumeTaskStatusDetail. This is required because numeric fields in status might be holding bigger values and we need long to hold these values. Change-Id: I5c1ade59e328bfcc1440ba8ac410848d296a6a26 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeTaskStatusDetail.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeTaskReturnForXmlRpc.java 2 files changed, 28 insertions(+), 24 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c1ade59e328bfcc1440ba8ac410848d296a6a26 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix findbug error - possible NPE
by amureini＠redhat.com 15 Oct '13

15 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Fix findbug error - possible NPE ...................................................................... engine: Fix findbug error - possible NPE FindBug returned this error of possible NPE though the Dao returns an empty list and not null. Change-Id: I73a087ed678f8fffca9aabbb56bf1baacb5a0a44 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20103 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73a087ed678f8fffca9aabbb56bf1baacb5a0a44 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: REST api for stop rebalance of volume
by mpastern＠redhat.com 15 Oct '13

15 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: REST api for stop rebalance of volume ...................................................................... restapi: REST api for stop rebalance of volume REST api for stop rebalance of volume Change-Id: I12c4d83e2c7e8c89dd9f820bc26ef369a4cb0490 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> Signed-off-by: Timothy Asir <tjeyasin(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterVolumeRebalanceParameters.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterVolumeResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumeResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumeResourceTest.java 5 files changed, 44 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19167 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12c4d83e2c7e8c89dd9f820bc26ef369a4cb0490 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Prevent empty MAC Address range
by masayag＠redhat.com 15 Oct '13

15 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Prevent empty MAC Address range ...................................................................... engine: Prevent empty MAC Address range The patch prevents a user from entering a mac address range which might result in an empty pool, for example a range which contains multicast mac addresses only. Change-Id: I24113379e8fbbc15a63bdb1be4e6c719d7cb764f Bug-Url: https://bugzilla.redhat.com/1011912 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MacAddressRangeUtils.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelper.java M backend/manager/tools/src/test/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelperTest.java 4 files changed, 73 insertions(+), 73 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20155 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24113379e8fbbc15a63bdb1be4e6c719d7cb764f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: build: ovirt-hosted-engine-setup-1.0.0-0.6.beta1
by sbonazzo＠redhat.com 15 Oct '13

15 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-setup-1.0.0-0.6.beta1 ...................................................................... build: ovirt-hosted-engine-setup-1.0.0-0.6.beta1 Change-Id: I800909067a75ff4b15b7c3f28af022d35d358a68 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 12 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20167 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I800909067a75ff4b15b7c3f28af022d35d358a68 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: vdsm: use startMonitoringDomain
by sbonazzo＠redhat.com 15 Oct '13

15 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: vdsm: use startMonitoringDomain ...................................................................... vdsm: use startMonitoringDomain Use startMonitoringDomain VDSM API for monitoring hosted engine storage domain in order to support shared:exclusive images without a pool. Use getVdsStats for waiting the start of the domain monitor. Updated vdsm minimum version required according to VDSM API documentation for startMonitoringDomain. Change-Id: I3099081b79d461685901a1a32e9d526bd3bb758a Requires: http://gerrit.ovirt.org/19762 Requires: http://gerrit.ovirt.org/20099 Bug-Url: https://bugzilla.redhat.com/1015136 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in M src/ovirt_hosted_engine_setup/tasks.py M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 3 files changed, 53 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20166 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3099081b79d461685901a1a32e9d526bd3bb758a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: agent: fix arguments to vdsClient migrate invocation
by gpadgett＠redhat.com 15 Oct '13

15 Oct '13

Greg Padgett has submitted this change and it was merged. Change subject: agent: fix arguments to vdsClient migrate invocation ...................................................................... agent: fix arguments to vdsClient migrate invocation The run_vds_client_command() function expects a boolean parameter for ssl state but was being sent a text string, causing migration to fail. Change-Id: I25aaaa3d6cc32a8e36e6366a24cf2db43c0039b0 Bug-Url: https://bugzilla.redhat.com/1015721 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/hosted_engine.py 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25aaaa3d6cc32a8e36e6366a24cf2db43c0039b0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0