March 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: persistent in-memory lock for remove template

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: core: persistent in-memory lock for remove template ...................................................................... core: persistent in-memory lock for remove template This patch replace the existing exclusive lock of the remove template command with a persistent (isReleaseAtEndOfExecute = false) exclusive lock. there's also a new customized error message attached to the modified lock. Note that the lock of the template in DB remains so all the places that check whether the template is locked according to the status in the DB will still get valid result. Change-Id: I6cec457a44e4059e21c344acdaf8d17c9d26c686 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 16 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6cec457a44e4059e21c344acdaf8d17c9d26c686 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Network validator tests use assertThat

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Network validator tests use assertThat ...................................................................... engine: Network validator tests use assertThat Refactored the network validator's tests to use assertThat syntax with the newly introduced matchers for ValidationResult. Change-Id: Ic8bfd0e15f0204f4a4a099a322fa78d8b33aec85 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmNicValidatorTest.java 3 files changed, 97 insertions(+), 81 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13062 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8bfd0e15f0204f4a4a099a322fa78d8b33aec85 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Added ValidationResult matchers

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Added ValidationResult matchers ...................................................................... engine: Added ValidationResult matchers The matchers can be used for testing that validation result complies with a given expectation, using JUnit's assertThat syntax. For example: To check that validationMethod() returned a valid result: assertThat(validationMethod(),isValid()); To check that validationMethod() fails with an error message VdcBllMessages.EXPECTED_ERROR_MESSAGE: assertThat(validationMethod(), failsWith(VdcBllMessages.EXPECTED_ERROR_MESSAGE)); Change-Id: I4ed3d5e1e698f5ac00d6a6fe20b855619c35a2ec Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/ValidationResultMatchers.java 1 file changed, 141 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ed3d5e1e698f5ac00d6a6fe20b855619c35a2ec Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: pki: use relative lock file

by dfediuck＠redhat.com

Doron Fediuck has submitted this change and it was merged. Change subject: pki: use relative lock file ...................................................................... pki: use relative lock file Current implementation uses /var/lock/ovirt-engine/* to perform lock of pki operations. Problem in current implementation is that /var/lock may be cleared on distributions so no ovirt-engine exists. Also, in development mode there is no access to /var directory. The new implementation uses persistent SignReq.lock file which is relative to SignReq.sh at PREFIX/etc, which is a valid location. Change-Id: I4274778254167db8f632908a9bdcc0d6ad284b3e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile A backend/manager/conf/ca/SignReq.lock M backend/manager/conf/ca/SignReq.sh M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/OpenSslCAWrapper.java M packaging/fedora/spec/ovirt-engine.spec.in 8 files changed, 8 insertions(+), 43 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4274778254167db8f632908a9bdcc0d6ad284b3e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Making all internal actions to have same correlation...

by mkublin＠redhat.com

Michael Kublin has submitted this change and it was merged. Change subject: engine: Making all internal actions to have same correlationId ...................................................................... engine: Making all internal actions to have same correlationId The following patch will force all internal actions to have same correlationId. When an action triggered from gui or rest client, it should pass a correlationId otherwise it will be automaticly generated. But, if action has some another internal actions they will have different correlationId. This patch will fix a problem. Discovered during work on provided bug This patch is addition to previous with Change-Id: I47ad8e04452b7f0e3f5f8477f84bc6b22e35ec98 Change-Id: Ib12f9079a564bb507b3a3a0f84601e918bd92b3f Bug-Url: https://bugzilla.redhat.com/844335 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13101 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib12f9079a564bb507b3a3a0f84601e918bd92b3f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[engine_3.2]: packaging: post ovirt-engine-3.2.1

by oschreib＠redhat.com

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: post ovirt-engine-3.2.1 ...................................................................... packaging: post ovirt-engine-3.2.1 Change-Id: Ic649ea946a91adecc5add36a72905ad42eaa57e6 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M version.mak 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13096 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic649ea946a91adecc5add36a72905ad42eaa57e6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: core: helper methods to create locking pair

by mkublin＠redhat.com

Michael Kublin has submitted this change and it was merged. Change subject: core: helper methods to create locking pair ...................................................................... core: helper methods to create locking pair It is becoming more and more common to use the new infrastructure that allows us to attach customized error message to a lock, that will be shown in case other locks cannot be acquired because of that lock. This patch adds helper methods in LockMessagesMatchUtils class for creating the locking pair which contains locking group and the customized error message. Change-Id: Id0c854cfc3b6cb1b7f7f4907452e116af5fbf6bf Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LockMessagesMatchUtil.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java 3 files changed, 53 insertions(+), 31 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0c854cfc3b6cb1b7f7f4907452e116af5fbf6bf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: Revert "engine: VdsDeploy cleanup 1"

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: Revert "engine: VdsDeploy cleanup 1" ...................................................................... Revert "engine: VdsDeploy cleanup 1" This reverts commit ee531b788e880e60cae87d82c3553239f2eb7778. Change-Id: I1f964a0474dbd6ffabe531bd995ad4abbf4381d6 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java 1 file changed, 15 insertions(+), 15 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13079 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f964a0474dbd6ffabe531bd995ad4abbf4381d6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: Partial Revert "engine: unit test for VdsDeploy.getEngineSSH...

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: Partial Revert "engine: unit test for VdsDeploy.getEngineSSHPublicKey" ...................................................................... Partial Revert "engine: unit test for VdsDeploy.getEngineSSHPublicKey" This reverts commit 4b387e8d8ff0bc11ef6901ae9e4ecb9b12c938b8. Change-Id: I38fa07c853d202bb4bdcd83cdb658fff0864b758 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VdsDeployTest.java 2 files changed, 11 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38fa07c853d202bb4bdcd83cdb658fff0864b758 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: userportal: Fix url-pattern for GwtCachingFilter

by vszocs＠redhat.com

Vojtech Szocs has submitted this change and it was merged. Change subject: userportal: Fix url-pattern for GwtCachingFilter ...................................................................... userportal: Fix url-pattern for GwtCachingFilter This patch fixes wrong url-pattern for GwtCachingFilter, so that UserPortal resources have proper caching policies applied via this filter. Change-Id: I7f40e41ca17bdb9870b60d112af8f12bab82e6e9 Bug-Url: https://bugzilla.redhat.com/875814 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13095 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f40e41ca17bdb9870b60d112af8f12bab82e6e9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

11 years, 8 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits March 2013