Change in ovirt-engine[master]: restapi: remove unneeded fetch of template disk entity
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: remove unneeded fetch of template disk entity
......................................................................
restapi: remove unneeded fetch of template disk entity
Remove unneeded call to AbstractBackendCollectionResource#getEntity from
BackendTemplateDisksResource#performRemove, as this method is already
called from AbstractBackendCollectionResource#remove before to ensure
the entity exists, and that's the only flow in which
BackendTemplateDisksResource#performRemove should be called.
Change-Id: Iae1f12ad70371127fd4dceddf302798fa8b750b4
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDisksResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDisksResourceTest.java
2 files changed, 2 insertions(+), 3 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12928
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae1f12ad70371127fd4dceddf302798fa8b750b4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: engine: Hosts - finished to mark all operations as NonTransa...
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Hosts - finished to mark all operations as NonTransactive
......................................................................
engine: Hosts - finished to mark all operations as NonTransactive
The following patch marks last commnads by NonTransactive annotation,
no need for global transaction.
Also un needed log variable removed.
Change-Id: I2c079e69257541cbccdac90e223039826f828e63
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StartVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
4 files changed, 3 insertions(+), 15 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12675
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c079e69257541cbccdac90e223039826f828e63
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: engine: Fixing possible NPE at ApproveVdsCommand
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Fixing possible NPE at ApproveVdsCommand
......................................................................
engine: Fixing possible NPE at ApproveVdsCommand
The following patch is fixing a possible NPE at ApproveVdsCommand during canDoAction.
Also some unused variable removed
Change-Id: I3b0e0b5699003ad89858520dead4b8fe3aa3465c
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ApproveVdsCommand.java
1 file changed, 8 insertions(+), 15 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b0e0b5699003ad89858520dead4b8fe3aa3465c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: engine: Host statuses - transaction
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Host statuses - transaction
......................................................................
engine: Host statuses - transaction
The following patch will move a transaction inside SetVdsStatusCommand, and transaction
will run only on updates of db and not whole SetVdsStatusCommand.
Also marked some commands by @NonTransactiveCommandAttribute, like MaintenanceVdsCommand and
SetNonOperationalVdsCommand because of only db operation is inside of SetVdsStatusCommand
Change-Id: I710a0474798036860f130c8b2bcc2e7a557714ea
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVdsStatusVDSCommand.java
5 files changed, 22 insertions(+), 28 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12669
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I710a0474798036860f130c8b2bcc2e7a557714ea
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core: Power Management or fence errors are not...
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Power Management or fence errors are not...
......................................................................
core: Power Management or fence errors are not...
Power Management or fence errors are not logged in EVENT tab of GUI
Adding a call to AlertIfPowerManagementOperationSkipped method in
handleError method.
This will force raising an Alert each time a PM operation was supposed to
be executed and from some reason the fencing operation has been failed.
In the case of dual agents:
for concurrent - on Start , Alert will be generated if both agents
failed
on Stop , Alert will be generated if one agent failed
for sequential
on start/stop , Alert will be generated if both agents
Change-Id: If5aef618f1e1ee8ab282bad528218b15b61085bd
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5aef618f1e1ee8ab282bad528218b15b61085bd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core: RFE: Multi-Tier fencing
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: RFE: Multi-Tier fencing
......................................................................
core: RFE: Multi-Tier fencing
This patch fixes a bug in the multiple sequential PM agent treatment.
The secondary agent was used only if the primary agent was configured OK
and the fence command was sent successfully to it and it fails to perform
the command after the configured wait/retries.
This patch change this behaviour to use the secondary agent also if the
primary agent was not configured well or from some reason can not be
used although having the correct configuration (can not be accessed for
example due to networking issue)
Change-Id: I8ee542e7ddaec1bcdc777295b8222aceed798ed9
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
1 file changed, 40 insertions(+), 31 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12785
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ee542e7ddaec1bcdc777295b8222aceed798ed9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: engine: Fixed typo
by sanjal＠redhat.com
Shireesh Anjal has submitted this change and it was merged.
Change subject: engine: Fixed typo
......................................................................
engine: Fixed typo
- Fixed typo Exteral to External
Change-Id: I09f6c8677c2248b98840cf7df81c60273fdcd677
Signed-off-by: Dhandapani <dgopal(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Shireesh Anjal: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I09f6c8677c2248b98840cf7df81c60273fdcd677
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core: remove duplicate event on successful hibernation
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: remove duplicate event on successful hibernation
......................................................................
core: remove duplicate event on successful hibernation
Successful hibernation (suspension) of VM resulted in three events:
1. event that indicates that the action was initiated
2. event that indicates that the action was completed
3. event that indicates that the VM is suspended
The second event was generated by the command and the third event was
generated by the monitoring. those two messages are expressing the same
thing so we don't need both of them.
Moreover, the second event is misleading because the command generates
it right after sending the request to VDSM, thus it can't say that the
action is completed at that point. so this patch removes the second
event.
Change-Id: I5445374ddf6996e696c71995fe3bd2a9ddd60a85
Bug-Url: https://bugzilla.redhat.com/918306
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
3 files changed, 17 insertions(+), 7 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/12838
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5445374ddf6996e696c71995fe3bd2a9ddd60a85
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: webadmin: Vlan device is sent twice for SetupNetwork command
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Vlan device is sent twice for SetupNetwork command
......................................................................
webadmin: Vlan device is sent twice for SetupNetwork command
If vlan device with the same name as the new device already exists,
the new one should replace it (and not add both of them).
Change-Id: I0e444ea3064ea6fd6a1187e1e009e2ef6d2d54c6
Bug-Url: https://bugzilla.redhat.com/919052
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java
1 file changed, 10 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12910
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0e444ea3064ea6fd6a1187e1e009e2ef6d2d54c6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: webadmin: DirectLUN iSCSI - fix radio-buttons behavior
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: DirectLUN iSCSI - fix radio-buttons behavior
......................................................................
webadmin: DirectLUN iSCSI - fix radio-buttons behavior
Fixed radio-button single-selection behavior for iSCSI DirectLUN
(added single-selection listeners for LUNs that
are ordered by Target as well).
Change-Id: I5ecb21cc817d0383fbdc7d6bdc955e6a1c38af04
Bug-Url: https://bugzilla.redhat.com/918568
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12911
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ecb21cc817d0383fbdc7d6bdc955e6a1c38af04
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 8 months