May 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: packaging: setup: fixup pki usage of uninstall

by oschreib＠redhat.com

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: fixup pki usage of uninstall ...................................................................... packaging: setup: fixup pki usage of uninstall Change-Id: Ia04b609d5f3a3c1434698d7949c641effecf6ef1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/pki/ca.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia04b609d5f3a3c1434698d7949c641effecf6ef1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

11 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: core: remove spec field in StorageServerConnections

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: remove spec field in StorageServerConnections ...................................................................... core: remove spec field in StorageServerConnections Remove unused spec field (member) in StorageServerConnections Change-Id: If962f4d7cc6cdaaab54ecd4237628f5ec826d0e5 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java 1 file changed, 0 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If962f4d7cc6cdaaab54ecd4237628f5ec826d0e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

11 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: setup: cleaning up ISO domain directory

by oschreib＠redhat.com

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: cleaning up ISO domain directory ...................................................................... packaging: setup: cleaning up ISO domain directory Allow the admin to remove from ISO domain directory the content added by engine-setup-2 when running engine-cleanup-2. Change-Id: Ic7902968c8290c438e5aed2e63a0a63c1f446670 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/config/iso_domain.py M packaging/setup/plugins/ovirt-engine-setup/distro-rpm/image_upload.py 2 files changed, 27 insertions(+), 15 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14984 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7902968c8290c438e5aed2e63a0a63c1f446670 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

11 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: setup: allow interactive PKI cleanup

by oschreib＠redhat.com

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: allow interactive PKI cleanup ...................................................................... packaging: setup: allow interactive PKI cleanup allow interactive PKI cleanup with engine-cleanup-2 - cleanup PKI configuration and keys only if requested - backup PKI configuration and keys it cleanup requested Change-Id: Ib6efe201ed5a9dee7f681ffd61c8f988d24a33a7 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A packaging/setup/plugins/ovirt-engine-remove/config/__init__.py A packaging/setup/plugins/ovirt-engine-remove/config/ca.py M packaging/setup/plugins/ovirt-engine-setup/config/ca.py M packaging/setup/plugins/ovirt-engine-setup/pki/ca.py 4 files changed, 163 insertions(+), 15 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6efe201ed5a9dee7f681ffd61c8f988d24a33a7 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

11 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: core: handle failed import of template

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: handle failed import of template ...................................................................... core: handle failed import of template When failing during the import of a template, the engine should attempt to delete the created images and not just remove it from the db to avoid storage leak and possible CDA message/inconsistent data during another try to import the template with same image guids. If any images are failed to be removed, they would remain with ILLEGAL status - an attempt to import again with the same ID will result in CDA message. Change-Id: If90414b6c50d922b510a10e20e0774bdbec9c05b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=908327 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmTemplateCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/TestHelperImportVmTemplateCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskImagesValidatorTest.java 8 files changed, 99 insertions(+), 75 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If90414b6c50d922b510a10e20e0774bdbec9c05b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

11 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: increase ram in blank template

by lhornyak＠redhat.com

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: increase ram in blank template ...................................................................... engine: increase ram in blank template This patch increases the ram ro 1024 MB in existing installations in the blank template. Change-Id: I49d8f5c9b5dc23c35b497618c498e8c049c82b1b Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_03_0160_increase_guest_ram.sql 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49d8f5c9b5dc23c35b497618c498e8c049c82b1b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

11 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: frontend: Small changes in spice descriptor generating

by tjelinek＠redhat.com

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Small changes in spice descriptor generating ...................................................................... frontend: Small changes in spice descriptor generating 1, Adding delete-this-file option in spice descriptor to ensure deletion after reading. 2, tls-ciphers row will not be generated when the ciphersuite is null. Change-Id: I7ed05adcd3fa8c6f93ebe6e77a02710a291f6159 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=965179 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceNativeImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/14830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ed05adcd3fa8c6f93ebe6e77a02710a291f6159 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

11 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: setup: fix otopi implementation version locking h...

by oschreib＠redhat.com

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: fix otopi implementation version locking handling ...................................................................... packaging: setup: fix otopi implementation version locking handling engine-setup-2 avoid to replace version locking list file engine-cleanup-2 removes ovirt-engine lines from locking list file introducing the possibility of removing lines from modified file lists. Change-Id: Ib1b9142088cfa7def37f6d1ad3d2a4204aebe8ae Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-remove/files/simple.py M packaging/setup/plugins/ovirt-engine-setup/core/uninstall.py M packaging/setup/plugins/ovirt-engine-setup/distro-rpm/versionlock.py 4 files changed, 116 insertions(+), 6 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1b9142088cfa7def37f6d1ad3d2a4204aebe8ae Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

11 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Generify & IoC provider proxy factory

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Generify & IoC provider proxy factory ...................................................................... engine: Generify & IoC provider proxy factory To support multiple provider & provider proxy types, this factory should be generic and return the correct type. Also turned the factory into a singleton which returns an instance that can be used for DI, so that interacting classes don't have to rely on a static relationship with the factory class. Change-Id: I79d80c28921e417e9cfbb35bb621bbdb751c667a Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderProxyFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/TestProviderConnectivityCommand.java 2 files changed, 18 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79d80c28921e417e9cfbb35bb621bbdb751c667a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

11 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Fix missing sub tab panel

by vszocs＠redhat.com

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Fix missing sub tab panel ...................................................................... webadmin: Fix missing sub tab panel In order for sub tab presenters and their parent presenters to receive proper (consistent) life-cycle callbacks, we must clear sub tab panel slot in MainContentPresenter when hiding the sub tab panel from the view. If we don't do the above, MainContentPresenter's sub tab panel slot will still be occupied with obsolete sub tab presenter, which will mess up sub tab presenter life-cycle callbacks, such as onReveal not called each time when sub tab view is shown in the view. Change-Id: Ifc67def5083889deb360c9d48adf4d9e3b6786a9 Bug-Url: https://bugzilla.redhat.com/964949 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabWithDetailsPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractSubTabPanelPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/MainContentPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabEventPresenter.java 5 files changed, 18 insertions(+), 8 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14957 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc67def5083889deb360c9d48adf4d9e3b6786a9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

11 years, 6 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits May 2013