Change in ovirt-engine[master]: userportal, webadmin: add advanced mode support for VM dialog...
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal,webadmin: add advanced mode support for VM dialogs
......................................................................
userportal,webadmin: add advanced mode support for VM dialogs
A new button: Show/Hide advanced mode has been added to the
VM based widgets. There are defined fields which are considered
advanced and this fields are visible only after clicking this button.
For details please consult: http://www.ovirt.org/Features/Instance_Types#Design
To achieve this the folowing chnages have been done:
1: Added support for declarative configuration of the fields
(PopupWidgetConfigMap) and a support for changing the mode
(AbstractModeSwitchingPopupWidget).
2: Support for hooking some logic between UICommon's setIsAvailable and the
actual widget's AbstractValidatedWidgetWithLabel.setAccessible (using the
VisibilityRenderer interface). Implemented for most of widgets but not for all-
only for ones needed in this patch.
The actual logic deciding if the specific field should be visible or not
is implemented on the gwt-common layer and not on uicommonweb one for the
following reasons:
1: big part of the configured widgets are not backed by any uicommonweb models
(such as tabs or expanders) - e.g. needed to configure gui level objects, not
model level ones
2: big part of the logic showing/hiding the specific fields was already on this
layer
3: it is logically a presentation layer, not a model one
The usage:
- Any child of AbstractVmPopupWidget can owerride it's method
createWidgetConfiguration()
- It returns an instance of VmPopupWidgetConfigMap containing some basic
configuration which the user can extend or override.
- The content of this map are Widget -> VmPopupWidgetConfig
- The instance of VmPopupWidgetConfig defines if and how should be this widget
rendered
example:
@Override
protected PopupWidgetConfigMap createWidgetConfiguration() {
return super.createWidgetConfiguration().
putOne(myWidget, simpleField().visibleInAdvancedModeOnly());
}
This says, that I want to use the default configuration enriched by myWidget,
which is visible only in advanced mode.
Any change of the visibility of fields has to be done using the
AbstractModeSwitchingPopupWidget.changeApplicationLevelVisibility method,
not the Widget.setVisible.
Examples to this:
1: if the widget is visible only in advanced mode and the mode is basic,
the changeApplicationLevelVisibility will not make the widget appear, but once
the popup switched to advanced mode, the widget will be visible.
3: if the widget is visible only in advanced mode and the mode is advanced,
the changeApplicationLevelVisibility will make the widget appear, but once
the popup switched to basic mode, the widget will be hidden.
2: if the widget is visible in all modes and the
changeApplicationLevelVisibility is set to false, the widget will disappear.
Each widget, which is backed by a model and the uicommon can deciede to hide it
has to be rendered using the ModeSwitchingVisibilityRenderer which bridges the
AbstractValidatedWidgetWithLabel.setAccessible to
AbstractModeSwitchingPopupWidget.changeApplicationLevelVisibility.
Change-Id: I36d206c1a0f97f9a76c8b30b7f21a90aae8984e3
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractModelBoundWidgetPopupView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractVmPopupView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/VisibilityRenderer.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/AbstractValueBoxWithLabelEditor.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseEntityModelCheckboxEditor.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCheckBoxEditor.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelRadioButtonEditor.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelTextBoxEditor.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelTextBoxOnlyEditor.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelListBoxEditor.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/popup/AbstractVmBasedPopupPresenterWidget.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractModeSwitchingPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/PoolEditPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/PoolNewPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/template/TemplateNewPopupWidget.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/PopupWidgetConfig.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/PopupWidgetConfigMap.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmClonePopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDesktopNewPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmServerNewPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmBasedWidgetSwitchModeCommand.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/template/TemplateNewPopupPresenterWidget.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/vm/VmClonePopupPresenterWidget.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/vm/VmDesktopNewPopupPresenterWidget.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/vm/VmServerNewPopupPresenterWidget.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/template/TemplateNewPopupView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmDesktopNewPopupView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmServerNewPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/pool/PoolEditPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/pool/PoolNewPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/template/TemplateNewPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/vm/VmClonePopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/vm/VmDesktopNewPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/vm/VmServerNewPopupPresenterWidget.java
45 files changed, 862 insertions(+), 216 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I36d206c1a0f97f9a76c8b30b7f21a90aae8984e3
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 10 months
Change in ovirt-engine[master]: userportal, webadmin: type ahead list box
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal,webadmin: type ahead list box
......................................................................
userportal,webadmin: type ahead list box
A new component ListModelTypeAheadListBoxEditor has been created.
It looks like a regular combo box, but the behavior is as follows:
- when the user clicks inside or to the left triangle (combo box)
all the options are shown (like for regular combo box)
- it supports type ahead
- the display options are rendered using custom renderers and
can even contain HTML
- it is bound to the model
It is based on the code from ListModelSuggestBox. The common parts
have been moved to BaseListModelSuggestBox and generalized. The
behavior of the original ListModelSuggestBox(Editor) is unchanged.
The new widget has been used on the AbstractVmPopupWidget for:
- data center
- cluster
- quota
- template
Change-Id: I956af3c675894c850a1a104a81cec49f4bd62011
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelSuggestBox.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelSuggestBoxEditor.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.ui.xml
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBoxEditor.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/comboBoxDropDownIcon.png
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/autocomplete/SearchSuggestionDisplay.java
11 files changed, 751 insertions(+), 152 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14936
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I956af3c675894c850a1a104a81cec49f4bd62011
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 10 months
Change in ovirt-engine[master]: core: Enable Infinispan dependencies
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Enable Infinispan dependencies
......................................................................
core: Enable Infinispan dependencies
Since version 7.2 of the application server (aka EAP 6.1) the JMX and
management subsystems are dependencies of Infinispan, so we need to
enable them. This means that we also need to enable the management port,
so in order to disallow connections we just use an empty users file.
Bug-Url: https://bugzilla.redhat.com/972400
Change-Id: If7817435ecfd8ca57b8ceee31b9bc77c66f80c60
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M packaging/services/ovirt-engine.xml.in
1 file changed, 28 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15808
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If7817435ecfd8ca57b8ceee31b9bc77c66f80c60
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 10 months
Change in ovirt-host-deploy[master]: node: detect: detect own bridges
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: node: detect: detect own bridges
......................................................................
node: detect: detect own bridges
Change-Id: I37b1050bddbad769533838460753f02ad57a011f
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ChangeLog
M src/ovirt_host_deploy/constants.py
M src/plugins/ovirt-host-deploy/node/detect.py
3 files changed, 5 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15953
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37b1050bddbad769533838460753f02ad57a011f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: webadmin: introducing virtio-scsi support
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: introducing virtio-scsi support
......................................................................
webadmin: introducing virtio-scsi support
A new DiskInterface: VirtIO_SCSI
* Updated GetDiskInterfaceList in AsyncDataProvider
* Filtered for unsupported cluster versions
(using VirtIoScsiEnabled ConfigurationValue)
SGIO [1]
* Avaiable only for DirectLUN disks with VirtIO_SCSI interface
* Added a checkbox next to DiskInterface editor:
"Allow Privileged SCSI I/O"
* Restriced by MLA permissions
- Added CONFIGURE_SCSI_GENERIC_IO ActionGroup to RoleTreeView
under Disk node: "Manipulate SCSI I/O Privileges"
(Admin roles only)
[updated Enums, LocalizedEnums, AppErrors and Constants accordingly]
[1] 'sgio': SCSI Generic IO - filtered/unfiltered
(indicates whether the OS kernel will filter unprivileged
SG_IO commands for the disk).
* Feature page: http://www.ovirt.org/Features/Virtio-SCSI
Change-Id: Ia5b3926650586783388bf36fae399e76999843dd
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
17 files changed, 100 insertions(+), 22 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14908
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5b3926650586783388bf36fae399e76999843dd
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 10 months
Change in ovirt-engine[master]: restapi: introducing virtio-scsi support
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: restapi: introducing virtio-scsi support
......................................................................
restapi: introducing virtio-scsi support
* A new DiskInterface: VIRTIO_SCSI
- Updated DiskInterface and DiskMapper accordingly
* SGIO attribute [1]
- A new attribute for LunDisk with VIRTIO_SCSI interface
- Added ScsiGenericIO enum
- Updated api.xsd, rsdl_metadata.yaml and DiskMapper accordingly
* New ActionGroup: CONFIGURE_SCSI_GENERIC_IO
- Updated PermitType and PermitMapper accordingly
[1] 'sgio': SCSI Generic IO - filtered/unfiltered
(indicates whether the OS kernel will filter unprivileged
SG_IO commands for the disk).
* Feature page: http://www.ovirt.org/Features/Virtio-SCSI
Change-Id: I8fdf89d826144885bcffd8ee29798102fcaceb44
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/DiskInterface.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/ScsiGenericIO.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/DiskMapperTest.java
10 files changed, 107 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14907
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8fdf89d826144885bcffd8ee29798102fcaceb44
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 10 months
Change in ovirt-engine[master]: core: introducing virtio-scsi support
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: introducing virtio-scsi support
......................................................................
core: introducing virtio-scsi support
A new DiskInterface type: VirtIO_SCSI
* Available for both DiskImage and LunDisk
* Supported for Cluster 3.3 and above
- Added 'VirtIoScsiEnabled' ConfigValue
* OS Guest support
- Added 'VirtIoScsiUnsupportedOsList' ConfigValue
* VmInfoBuilder - adapting to VDSM API
- Interface attribute: iface='scsi'
- Controller element is sent when required
(if there's at least one disk with virtio-scsi interface)
SGIO [1]
* Avaiable for DirectLUN disks with VirtIO-SCSI interface
* Added ScsiGenericIO enum: filtered/unfiltered
* Added 'sgio' column to 'base_disks' table
- Updated relevant views:
vm_images_storage_domains_view, images_storage_domain_view
storage_for_image_view, all_disks
* Should be restricted by MLA permissions
- A new ActionGroup: CONFIGURE_SCSI_GENERIC_IO
- Granted to DataCenterAdmin and SuperUser roles
- Verified on AddDiskCommand and UpdateVmDiskCommand
* VmInfoBuilder - adapting to VDSM API
- 'sgio' attribute on disk element
[1] 'sgio': SCSI Generic IO - filtered/unfiltered
(indicates whether the OS kernel will filter unprivileged
SG_IO commands for the disk).
* Feature page: http://www.ovirt.org/Features/Virtio-SCSI
Change-Id: Ie572b8106b3fe5becec69c140546db81bc671c96
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/dbscripts/base_disks_sp.sql
M backend/manager/dbscripts/create_views.sql
A backend/manager/dbscripts/upgrade/03_03_0260_add_base_disks_sgio_column.sql
A backend/manager/dbscripts/upgrade/03_03_0270_add_permission_to_configure_sgio.sql
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BaseDisk.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskInterface.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ScsiGenericIO.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AbstractBaseDiskRowMapper.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDiskDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDiskDaoTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
30 files changed, 362 insertions(+), 36 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14906
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie572b8106b3fe5becec69c140546db81bc671c96
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 10 months
Change in ovirt-engine[master]: core: replace the word Weird with Unexpected in log
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: replace the word Weird with Unexpected in log
......................................................................
core: replace the word Weird with Unexpected in log
when xmlRpcStatus returned isn't found in VdcBllErrors enum
write 'Unexpected return value: [xmlRpcStatus]'
Change-Id: Ic06fe252f8e801973a44bb26092117f530a59cb6
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=951908
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
mooli tayer: Verified
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15950
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic06fe252f8e801973a44bb26092117f530a59cb6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
11 years, 10 months
Change in otopi[master]: doc: fix typo
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: doc: fix typo
......................................................................
doc: fix typo
Change-Id: I998344c1db5ed4d3446560656299098b7191ad20
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
Reported-By: Yedidyah Bar David <didi(a)redhat.com>
---
M README
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15913
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I998344c1db5ed4d3446560656299098b7191ad20
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
11 years, 10 months
Change in gerrit-admin[master]: Added the hook dispatcher
by dcaroest＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Added the hook dispatcher
......................................................................
Added the hook dispatcher
This script is in charge of selecting which hooks will run and managing
the execution flow
Change-Id: Iada3d1bef5357366d5f319561efac8ee85a614f0
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
A hooks/hook-dispatcher
1 file changed, 337 insertions(+), 0 deletions(-)
Approvals:
Giuseppe Vallarelli: Looks good to me, but someone else must approve
David Caro: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iada3d1bef5357366d5f319561efac8ee85a614f0
Gerrit-PatchSet: 3
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
11 years, 10 months
