Change in ovirt-engine[ovirt-engine-3.3]: restapi: add storage domain with existing conn id
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: restapi: add storage domain with existing conn id
......................................................................
restapi: add storage domain with existing conn id
Add ability to create a new storage domain for file domains with reference
to an existing storage connection that was previously created.
Also, added a backend validation that the given connection is not used by
other storage domains.
Before this patch, the storage connection was created along with
storage domain creation.
See also:
http://www.ovirt.org/Features/Manage_Storage_Connections#Add_new_file_.28...
Change-Id: Icb0495be711f80d71ad5334080228faee03d03dc
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommon.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResourceTest.java
4 files changed, 149 insertions(+), 25 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19027
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb0495be711f80d71ad5334080228faee03d03dc
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: userportal: externalize cpu information text
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal: externalize cpu information text
......................................................................
userportal: externalize cpu information text
This patch makes it possible to localize cpu information (num of
sockets, sockets per core) in basic detail view in userportal.
Change-Id: Ib22c7a665e91dbc981384e0ae742a228948d7309
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
2 files changed, 7 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib22c7a665e91dbc981384e0ae742a228948d7309
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: engine: fix UpdateVdsGroupTest assert
by rgolan@redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: engine: fix UpdateVdsGroupTest assert
......................................................................
engine: fix UpdateVdsGroupTest assert
Change-Id: I15470aa706497e428dcba8b3791c19eabe9bfc18
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDAOTest.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19266
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I15470aa706497e428dcba8b3791c19eabe9bfc18
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: gluster: Query for gluster volume rebalance status
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: gluster: Query for gluster volume rebalance status
......................................................................
gluster: Query for gluster volume rebalance status
Query for gluster volume rebalance status
Change-Id: I3704f750fafcf3546c5237a4dde67b5f85a691e4
Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRebalanceStatusQuery.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRebalanceStatusQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
3 files changed, 268 insertions(+), 0 deletions(-)
Approvals:
Shubhendu Tripathi: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18352
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3704f750fafcf3546c5237a4dde67b5f85a691e4
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine-cli[master]: cli: unclear error message when logging into cli with bad fo...
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: unclear error message when logging into cli with bad formatted url
......................................................................
cli: unclear error message when logging into cli with bad formatted url
ovirt-shell -c -d -l localhost -u admin@internal -I
throws an unclear error message.
Error happens only when connecting to engine with out
specifying the http protocol
Change-Id: Ib3665d8714258ad8e449638fbf0b86105f813e3e
Bug-Url: https://bugzilla.redhat.com/960876
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M src/cli/messages.py
M src/ovirtcli/command/connect.py
2 files changed, 38 insertions(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18621
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3665d8714258ad8e449638fbf0b86105f813e3e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[ovirt-engine-3.3]: API: editing host add and update fields - exposing all store...
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: API: editing host add and update fields - exposing all stored ssh fields
......................................................................
API: editing host add and update fields - exposing all stored ssh fields
Change-Id: I640cfca4057ffd65d37afc10bc5ac2e12f1aafd5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=999640
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19248
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I640cfca4057ffd65d37afc10bc5ac2e12f1aafd5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
11 years, 2 months
Change in ovirt-engine[ovirt-engine-3.3.0]: API: editing host add and update fields - exposing all store...
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: API: editing host add and update fields - exposing all stored ssh fields
......................................................................
API: editing host add and update fields - exposing all stored ssh fields
Change-Id: I640cfca4057ffd65d37afc10bc5ac2e12f1aafd5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=999640
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19247
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I640cfca4057ffd65d37afc10bc5ac2e12f1aafd5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3.0
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[ovirt-engine-3.3.0]: restapi : Update of power management via cli ignored(#959879)
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi : Update of power management via cli ignored(#959879)
......................................................................
restapi : Update of power management via cli ignored(#959879)
Unable update power management fields via cli, but the
same works from web admin portal
This patch fixes all fields common between agents and the
power management model
Change-Id: Ifece398fd70a5928665c6f0c96a80450a6866f59
Bug-Url: https://bugzilla.redhat.com/959879
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
1 file changed, 76 insertions(+), 24 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19263
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifece398fd70a5928665c6f0c96a80450a6866f59
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3.0
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: engine: nullify EmulatedMachine field only on cluster level ...
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: nullify EmulatedMachine field only on cluster level change
......................................................................
engine: nullify EmulatedMachine field only on cluster level change
It was reset all the time because the
getParameters().getVdsGroup().getEmulatedMachine() was
always null because the FE has no notion of the emulated
machine.
The setting to null done in this patch is not really neccesary because
it is null anyway - done only to make it explicit and to be deffensive
in case the FE starts to be aware of the emulated machine in the future.
Change-Id: I8ffb180cfcd56c50b9bc228c0043e6fd5fee1c58
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1004695
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
A packaging/dbscripts/upgrade/03_03_0870_add_detect_emulated_machine_to_cluster.sql
M packaging/dbscripts/vds_groups_sp.sql
11 files changed, 106 insertions(+), 18 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18898
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ffb180cfcd56c50b9bc228c0043e6fd5fee1c58
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: core: simplify emulated machine matching code
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: simplify emulated machine matching code
......................................................................
core: simplify emulated machine matching code
Change-Id: Id61cbd7ab74d809ba66071d9d1807f8b4f8c985c
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ListUtils.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ListUtilsTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java
3 files changed, 14 insertions(+), 8 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19042
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id61cbd7ab74d809ba66071d9d1807f8b4f8c985c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months