Change in ovirt-reports[master]: packaging: setup: Allow to reconfigure
by sradco＠redhat.com
Shirly Radco has submitted this change and it was merged.
Change subject: packaging: setup: Allow to reconfigure
......................................................................
packaging: setup: Allow to reconfigure
Requires http://gerrit.ovirt.org/35319
Change-Id: Id75dfe342536322856ee33522b96e5f17081db93
Bug-Url: https://bugzilla.redhat.com/1072360
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/reports/constants.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Shirly Radco: Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/35322
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id75dfe342536322856ee33522b96e5f17081db93
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years
Change in ovirt-engine[ovirt-engine-3.5]: aaa: exceptions should be propagated in builtin ldap provider
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: aaa: exceptions should be propagated in builtin ldap provider
......................................................................
aaa: exceptions should be propagated in builtin ldap provider
All exceptions which are caught during the privileged action execution
should be propagated and not swollowed.
In addition, NegativeArraySizeException is handled as a severe exception,
meaning there will be no attempt to try the next server if is caught
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1165721
Change-Id: Iafa1dcf67545e81a14981bb3c33e52a570684d72
Topic: AAA
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LDAPTemplateWrapper.java
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapSearchExceptionHandler.java
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/kerberos/AuthenticationResult.java
3 files changed, 7 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Yair Zaslavsky: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35346
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iafa1dcf67545e81a14981bb3c33e52a570684d72
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: core: make RemoveTemplateSnapshotCommand non-transactional
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: make RemoveTemplateSnapshotCommand non-transactional
......................................................................
core: make RemoveTemplateSnapshotCommand non-transactional
Change-Id: I71fa8364b24a1729bec3ea838b87b102040bad18
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveTemplateSnapshotCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35309
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I71fa8364b24a1729bec3ea838b87b102040bad18
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: Revert "core: Add foreign keys from async_tasks to command_e...
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: Revert "core: Add foreign keys from async_tasks to command_entities"
......................................................................
Revert "core: Add foreign keys from async_tasks to command_entities"
This reverts commit cff91e9211234966692c43a1dfc211858d72a2b7.
Change-Id: I0bedf18c44368297da6201530ea9321496bd5be6
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
A packaging/dbscripts/upgrade/03_06_0570_revert_async_tasks_fk.sql
4 files changed, 8 insertions(+), 16 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35382
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0bedf18c44368297da6201530ea9321496bd5be6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-hosted-engine-setup[master]: packaging: setup: better handling of preexisting storage domain
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: better handling of preexisting storage domain
......................................................................
packaging: setup: better handling of preexisting storage domain
Better handling of preexisting storage domain validating it
Change-Id: I622e0540ca21eea5ebddbfa4361bfb6537ca42d8
Bug-Url: https://bugzilla.redhat.com/1155637
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/storage/storage.py
1 file changed, 16 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
--
To view, visit http://gerrit.ovirt.org/35351
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I622e0540ca21eea5ebddbfa4361bfb6537ca42d8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: engine: Enhance the xml-rpc Long support to deal with Maps a...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Enhance the xml-rpc Long support to deal with Maps and Lists
......................................................................
engine: Enhance the xml-rpc Long support to deal with Maps and Lists
It is common to have a Long value in a sub-map of an xml-rpc
argument. The current implementation does not deal with this case.
The ideal solution to this would be to instruct the marshaller
to do this. Unfortunately that is not possible and we have to
work around that limitation.
Change-Id: I5a5933a68f937c4734b547c173188e88bd7b9464
Signed-off-by: Martin Sivák <msivak(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java
1 file changed, 32 insertions(+), 5 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Martin Sivák: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35355
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a5933a68f937c4734b547c173188e88bd7b9464
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[ovirt-engine-3.5]: core: Calculate disk alias on add disk prior to setting the ...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Calculate disk alias on add disk prior to setting the job message
......................................................................
core: Calculate disk alias on add disk prior to setting the job message
The disk alias to be created is calculated during the execution phase so
if the user hasn't specified one, during the job creation the alias will
not appear in the task description, the setting of the alias (whether it's
default or the one the user supplied) is now done in the job message
calculation phase
Change-Id: Idee55da516bca986993e973dffc9058187e12a34
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1143967
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
1 file changed, 9 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35368
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idee55da516bca986993e973dffc9058187e12a34
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[ovirt-engine-3.5]: aaa: Fixing build for fedora 21
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: aaa: Fixing build for fedora 21
......................................................................
aaa: Fixing build for fedora 21
Fixes InitializingBeand and DisposableBean not
begin not recognized
Topic: AAA
Signed-off-by: Yair Zaslavsky <yzaslavs(a)rehdat.com>
Change-Id: Id3e9d6366a34ff6315833180940a7275804a1519
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/builtin-extensions/pom.xml
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35341
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3e9d6366a34ff6315833180940a7275804a1519
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
10 years
Change in ovirt-engine[master]: ui: Fixing popupHostView css style
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: ui: Fixing popupHostView css style
......................................................................
ui: Fixing popupHostView css style
Change-Id: Icbd0177f9758308a39e38b5f57e8c2e3bc8ef55d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1165670
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Yaniv Bronhaim: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35323
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icbd0177f9758308a39e38b5f57e8c2e3bc8ef55d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: ui: Fix search button logic
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: ui: Fix search button logic
......................................................................
ui: Fix search button logic
Commit 60331c40535c95950274984d89177643df5686db broke the search button
logic. This patch returns the same refresh logic that was next to the
current changes.
Change-Id: Ia86fa287a050e030d28ab96eeecfb888dd1cb22b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1165669
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java
3 files changed, 37 insertions(+), 2 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35325
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia86fa287a050e030d28ab96eeecfb888dd1cb22b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years