Change in ovirt-hosted-engine-setup[master]: iscsi: detecting empty LUN list
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: iscsi: detecting empty LUN list
......................................................................
iscsi: detecting empty LUN list
Detecting and reporting an empty LUN list to provide a better user experience.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1133937
Change-Id: Iab293c172746a36779f8c2623c1c2542bf5aaca0
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/storage/iscsi.py
1 file changed, 12 insertions(+), 8 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
--
To view, visit http://gerrit.ovirt.org/35138
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab293c172746a36779f8c2623c1c2542bf5aaca0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: upgrade: allow to add host to updated cluster
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: upgrade: allow to add host to updated cluster
......................................................................
upgrade: allow to add host to updated cluster
Fix "Answer file lacks lockspace UUIDs, please use an answer file
generated from the same version you are using on this additional host"
Error while adding a host 3.5 based to a NFS cluster upgraded from 3.4.
Change-Id: Id77da1857d379910b41764133eb5c0b82c5a3054
Bug-Url: https://bugzilla.redhat.com/1163385
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
(cherry picked from commit 8e42128172acf65aedec6668faa16cde0c34319c)
---
M src/plugins/ovirt-hosted-engine-setup/sanlock/lockspace.py
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35137
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id77da1857d379910b41764133eb5c0b82c5a3054
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.2
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years
Change in ovirt-hosted-engine-setup[master]: upgrade: allow to add host to updated cluster
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: upgrade: allow to add host to updated cluster
......................................................................
upgrade: allow to add host to updated cluster
Fix "Answer file lacks lockspace UUIDs, please use an answer file
generated from the same version you are using on this additional host"
Error while adding a host 3.5 based to a NFS cluster upgraded from 3.4.
Change-Id: Id77da1857d379910b41764133eb5c0b82c5a3054
Bug-Url: https://bugzilla.redhat.com/1163385
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/sanlock/lockspace.py
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/35104
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id77da1857d379910b41764133eb5c0b82c5a3054
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: webadmin: changed the list of fields which can not be overri...
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: changed the list of fields which can not be overridden
......................................................................
webadmin: changed the list of fields which can not be overridden
There are the following types of fields in instance types:
- the ones which are taken from it but the user can override them (e.g. defaults)
- the ones which the user can not override
This patch reduces the num of fields which can not be overridden to contain
only the really most important ones. This avoids the situation that the user will
have to have instance types like: "big with soundcard", "big with smardcard and
soundcard" etc.
The list is now significantly smaller, contains only:
- memory size
- num of sockets/cores per socket
- HA
- migration model/downtime
- priority
- balloon/min allocated memory
The specific UI changes include:
- remove the chain icon from fields which are not considered to be "marked"
anymore
- remove the specific fields from
InstanceTypeAttachDetachManager.detachableModels so it will not detach the VM
from instance type if changed
Change-Id: I7fc831f0a0656f8eaa92fe3509b03c8ac1b71fb9
Bug-Url: https://bugzilla.redhat.com/1149663
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeAttachDetachManager.java
3 files changed, 14 insertions(+), 59 deletions(-)
Approvals:
Tomas Jelinek: Verified
Gilad Chaplik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34916
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7fc831f0a0656f8eaa92fe3509b03c8ac1b71fb9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: core: Remove empty Vds hostname condition
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Remove empty Vds hostname condition
......................................................................
core: Remove empty Vds hostname condition
Removes condition which test if Vds hostname is empty. But hostname
cannot be empty, as there is no way how to install or communicate with
empty hostname host.
Change-Id: I639e9aea7ddbe9c6952a05d1077bbaf06930adcc
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
1 file changed, 2 insertions(+), 8 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
Sahina Bose: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/35088
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I639e9aea7ddbe9c6952a05d1077bbaf06930adcc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[ovirt-engine-3.5]: Adding host to DB before calling provision
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: Adding host to DB before calling provision
......................................................................
Adding host to DB before calling provision
When calling provision foreman expect the engine's host-id to allow calling
the reinstallation after provisioning. Engine generates host-id while saving
host info to db, therefore this patch switches between the DB.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1158588
Change-Id: I635d87d09eec0dd052d86329d2b6b7f0a1658836
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
1 file changed, 11 insertions(+), 11 deletions(-)
Approvals:
Yaniv Bronhaim: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34998
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I635d87d09eec0dd052d86329d2b6b7f0a1658836
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: core: Remove unnecessary String.format in logging calls
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Remove unnecessary String.format in logging calls
......................................................................
core: Remove unnecessary String.format in logging calls
Use slf4j string formatting instead of String.format call in logging.
Change-Id: I1fc06b84903db89386c51a63b1589e0d0e3a8a15
Bug-Url: https://bugzilla.redhat.com/1109871
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmConfigurationBySnapshotQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreFromSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMClearTaskVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMRevertTaskVDSCommand.java
5 files changed, 6 insertions(+), 7 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35042
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1fc06b84903db89386c51a63b1589e0d0e3a8a15
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: backend: Add support for auto-convergence and XBZRLE compres...
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: backend: Add support for auto-convergence and XBZRLE compression
......................................................................
backend: Add support for auto-convergence and XBZRLE compression
Change-Id: I04a651c4a6995876742092be31ca6e3510194b31
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/exclude-filters.xml
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MigrateVDSCommandParameters.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmBaseDaoDbFacade.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/MigrateBrokerVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/03_06_0520_add_vm_auto_convergence.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/dbscripts/vds_groups_sp.sql
M packaging/dbscripts/vm_templates_sp.sql
M packaging/dbscripts/vms_sp.sql
M packaging/etc/engine-config/engine-config.properties
27 files changed, 375 insertions(+), 35 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32132
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04a651c4a6995876742092be31ca6e3510194b31
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: core: minor refactor for custom props validation
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: minor refactor for custom props validation
......................................................................
core: minor refactor for custom props validation
instead of calling one method to check the properties and then another
to check the result, now calling one method to do both.
Change-Id: I444f374d0c1bb4c495b3c2b1c26c92bc466e19c9
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/customprop/VmPropertiesUtils.java
7 files changed, 21 insertions(+), 28 deletions(-)
Approvals:
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35116
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I444f374d0c1bb4c495b3c2b1c26c92bc466e19c9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-reports[master]: nit: fix pep8 issues
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: nit: fix pep8 issues
......................................................................
nit: fix pep8 issues
Fixed errors reported by make validations.
Change-Id: I79f7c2c7dc9209fcf318c863de73dadd3c4b99fb
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py
1 file changed, 9 insertions(+), 9 deletions(-)
Approvals:
Sandro Bonazzola: Verified
Simone Tiraboschi: Looks good to me, but someone else must approve
Yedidyah Bar David: Looks good to me, but someone else must approve
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35092
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79f7c2c7dc9209fcf318c863de73dadd3c4b99fb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years