November 2014 - Engine-commits - Ovirt List Archives

Change in ovirt-hosted-engine-setup[master]: iscsi: add HE disk to the engine as direct lun

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: iscsi: add HE disk to the engine as direct lun ...................................................................... iscsi: add HE disk to the engine as direct lun Add Hosted Engine disk to the engine as direct lun in order to allow the engine to know about the LUN used by Hosted engine, so the engine can block actions like: - import the hosted-engine's storage domain - put the iSCSI domain in maintenance while the hosted-engine is installed on it - pick the lun for storage domain creation/extension Change-Id: I9c5640bde713fc4d09cf74a7037c62e833495934 Bug-Url: https://bugzilla.redhat.com/1157243 Bug-Url: https://bugzilla.redhat.com/1157239 Bug-Url: https://bugzilla.redhat.com/1157238 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/engine/Makefile.am M src/plugins/ovirt-hosted-engine-setup/engine/__init__.py A src/plugins/ovirt-hosted-engine-setup/engine/add_disk.py M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py M src/plugins/ovirt-hosted-engine-setup/storage/iscsi.py 6 files changed, 218 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, but someone else must approve Jiří Moskovčák: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c5640bde713fc4d09cf74a7037c62e833495934 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years

1
0
0 / 0

Change in ovirt-engine[master]: core: When ISO domain is attached to multiple DCs it appears...

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: When ISO domain is attached to multiple DCs it appears multiple times ...................................................................... core: When ISO domain is attached to multiple DCs it appears multiple times In the storage main tab, when an ISO domain is attached to multipe data center, it appears in the list one time for each data centers Change-Id: I0b874fc33c660af29c2e20a15898444db12f6f6b Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1150525 --- M packaging/dbscripts/create_views.sql 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b874fc33c660af29c2e20a15898444db12f6f6b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Warning message for cloning a VM with LUN.

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Warning message for cloning a VM with LUN. ...................................................................... webadmin: Warning message for cloning a VM with LUN. When cloning a VM with an attached LUN, a warning message added which informs the user that the LUN won't be cloned as well. the user should know this when cloning a VM. Change-Id: Icb2d5205baaadd17646b5076bf5f3add481f0709 Bug-Url: https://bugzilla.redhat.com/1152023 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/CloneVmWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/CloneVmWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/CloneVmModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 4 files changed, 55 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Amit Aviram: Verified -- To view, visit http://gerrit.ovirt.org/34786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb2d5205baaadd17646b5076bf5f3add481f0709 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years

1
0
0 / 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: packaging: Added release note

by sradco＠redhat.com

Shirly Radco has submitted this change and it was merged. Change subject: packaging: Added release note ...................................................................... packaging: Added release note Change-Id: If5e3cc535944ad55247fb2b8bd6333a833622c5a Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-reports.spec.in 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35066 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5e3cc535944ad55247fb2b8bd6333a833622c5a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years

1
0
0 / 0

Change in ovirt-dwh[ovirt-engine-dwh-3.5]: packaging: Added release notes

by sradco＠redhat.com

Shirly Radco has submitted this change and it was merged. Change subject: packaging: Added release notes ...................................................................... packaging: Added release notes Change-Id: I0cd50cd2bc611e4e9f2e4cfa2407e26f34f7b37c Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-dwh.spec.in 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Shirly Radco: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35050 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cd50cd2bc611e4e9f2e4cfa2407e26f34f7b37c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years

1
0
0 / 0

Change in ovirt-engine[master]: core: avoid adding ovf store when register disk fails

by laravot＠redhat.com

Liron Aravot has submitted this change and it was merged. Change subject: core: avoid adding ovf store when register disk fails ...................................................................... core: avoid adding ovf store when register disk fails Trying to add an ovf store when the disk registration failed it will result in a low level sql error: ERROR: insert or update on table "storage_domains_ovf_info" violates foreign key constraint "storage_domains_ovf_info_ovf_disk_id_fkey" Change-Id: I947a04e14305cd96afa8c455391f2084856d1fc5 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Federico Simoncelli: Verified Maor Lipchuk: Looks good to me, approved Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I947a04e14305cd96afa8c455391f2084856d1fc5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years

1
0
0 / 0

Change in ovirt-engine[master]: core: prevent possible deadlock between monitoring threads

by ahadas＠redhat.com

Arik Hadas has submitted this change and it was merged. Change subject: core: prevent possible deadlock between monitoring threads ...................................................................... core: prevent possible deadlock between monitoring threads If VM went down during migration in the source host, the monitoring (VURTI) thread of the source host tries to destroy the VM in the destination host. In order to destroy the VM in the destination host, it tries to lock the destination host. When we have two monitoring threads that try to do it, we end-up in a deadlock because each of them locks the host it monitors and tries to lock the other one. This patch solves this problem by postponing the destroy operation on the destination host to take place after the lock on the monitored host is released. It is safe to do it that way because the status of the VM in the destination host must be either Down or MigratingTo. If the status is MigratingTo, the monitoring of the destination host just ignores the VM. If the status is Down, the monitoring of the destination host will just destroy the VM and the second destroy operation will fail. Change-Id: Ia4c52e0f8109f9599965078d2c6dd4db705cec97 Bug-Url: https://bugzilla.redhat.com/1142776 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 3 files changed, 35 insertions(+), 15 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/34995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4c52e0f8109f9599965078d2c6dd4db705cec97 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: Display a note for db credentials

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: Display a note for db credentials ...................................................................... packaging: setup: Display a note for db credentials Allow making getCredentials display a note prior to asking for credentials. Change-Id: I4053b5426b1fcb64fda2697ad4310f4044b13d98 Bug-Url: https://bugzilla.redhat.com/1159789 Bug-Url: https://bugzilla.redhat.com/1162549 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 123753c7675bd5a28dd54978ce582e01ec0a9c09) --- M packaging/setup/ovirt_engine_setup/engine_common/database.py 1 file changed, 40 insertions(+), 24 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/35044 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4053b5426b1fcb64fda2697ad4310f4044b13d98 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years

1
0
0 / 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: packaging: setup: show note about dwh db credentials

by sradco＠redhat.com

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: show note about dwh db credentials ...................................................................... packaging: setup: show note about dwh db credentials Change-Id: Iac26b56d9c03783c00010fc64beff56ea55666d9 Bug-Url: https://bugzilla.redhat.com/1162549 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 61d0faafa5d174ec5f4dc619d06f453442a4f13a) --- M packaging/setup/ovirt_engine_setup/reports/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/db/connection.py 2 files changed, 8 insertions(+), 1 deletion(-) Approvals: Shirly Radco: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35046 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac26b56d9c03783c00010fc64beff56ea55666d9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years

1
0
0 / 0

Change in ovirt-dwh[ovirt-engine-dwh-3.5]: packaging: setup: show note about engine db credentials

by sradco＠redhat.com

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: show note about engine db credentials ...................................................................... packaging: setup: show note about engine db credentials Change-Id: Ib38fcc2f24b3994866c3ec0e0c2e3dd8dbca8649 Bug-Url: https://bugzilla.redhat.com/1159789 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 85f11ae17825f93ee7a60cbeb4c76c1c9029d013) --- M packaging/setup/ovirt_engine_setup/dwh/constants.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/engine_connection.py 2 files changed, 10 insertions(+), 0 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib38fcc2f24b3994866c3ec0e0c2e3dd8dbca8649 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits November 2014