Change in ovirt-engine[ovirt-engine-3.5]: core: skip execution of stop vm if its down
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: skip execution of stop vm if its down
......................................................................
core: skip execution of stop vm if its down
if vm is down, instead of failing in canDoAction,
skip execution and notify the user in audit log.
Change-Id: I75925d528cca52603660d5a7ec6c5c871304f3d0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1168304
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ShutdownVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
5 files changed, 24 insertions(+), 0 deletions(-)
Approvals:
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35611
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I75925d528cca52603660d5a7ec6c5c871304f3d0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 12 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Allow skipping vm command execution
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Allow skipping vm command execution
......................................................................
core: Allow skipping vm command execution
This patch adds an easy way to skip vm command execution,
by overriding 'shouldSkipCommandExecution' method,
we can mark the command not to run can-do-action and execute code.
the command will just finish as succeeded and operation will be logged.
in change-id: I75925d528cca52603660d5a7ec6c5c871304f3d0
there is an example of usage for the 'stop down vm' scenario.
Change-Id: I290055f759afcc554d1f49fac12455ae18d2d194
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1168304
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
1 file changed, 26 insertions(+), 0 deletions(-)
Approvals:
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I290055f759afcc554d1f49fac12455ae18d2d194
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 12 months
Change in ovirt-engine[master]: core: added event log when mixing RHLE 6 and 7 in one cluster
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: added event log when mixing RHLE 6 and 7 in one cluster
......................................................................
core: added event log when mixing RHLE 6 and 7 in one cluster
It was already disabled to mix this two RHELs, but there was not added a
specific message in the event log. This patch adds it, an example:
"Not possible to mix RHEL 6.x and 7.x hosts in one cluster. Tried adding RHEL -
6Server - 6.5.0.1.el6 host to a cluster with RHEL - 7Server - 7.5.0.1.el7
hosts."
Change-Id: Ia8e58e10f181b6742b88b464739ed39610ac69de
Bug-Url: https://bugzilla.redhat.com/1167827
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
2 files changed, 3 insertions(+), 1 deletion(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35497
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8e58e10f181b6742b88b464739ed39610ac69de
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 12 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: [fr_FR][ja_JP][Admin Portal] Misalignment in 'New ...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: [fr_FR][ja_JP][Admin Portal] Misalignment in 'New Host' dialog
......................................................................
webadmin: [fr_FR][ja_JP][Admin Portal] Misalignment in 'New Host' dialog
Misalignment in New Host Dialog in jp_JP and
fr_FR locales
Change-Id: Id69a2a6146a1827168721071e79583d42ba9b58e
Bug-Url: https://bugzilla.redhat.com/1123324
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml
2 files changed, 23 insertions(+), 4 deletions(-)
Approvals:
Ravi Nori: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35603
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id69a2a6146a1827168721071e79583d42ba9b58e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 12 months
Change in jenkins[master]: Added extra mock cache cleanup
by dcaroest＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Added extra mock cache cleanup
......................................................................
Added extra mock cache cleanup
It's getting too heavy to keep, and we are going to setup proxies to do the
caching instead.
Change-Id: I4666d6f163be454e9131721c2bce900e7eaebe24
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M jobs/confs/shell-scripts/mock_cleanup.sh
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
David Caro: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35507
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4666d6f163be454e9131721c2bce900e7eaebe24
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 12 months
Change in ovirt-engine[master]: core: Allow skipping vm command execution
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: Allow skipping vm command execution
......................................................................
core: Allow skipping vm command execution
This patch adds an easy way to skip vm command execution,
by overriding 'shouldSkipCommandExecution' method,
we can mark the command not to run can-do-action and execute code.
the command will just finish as succeeded and operation will be logged.
in change-id: I75925d528cca52603660d5a7ec6c5c871304f3d0
there is an example of usage for the 'stop down vm' scenario.
Change-Id: I290055f759afcc554d1f49fac12455ae18d2d194
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
1 file changed, 26 insertions(+), 0 deletions(-)
Approvals:
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35602
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I290055f759afcc554d1f49fac12455ae18d2d194
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 12 months
Change in ovirt-engine[master]: core: skip execution of stop vm if its down
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: skip execution of stop vm if its down
......................................................................
core: skip execution of stop vm if its down
if vm is down, instead of failing in canDoAction,
skip execution and notify the user in audit log.
Change-Id: I75925d528cca52603660d5a7ec6c5c871304f3d0
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ShutdownVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
5 files changed, 24 insertions(+), 0 deletions(-)
Approvals:
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34936
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I75925d528cca52603660d5a7ec6c5c871304f3d0
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 12 months
Change in ovirt-hosted-engine-setup[master]: packaging: setup: better exception handling on APIs connection
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: better exception handling on APIs connection
......................................................................
packaging: setup: better exception handling on APIs connection
Better handling of APIs connection errors better discriminating
and reporting them.
Adding some debug log lines.
Bug-Url: https://bugzilla.redhat.com/1168267
Change-Id: I13a286ffaac955b821de830a4562413ee071c860
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py
1 file changed, 31 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/35595
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I13a286ffaac955b821de830a4562413ee071c860
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 12 months
Change in mom[master]: packaging: bump version to 0.4.3
by alitke＠redhat.com
Adam Litke has submitted this change and it was merged.
Change subject: packaging: bump version to 0.4.3
......................................................................
packaging: bump version to 0.4.3
Change-Id: I1178233cfc0f0d56615f867efe04e4c58ba2ce41
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/35588
Reviewed-by: Adam Litke <alitke(a)redhat.com>
---
M configure.ac
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified
Adam Litke: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35588
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1178233cfc0f0d56615f867efe04e4c58ba2ce41
Gerrit-PatchSet: 2
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 12 months
Change in ovirt-engine[ovirt-engine-3.5]: core: prevent persistence of runtime NUMA info
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: prevent persistence of runtime NUMA info
......................................................................
core: prevent persistence of runtime NUMA info
NUMA runtime info is shown wrongfully (bug 1100202),
also causes double pinning on the same node (bug fix).
This patch removes the persistence of NUMA runtime info, till
it gets resolved.
Change-Id: Ic87e09d1afae2e577f5a03ebaccc12a32ccf7681
Bug-Url: https://bugzilla.redhat.com/1147880
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
1 file changed, 0 insertions(+), 13 deletions(-)
Approvals:
Gilad Chaplik: Verified
Roy Golan: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35581
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic87e09d1afae2e577f5a03ebaccc12a32ccf7681
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 12 months