Change in ovirt-engine[ovirt-engine-3.3]: core: task list in Webadmin - jobs disappear while still run...
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: task list in Webadmin - jobs disappear while still running
......................................................................
core: task list in Webadmin - jobs disappear while still running
Previous commit deleted jobs that had at least one step that doesn't
have an async task. Proper logic is to delete jobs that doesn't have
steps with async tasks.
Change-Id: I772ec5a6255351cd3145295c783385bf0a0c4de0
Bug-Url: https://bugzilla.redhat.com/1079287
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M packaging/dbscripts/job_sp.sql
1 file changed, 8 insertions(+), 8 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Liran Zelkha: Verified
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/26056
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I772ec5a6255351cd3145295c783385bf0a0c4de0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: core : Remove manipulating instance VM action group from rol...
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core : Remove manipulating instance VM action group from role UserInstanceManager
......................................................................
core : Remove manipulating instance VM action group from role UserInstanceManager
Role UserInstanceManager has manipulating instance VM action group, but there is no such action in UserPortal.
This patch removes the action group from the role.
Change-Id: Ie01408cc4c2f9d7de87abfb5e8500dc112dfb23c
Bug-Url: https://bugzilla.redhat.com/1072773
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_04_0710_remove_import_export_permission_from_user_instance_manager_role.sql
1 file changed, 19 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Liran Zelkha: Verified
--
To view, visit http://gerrit.ovirt.org/26059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie01408cc4c2f9d7de87abfb5e8500dc112dfb23c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: Do not enable NFS on upgrade
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: packaging: setup: Do not enable NFS on upgrade
......................................................................
packaging: setup: Do not enable NFS on upgrade
Do not allow configuring an NFS ISO domain on upgrade.
Bug-Url: https://bugzilla.redhat.com/1056777
Change-Id: I10734f3debd5e3fb122707deb0cb8b354fbe2fa6
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/26041
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I10734f3debd5e3fb122707deb0cb8b354fbe2fa6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: core: VdsNotRespondingTreatment Job is not marked as finished.
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: VdsNotRespondingTreatment Job is not marked as finished.
......................................................................
core: VdsNotRespondingTreatment Job is not marked as finished.
Once a host is not reachable and VdsNotRespondingTreatment job runs,
the job is always marked as STARTED - never FINISHED/FAILS. This
patch solves this
Change-Id: I9d3d6bc9f409bbcdd5a6b7d2201d8d6eef61ecf5
Bug-Url: https://bugzilla.redhat.com/1075500
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Liran Zelkha: Verified
--
To view, visit http://gerrit.ovirt.org/26058
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d3d6bc9f409bbcdd5a6b7d2201d8d6eef61ecf5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: restapi: Fix cloud-init host name
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Fix cloud-init host name
......................................................................
restapi: Fix cloud-init host name
When sending a request to start a VM using cloud-init the host name
should be included using the "address" element, as follows:
<cloud_init>
<host>
<address>the_host_name</address>
</host>
</cloud_init>
But this is incorrectly documented in the RSDL metadata as follows:
action.vm.initialization.cloud_init.hostname: 'xs:string'
This induces wrong documentation in the Python SDK, which in turn
induces a wrong behaviour of the CLI auto-completion. The right way to
document this in the RSDL is the following:
action.vm.initialization.cloud_init.host.address: 'xs:string'
Change-Id: I5d3159cf476f881c1fe0e6955b1be44f69f94e58
Bug-Url: https://bugzilla.redhat.com/1080033
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Pasternak: Looks good to me, approved
Juan Hernandez: Verified
--
To view, visit http://gerrit.ovirt.org/26047
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d3159cf476f881c1fe0e6955b1be44f69f94e58
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 8 months
Change in ovirt-engine[master]: core: Not Responding Treatment is broken
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Not Responding Treatment is broken
......................................................................
core: Not Responding Treatment is broken
NPE on VdsNotRespondingTreatmentCommand prevents hosts from rebooting automatically
using power-management.
Change-Id: I3871bd414509324d4178ea633ca4d7f9aae74ebf
Bug-Url: https://bugzilla.redhat.com/1079702
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Liran Zelkha: Verified
--
To view, visit http://gerrit.ovirt.org/26057
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3871bd414509324d4178ea633ca4d7f9aae74ebf
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core : Remove manipulating instance VM action group from rol...
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core : Remove manipulating instance VM action group from role UserInstanceManager
......................................................................
core : Remove manipulating instance VM action group from role UserInstanceManager
Role UserInstanceManager has manipulating instance VM action group, but there is no such action in UserPortal.
This patch removes the action group from the role.
Change-Id: Ie01408cc4c2f9d7de87abfb5e8500dc112dfb23c
Bug-Url: https://bugzilla.redhat.com/1072773
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_05_0150_remove_import_export_permission_from_user_instance_manager_role.sql
1 file changed, 19 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Omer Frenkel: Looks good to me, but someone else must approve
Liran Zelkha: Verified
--
To view, visit http://gerrit.ovirt.org/25718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie01408cc4c2f9d7de87abfb5e8500dc112dfb23c
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: core: Setting missing severity to audit log...
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Setting missing severity to audit log...
......................................................................
core: Setting missing severity to audit log...
Setting missing severity to audit log messages
This patches adding settings for audit log severities that were logged
as NORMAL messages instead of ERROR/WARNING
Change-Id: If91293ebf0eb948f1fa1d7d31d4ae1cde9eb11c8
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1047889
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Eli Mesika: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25919
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If91293ebf0eb948f1fa1d7d31d4ae1cde9eb11c8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: tools: Domain name should be case insensitive
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools: Domain name should be case insensitive
......................................................................
tools: Domain name should be case insensitive
Domain name should be case insensitive. This patch by default converts
domain entered by user to lower case so it can be easily compared and
used as a key in maps.
Change-Id: I2573933e6ded5644f3c0c4c532e2407d753b9f4f
Bug-Url: https://bugzilla.redhat.com/1078147
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsArguments.java
2 files changed, 14 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26042
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2573933e6ded5644f3c0c4c532e2407d753b9f4f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: webadmin: warn when exporting template version if base is mi...
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: webadmin: warn when exporting template version if base is missing
......................................................................
webadmin: warn when exporting template version if base is missing
added a warning to the user, if trying to export template version,
and the base template is missing on the export domain,
because on import the base template must exist, or clone is needed.
this is very similar for exporting thin vm when template is missing.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073035
Change-Id: I028f9e98a31cca391e05e2e02c535f5f1b2068cf
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
3 files changed, 136 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Omer Frenkel: Verified
--
To view, visit http://gerrit.ovirt.org/26000
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I028f9e98a31cca391e05e2e02c535f5f1b2068cf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months