Change in ovirt-engine[ovirt-engine-3.4]: core: glance import as template should fail on old DCs
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: glance import as template should fail on old DCs
......................................................................
core: glance import as template should fail on old DCs
If the DC compatibility level is less than 3.4 then the glance import should fail on canDoAction.
This patch adds this validation
Change-Id: I4b975d2f8d540af6f0a3c8e4de9296173950f9ce
Bug-Url: https://bugzilla.redhat.com/1072023
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
4 files changed, 24 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Oved Ourfali: Verified
--
To view, visit http://gerrit.ovirt.org/25476
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b975d2f8d540af6f0a3c8e4de9296173950f9ce
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Remove API version field for Neutron
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Remove API version field for Neutron
......................................................................
webadmin: Remove API version field for Neutron
Only API version 2.0 is curently supported, and since the user has a
prefilled value in the URL field suggesting him the correct server URL
to put, there is no need for him to be able to "select" the version.
In the future should any other API version be available/supported, it
should be solved in an appropriate manner (i.e. auto negotiate the
version).
Change-Id: Ic264c97b4acb82ffee298cee3f89340cda18ddc3
Bug-Url: https://bugzilla.redhat.com/987917
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
(cherry picked from commit e12d7ceee1a68d8b3e727066422aa4b21469efe2)
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.ui.xml
3 files changed, 0 insertions(+), 21 deletions(-)
Approvals:
Mike Kolesnik: Verified
Lior Vernia: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25367
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic264c97b4acb82ffee298cee3f89340cda18ddc3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: engine: Fix a possible NPE when the user removes stale polic...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: engine: Fix a possible NPE when the user removes stale policy unit
......................................................................
engine: Fix a possible NPE when the user removes stale policy unit
When the external scheduler is in use and some plugin disappears,
the plugin is still visible (in disabled form) in the Manage
Policy Units dialog. If the user tries to remove it it has to
work correctly and not raise NPE.
Change-Id: I5fa617af3363ec1d71cf8f0a25af43be4b141067
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1065914
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
1 file changed, 16 insertions(+), 4 deletions(-)
Approvals:
Martin Sivák: Verified
Gilad Chaplik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25308
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5fa617af3363ec1d71cf8f0a25af43be4b141067
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: core: fix NPE when migration caused by maintenance fails
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: fix NPE when migration caused by maintenance fails
......................................................................
core: fix NPE when migration caused by maintenance fails
On failure to migrate VM from VDS which is going to maintenance, we got
NPE in ExecutionHandler while trying to end the job.
The solution is to pass the job from the MaintenanceVds command to the
InternalMigrateVm command it invokes as well.
Change-Id: If1bde265b078997507ad7f7e4b00fbd024cc3c39
Bug-Url: https://bugzilla.redhat.com/1053884
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/25441
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1bde265b078997507ad7f7e4b00fbd024cc3c39
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Configure Roles "DataCenterAdmin" Description is n...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Configure Roles "DataCenterAdmin" Description is not fully show
......................................................................
webadmin: Configure Roles "DataCenterAdmin" Description is not fully show
In Configure Roles window the description for
DataCenterAdmin is too long and cut at the end.
The window can not be enlarged so the user can
not access the end of the description.
Change-Id: I43cd143f1c353e788602863a5a94c2406e694456
Bug-Url: https://bugzilla.redhat.com/1070723
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/ConfigurePopupView.ui.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ravi Nori: Verified
Gilad Chaplik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25439
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I43cd143f1c353e788602863a5a94c2406e694456
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: tools: Fix clearing event filters in notifier
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: tools: Fix clearing event filters in notifier
......................................................................
tools: Fix clearing event filters in notifier
Fixes clearing event filters in notifier. If you had this configuration
FILTERS=exclude:* (default) and after that you add notification to some
user in webadmin, no email was sent until notifier is restarted due to
inproper clearing of event filters.
Change-Id: If665a84b1c18af1318b74bd88d134164f0f3476c
Bug-Url: https://bugzilla.redhat.com/1071536
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/filter/FirstMatchSimpleFilter.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
mooli tayer: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/25292
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If665a84b1c18af1318b74bd88d134164f0f3476c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: tools: Match transport names with EventNotificationMethod
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: tools: Match transport names with EventNotificationMethod
......................................................................
tools: Match transport names with EventNotificationMethod
Fixes different names in Smtp/Snmp.getName() and
EventNotificationMethod values which represents transport names in db.
If those names differ (current state), no events are sent through
notifier.
Change-Id: Ie93d2d371a6f29a33e32a776e74ada5f221cbb4e
Bug-Url: https://bugzilla.redhat.com/1071536
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EventSubscriptionCommandBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/EventNotificationMethod.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EventDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserEventNotifierListModel.java
A packaging/dbscripts/upgrade/03_04_0650_fix_event_notfication_method.sql
10 files changed, 54 insertions(+), 17 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
mooli tayer: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/25205
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie93d2d371a6f29a33e32a776e74ada5f221cbb4e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Edit vNic Profile- disable pm if the profile is us...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Edit vNic Profile- disable pm if the profile is used by a vm
......................................................................
webadmin: Edit vNic Profile- disable pm if the profile is used by a vm
Port mirroring checkbox should be disabled if the VNIC profile
is used by a VM.
Bug-Url: https://bugzilla.redhat.com/1031553
Change-Id: I06b851dcfbae9cd1ba48fda20aa0d0db6c3cb6cc
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/EditVnicProfileModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
2 files changed, 39 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Verified
Lior Vernia: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/25387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I06b851dcfbae9cd1ba48fda20aa0d0db6c3cb6cc
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Manage network dialog- replace VM network checkbox...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Manage network dialog- replace VM network checkbox with icon
......................................................................
webadmin: Manage network dialog- replace VM network checkbox with icon
VM network = True => green VM icon is shown
VM network = False => no icon is show
Change-Id: Ie96e3f173b0b510f1b8f20c9e9649eb937054d1a
Bug-Url: https://bugzilla.redhat.com/1016636
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/SafeHtmlWithSafeHtmlTooltipColumn.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java
2 files changed, 44 insertions(+), 26 deletions(-)
Approvals:
Alona Kaplan: Verified
Lior Vernia: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/25386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie96e3f173b0b510f1b8f20c9e9649eb937054d1a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: label group in setup networks shouldn't have tooltip
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: label group in setup networks shouldn't have tooltip
......................................................................
webadmin: label group in setup networks shouldn't have tooltip
Mouse over label group on setup networks displays the last displayed
tooltip. Shouldn't display anything.
Change-Id: I6c46d850f5452b7318e52c6ea5494a3ab2c6a3da
Bug-Url: https://bugzilla.redhat.com/1064432
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Alona Kaplan: Verified
Lior Vernia: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/25385
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c46d850f5452b7318e52c6ea5494a3ab2c6a3da
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months