Change in ovirt-engine[master]: tools: Fixing RootDSEData bind
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools: Fixing RootDSEData bind
......................................................................
tools: Fixing RootDSEData bind
Changing the way RootDSE is obtained at manage domains
to the way it is obtained at engine -
Using SIMPLE bind with no credentials.
Change-Id: I6b5709ba7f01eb34cfb72f271f3963e0e635f2a5
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/RootDSEData.java
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27756
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b5709ba7f01eb34cfb72f271f3963e0e635f2a5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-engine[master]: core: copy disks from template instead of instance type
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: copy disks from template instead of instance type
......................................................................
core: copy disks from template instead of instance type
When the VM was created from both template and instance type, all the devices
(including the disks) were taken from the instance type.
The problem is that the disks are supposed to be taken from the template.
This patch ensures that if the VM is created from an instance type, the disks
are taken from the template.
Change-Id: Iaddc4d3da99c0a459c7339639cca15cbb597df18
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
1 file changed, 26 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaddc4d3da99c0a459c7339639cca15cbb597df18
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-engine[master]: setup: Write the answer file if file path is valid
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: setup: Write the answer file if file path is valid
......................................................................
setup: Write the answer file if file path is valid
Added a exception handling to make sure answer file gets
written only if the file path is valid one. If the path
is invalid, instead of erroring out and marking the whole
setup as failed, it shows a warning and setup is marked as
completed successfully.
A valid use case is calling "engine-setup --generate-answer
=root/engine-answer.txt". In this case the current working
dir does not contain a directory with name root.
In the above scenario, earlier engine setup used to display an
error saying "No such file or directory: '<CurrDir>/root/
engine-answer.txt'". Also the overall engine-setup output used
to report "[ ERROR ] Execution of setup failed".
With the fix, now the output looks as below -
[WARNING] [Errno 2] No such file or directory:
'<CurrDir>/root/engine-answer.txt'
and the overall engine setup reports a success as below -
"[ INFO ] Execution of setup completed successfully"
Change-Id: I8c595449e631f0bdb9524d74bdc3d9b1a256439f
Bug-Url: https://bugzilla.redhat.com/1089067
Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-common/base/core/answerfile.py
1 file changed, 49 insertions(+), 31 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, approved
Shubhendu Tripathi: Verified
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Sahina Bose: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/27731
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c595449e631f0bdb9524d74bdc3d9b1a256439f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-engine[master]: core: Add Debian 7 to the list of operating systems
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: Add Debian 7 to the list of operating systems
......................................................................
core: Add Debian 7 to the list of operating systems
Added entry for Debian 7 in osinfo (deriving from Ubuntu)
and two icons for userportal.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073453
Change-Id: I2f41e8ea651d900b89944c791f25e7d99d2de5e8
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationResourcesWithLookup.java
A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/os/debian_7.png
A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/os/large/debian_7.png
M packaging/conf/osinfo-defaults.properties
4 files changed, 11 insertions(+), 0 deletions(-)
Approvals:
Martin Betak: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27598
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f41e8ea651d900b89944c791f25e7d99d2de5e8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Allow adding of NFS export/ISO domains to a local DC
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: Allow adding of NFS export/ISO domains to a local DC
......................................................................
webadmin: Allow adding of NFS export/ISO domains to a local DC
Change-Id: I7122566506fe4b146fa8e3035c5656303a6bd9ae
Bug-Url: https://bugzilla.redhat.com/1097837
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27746
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7122566506fe4b146fa8e3035c5656303a6bd9ae
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-engine[master]: aaa: fix constant name in initOnStartup
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: aaa: fix constant name in initOnStartup
......................................................................
aaa: fix constant name in initOnStartup
Topic: AAA
Change-Id: Iadef26d067e9b9dd29fcf845f16288815e2f0415
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27740
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iadef26d067e9b9dd29fcf845f16288815e2f0415
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-live[master]: ovirt-live: remove output messages from dialog
by didi＠redhat.com
Yedidyah Bar David has submitted this change and it was merged.
Change subject: ovirt-live: remove output messages from dialog
......................................................................
ovirt-live: remove output messages from dialog
Also other cleanups - synced centos/fedora engine-setup-yad.sh
scripts (hopefully will be merged one day)
Change-Id: Ic67adf2f03491578f70f0c226e2fa9f571a07490
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1056975
Signed-off-by: Ohad Basan <obasan(a)redhat.com>
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M centos/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/engine-setup-yad.sh
M fedora/oVirtLiveFiles/engine-setup-yad.sh
M fedora/oVirtLiveFiles/ovirt-answer
3 files changed, 30 insertions(+), 22 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Yedidyah Bar David: Verified; Looks good to me, approved
Ohad Basan: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/24617
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic67adf2f03491578f70f0c226e2fa9f571a07490
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Ohad Basan <obasan(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org>
Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 11 months
Change in ovirt-engine[master]: webadmin: Allow adding of NFS export/ISO domains to a local DC
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Allow adding of NFS export/ISO domains to a local DC
......................................................................
webadmin: Allow adding of NFS export/ISO domains to a local DC
Change-Id: I7122566506fe4b146fa8e3035c5656303a6bd9ae
Bug-Url: https://bugzilla.redhat.com/1097837
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/27739
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7122566506fe4b146fa8e3035c5656303a6bd9ae
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-log-collector[master]: packaging: allow to override sos version
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: allow to override sos version
......................................................................
packaging: allow to override sos version
Change-Id: Id5c6cd685f5bf7f7c1b49dc769e46bb6aa3adfff
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
Related-To: https://bugzilla.redhat.com/1037663
---
M configure.ac
1 file changed, 14 insertions(+), 5 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27691
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5c6cd685f5bf7f7c1b49dc769e46bb6aa3adfff
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-engine[master]: aaa: fix master
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: aaa: fix master
......................................................................
aaa: fix master
Change-Id: I325a3696939cac28fbeeafa0fa4bc536ae0376b3
Topic: AAA
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27738
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I325a3696939cac28fbeeafa0fa4bc536ae0376b3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 11 months