Change in ovirt-engine[ovirt-engine-3.5]: webadmin: In disks tab/subtab, make the default view to All
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: In disks tab/subtab, make the default view to All
......................................................................
webadmin: In disks tab/subtab, make the default view to All
In the disks maintab/subtab we have 3 view options - All, Images, LUNs, the
default was "Images" and now was changed to "All"
Bug-Url: https://bugzilla.redhat.com/878962
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Change-Id:…
[View More] I4f97a8c39053eac961a79141071ee3471825f1df
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewRadioGroup.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DiskModule.java
2 files changed, 2 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/31874
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f97a8c39053eac961a79141071ee3471825f1df
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 8 months
Change in ovirt-engine[master]: restapi: fix build break
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: restapi: fix build break
......................................................................
restapi: fix build break
Fix compilation error introduced by
ced96c948c538fe5674528e54c8a1f754446a4d0
Change-Id: Ib8470ebbc6b8afe515f51d4c9ae235d796445e4c
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/…
[View More]BackendIscsiBondStorageConnectionsResource.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Ori Liel: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit http://gerrit.ovirt.org/31889
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8470ebbc6b8afe515f51d4c9ae235d796445e4c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
[View Less]
10 years, 8 months
Change in ovirt-engine[master]: core: fixing other_dc proxy preference implementation
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: fixing other_dc proxy preference implementation
......................................................................
core: fixing other_dc proxy preference implementation
Fencing with proxy from other_dc is actually performed by a proxy in the
same dc
This patch actually issues two things
1) the selected proxy preferences where not passed by the HostModel so
always the "cluster,dc" default was treated
2) …
[View More]when searching for a proxy on other_dc, hosts from the fenced host DC
where not filtered out.
Change-Id: I0de81858dc9f9b76bd27c75cb47086c884f1d6cd
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131411
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNewVdsFenceStatusQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetNewVdsFenceStatusParameters.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
4 files changed, 19 insertions(+), 3 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Verified
Gilad Chaplik: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31870
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0de81858dc9f9b76bd27c75cb47086c884f1d6cd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 8 months
Change in ovirt-engine[master]: restapi: Add vm.disks.disk collection to RSDL schema
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Add vm.disks.disk collection to RSDL schema
......................................................................
restapi: Add vm.disks.disk collection to RSDL schema
Change-Id: I789144e1a51817bb268c0467943bba1d6a9c8889
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1132078
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/…
[View More]resources/rsdl_metadata.yaml
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31774
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I789144e1a51817bb268c0467943bba1d6a9c8889
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
[View Less]
10 years, 8 months
Change in ovirt-engine[master]: restapi: Make OsType enum consistent with OsRepository
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Make OsType enum consistent with OsRepository
......................................................................
restapi: Make OsType enum consistent with OsRepository
The restapi enum OsType contained WINDOWS_2008R2 which was not one of
the os' supported in OsRepository (only the windows_2008r2x64 is
supported).
Change-Id: I636de81217db51aaf122d0851f9102e7406e8531
Bug-Url: https://bugzilla.redhat.com/…
[View More]show_bug.cgi?id=1109546
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/OsType.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Martin Betak: Verified
Roy Golan: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/30767
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I636de81217db51aaf122d0851f9102e7406e8531
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 8 months
Change in ovirt-engine[master]: restapi: Expose effective SPICE proxy in VM.display
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Expose effective SPICE proxy in VM.display
......................................................................
restapi: Expose effective SPICE proxy in VM.display
Change-Id: I0bc84f39c8b6a2da742baae9b0874c2f36c3738d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1054948
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/pom.xml
M backend/manager/…
[View More]modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java
4 files changed, 61 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31350
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0bc84f39c8b6a2da742baae9b0874c2f36c3738d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 8 months
Change in ovirt-engine[master]: packaging: setup: also consider file groups in cleanup
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: also consider file groups in cleanup
......................................................................
packaging: setup: also consider file groups in cleanup
Change-Id: Ia25acec388c913f1d81c7cde3f43bda29a9013ae
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-remove/base/core/misc.py
1 file changed, 13 insertions(+), 2 deletions(-)
…
[View More]Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/31468
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia25acec388c913f1d81c7cde3f43bda29a9013ae
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 8 months
Change in ovirt-engine[master]: restapi: accept action in remove storage connection
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: accept action in remove storage connection
......................................................................
restapi: accept action in remove storage connection
Storage connections delete operation now takes an Action
as optional parameter. The Action object should contain
a Host element from which the connection would be unmounted.
Change-Id: I19a0047ee14962eb8a6d0ab2c4e981913d062612
Bug-Url: https://…
[View More]bugzilla.redhat.com/1117278
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageServerConnectionsResource.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionsResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionsResourceTest.java
4 files changed, 28 insertions(+), 16 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31571
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19a0047ee14962eb8a6d0ab2c4e981913d062612
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 8 months
Change in ovirt-engine[master]: webadmin: storage disks subtab - fix status column
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: storage disks subtab - fix status column
......................................................................
webadmin: storage disks subtab - fix status column
Storage > Disks:
'Status' column should be fetched using 'getStatusColumn' method.
Change-Id: Ia373c40f696ce080dbfd09252fc96a5b59b3a80c
Bug-Url: https://bugzilla.redhat.com/1133265
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M …
[View More]frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageDiskView.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/31858
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia373c40f696ce080dbfd09252fc96a5b59b3a80c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 8 months
Change in ovirt-engine[master]: webadmin: fix client sorting for size columns
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: fix client sorting for size columns
......................................................................
webadmin: fix client sorting for size columns
Currently, size columns are sorted using LexoNumericComparator,
which is fine for most cases except for '< 1 GB' value...
Hence, overridden 'makeSortable' method to compare the size
values numerically.
Screenshot: http://i.imgur.com/KfJjdq8.png
Change-…
[View More]Id: Iab8cdc171ff8f652ec0747212f6fd846cf95540e
Bug-Url: https://bugzilla.redhat.com/1133264
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractSizeColumn.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskSizeColumn.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StorageSizeColumn.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java
4 files changed, 31 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/31857
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab8cdc171ff8f652ec0747212f6fd846cf95540e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 8 months