Change in ovirt-engine[master]: core: vmID parameter not passed during jsonrpc call
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: vmID parameter not passed during jsonrpc call
......................................................................
core: vmID parameter not passed during jsonrpc call
There was missing parameter when running updateVmPolicy verb.
Bug-Url: https://bugzilla.redhat.com/1142851
Change-Id: I7dea865c9053f3960e2f5eff608d29be388e4080
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Verified
Martin Sivák: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33155
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7dea865c9053f3960e2f5eff608d29be388e4080
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: webadmin: import vm dialog - fix subtabs refresh
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: import vm dialog - fix subtabs refresh
......................................................................
webadmin: import vm dialog - fix subtabs refresh
As done in 'ImportVmModel -> initDetailModels',
VmImportDiskListModel/VmImportInterfaceListModel should also override
'setEntity' to get the VM object rather than the wrapping ImportVmData
EntityModel (same applies for TemplateImport models)
Change-Id: Iab5f6f522d007dd88e8d6a14f9ab66f37a1adae4
Bug-Url: https://bugzilla.redhat.com/1141693
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateImportDiskListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateImportInterfaceListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmImportDiskListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmImportInterfaceListModel.java
4 files changed, 24 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/33141
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab5f6f522d007dd88e8d6a14f9ab66f37a1adae4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-reports[ovirt-engine-reports-3.5]: packaging: setup: Use common code for remote engine pki
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: Use common code for remote engine pki
......................................................................
packaging: setup: Use common code for remote engine pki
Requires http://gerrit.ovirt.org/33023
Bug-Url: https://bugzilla.redhat.com/1142267
Change-Id: Ia7a549d09dc85293beba24327ea44ef1dcaf4a55
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit 8e9eba398d796a941b8108f32655d24c6e4b265d)
---
M packaging/setup/ovirt_engine_setup/reports/constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/apache.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/jboss.py
3 files changed, 92 insertions(+), 388 deletions(-)
Approvals:
Yedidyah Bar David: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33242
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7a549d09dc85293beba24327ea44ef1dcaf4a55
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-reports
Gerrit-Branch: ovirt-engine-reports-3.5
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 6 months
Change in ovirt-engine[master]: webadmin: Adding support to import GlusterFS
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: webadmin: Adding support to import GlusterFS
......................................................................
webadmin: Adding support to import GlusterFS
Adding support to import GlusterFS
Change-Id: Ic66b535004d40f28c4b703f5d5899253cd2616ac
Bug-Url: https://bugzilla.redhat.com/1136750
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
1 file changed, 13 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/33211
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic66b535004d40f28c4b703f5d5899253cd2616ac
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: webadmin: Formatting onImport method on StorageListModel
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: webadmin: Formatting onImport method on StorageListModel
......................................................................
webadmin: Formatting onImport method on StorageListModel
1. Using formatter on onImport method
2. put bracket on EOL instead in a new line.
Change-Id: I6713974c94808b414282d21fb71df67b514faa8c
Bug-Url: https://bugzilla.redhat.com/1136750
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
1 file changed, 13 insertions(+), 23 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/33241
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6713974c94808b414282d21fb71df67b514faa8c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-reports[ovirt-engine-reports-3.5]: build: post ovirt-engine-reports-3.5_rc3
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: build: post ovirt-engine-reports-3.5_rc3
......................................................................
build: post ovirt-engine-reports-3.5_rc3
Change-Id: Ib286b2cb14814ff018c4001d2710a2dc8c2cee58
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M version.mak
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33250
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib286b2cb14814ff018c4001d2710a2dc8c2cee58
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: ovirt-engine-reports-3.5
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 6 months
Change in ovirt-reports[ovirt-engine-reports-3.5]: build: ovirt-engine-reports-3.5_rc3
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: build: ovirt-engine-reports-3.5_rc3
......................................................................
build: ovirt-engine-reports-3.5_rc3
Change-Id: I1d373534c08a91f80ec83a4ecea17dd8148c57c3
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M ovirt-engine-reports.spec.in
M version.mak
2 files changed, 8 insertions(+), 2 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33249
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d373534c08a91f80ec83a4ecea17dd8148c57c3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: ovirt-engine-reports-3.5
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 6 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Improve wording of the memory optimization options
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Improve wording of the memory optimization options
......................................................................
webadmin: Improve wording of the memory optimization options
Our memory optimization radios in Cluster / Optimization
referenced memory page sharing. Since KSM is not the only
technology we use to achieve this it was confusing our users.
The text is changed to refer to physical memory overcommit.
Change-Id: If1242b0b2314ff615a02baa98ecd58421c500b42
Bug-Url: https://bugzilla.redhat.com/1090576
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Martin Sivák: Verified
Gilad Chaplik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33236
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1242b0b2314ff615a02baa98ecd58421c500b42
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Fix scheduling failed message for hosted engine policy...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix scheduling failed message for hosted engine policy units
......................................................................
core: Fix scheduling failed message for hosted engine policy units
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1142130
Change-Id: Ie91308fb0037298496cf2733f42b7e46148c653a
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/HostedEngineHAClusterFilterPolicyUnit.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 8 insertions(+), 5 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Martin Sivák: Verified
--
To view, visit http://gerrit.ovirt.org/33235
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie91308fb0037298496cf2733f42b7e46148c653a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[ovirt-engine-3.5]: frontend: Fix typo with IO vs I/O
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: frontend: Fix typo with IO vs I/O
......................................................................
frontend: Fix typo with IO vs I/O
Change-Id: I44ea6361fa379e4523e42a1693d141e27af05cef
Bug-Url: https://bugzilla.redhat.com/1145197
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit http://gerrit.ovirt.org/33244
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I44ea6361fa379e4523e42a1693d141e27af05cef
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 6 months