Change in ovirt-engine[ovirt-engine-3.5]: core: Add unregistered entities to the ovf tar file
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add unregistered entities to the ovf tar file
......................................................................
core: Add unregistered entities to the ovf tar file
Sync the unregistered entities with the existing entities in the setup
to be stored in the OVF_STORE disk.
Change-Id: Icc5fc1c1b704ecbb49fe3d4c2561ec1836093369
Bug-Url: https://bugzilla.redhat.com/1138114
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStorageDomainCommand.java
1 file changed, 26 insertions(+), 2 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/33101
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc5fc1c1b704ecbb49fe3d4c2561ec1836093369
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Override unregistered entity on deatch.
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Override unregistered entity on deatch.
......................................................................
core: Override unregistered entity on deatch.
Override unregistered entity when there is an existing entity which
already exists as an unregistered entity.
This can happen when a domain with an unregistered entity, is attached and
a VM with disks on multiple storage domains exists in the setup and also
as an unregistered VM.
Once the VM will be created with disk on the attached Storage Domain,
the unregistered entity should be overriden with the existing one, on
detach process.
Bug-Url: https://bugzilla.redhat.com/1132568
Change-Id: Id22390ae392e95bbc73a5976fc886ed21da4989b
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/33100
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id22390ae392e95bbc73a5976fc886ed21da4989b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Verify that date is initialized in OVF_STORE disk
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Verify that date is initialized in OVF_STORE disk
......................................................................
core: Verify that date is initialized in OVF_STORE disk
Verify that the last_update date is initizlied in the OVF_STORE disk to prevent NPE.
If the last_update date is not initialized in the disk we don't count
this disk to be retrieved, unregistered entities, from, since it is not
initilized with entities.
Change-Id: I8e59086ce7242d7aaec10b57b6775ab968c9fe1c
Bug-Url: https://bugzilla.redhat.com/1130976
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java
1 file changed, 10 insertions(+), 4 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/33099
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e59086ce7242d7aaec10b57b6775ab968c9fe1c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Get all unregisterd entities for Storage Domain
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Get all unregisterd entities for Storage Domain
......................................................................
core: Get all unregisterd entities for Storage Domain
When entity type is NULL, fetch all the unregistered entities
Change-Id: I1fa749c309381a9f034dc8e6ea499740c33f8990
Bug-Url: https://bugzilla.redhat.com/1138114
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAOTest.java
M packaging/dbscripts/unregistered_OVF_data_sp.sql
3 files changed, 19 insertions(+), 2 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/33098
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1fa749c309381a9f034dc8e6ea499740c33f8990
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-reports[master]: packaging: setup: Make pki interaction easier
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: Make pki interaction easier
......................................................................
packaging: setup: Make pki interaction easier
Make pki interaction use files and ask again if needed.
Requires: http://gerrit.ovirt.org/32742
Bug-Url: https://bugzilla.redhat.com/1118328
Bug-Url: https://bugzilla.redhat.com/1118330
Change-Id: Ia5b3713330d6e11bd7c374e04f17660be79f2251
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/reports/constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/sso.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/apache.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/jboss.py
4 files changed, 297 insertions(+), 145 deletions(-)
Approvals:
Yedidyah Bar David: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32385
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5b3713330d6e11bd7c374e04f17660be79f2251
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: dal: Unregistered entities fixups in DAO and fixtures
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: dal: Unregistered entities fixups in DAO and fixtures
......................................................................
dal: Unregistered entities fixups in DAO and fixtures
1. Add unregistered Template entity to fixtures file
2. Use FixturesTool with the new entities
3. Fix UnregisteredOVFDataDAOTest accordingly
4. Fix typos found in the UnregisteredOVFDataDAOTest
Change-Id: I3b8663eec50968c0553c8fc6e841b3244ffd418b
Bug-Url: https://bugzilla.redhat.com/1138114
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
3 files changed, 31 insertions(+), 10 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/33097
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b8663eec50968c0553c8fc6e841b3244ffd418b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Register all the OVF disks to Storage
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Register all the OVF disks to Storage
......................................................................
core: Register all the OVF disks to Storage
Manage all the OVF_STORE disks with one list,
so all those disks will be registered as floating shareable disks in the Storage
and will also be used for getting the most updateable OVF_STORE disk to
be retrieved entities from.
Change-Id: I9fc6666a64efa16968935cfceb10e19b8a4e2eef
Bug-Url: https://bugzilla.redhat.com/1138114
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java
2 files changed, 89 insertions(+), 42 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/33096
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9fc6666a64efa16968935cfceb10e19b8a4e2eef
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Adding command context support for Register Disk
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Adding command context support for Register Disk
......................................................................
core: Adding command context support for Register Disk
Adding command context constructor for Register Disk.
Change-Id: Ic3303599c7e0b8d27bef6e63ca5c5615a292131f
Bug-Url: https://bugzilla.redhat.com/1138114
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/33095
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3303599c7e0b8d27bef6e63ca5c5615a292131f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: fix typo in isDiscoveredHost entity
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: fix typo in isDiscoveredHost entity
......................................................................
webadmin: fix typo in isDiscoveredHost entity
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1144807
Change-Id: I3e3a6e532bc61e7cd558ade549d0e1ccaa35900c
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/HostPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java
5 files changed, 14 insertions(+), 14 deletions(-)
Approvals:
Yaniv Bronhaim: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33091
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e3a6e532bc61e7cd558ade549d0e1ccaa35900c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: ui: Report on insufficient parameters on add provider form
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: ui: Report on insufficient parameters on add provider form
......................................................................
ui: Report on insufficient parameters on add provider form
Adding report on insufficient parameters on test if authentication parameters
are missing
Change-Id: Iafcb126db61fe1ac1b4b668a78c3b09b95fefe90
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1125961
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
2 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
Yaniv Bronhaim: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32169
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iafcb126db61fe1ac1b4b668a78c3b09b95fefe90
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months