Change in ovirt-engine[ovirt-engine-3.5]: core: Use version 3.0 instead of 2.2 in GetCommandsCompatibi...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Use version 3.0 instead of 2.2 in GetCommandsCompatibilityVersionsQueryTest
......................................................................
core: Use version 3.0 instead of 2.2 in GetCommandsCompatibilityVersionsQueryTest
Uses version 3.0 instead of 2.2 for testing minimal compatibility
version in GetCommandsCompatibilityVersionsQueryTest.
Change-Id: I8b0236bf3ca6360d3fa483df9f23e5a1fe37457d
Bug-Url: https://bugzilla.redhat.com/1127590
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetCommandsCompatibilityVersionsQueryTest.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Martin Peřina: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32428
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b0236bf3ca6360d3fa483df9f23e5a1fe37457d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: core: StoragePoolValidatorTest config mocking
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: StoragePoolValidatorTest config mocking
......................................................................
core: StoragePoolValidatorTest config mocking
Removed redundant mocking that's not used in the test and streamlined
the existing mocking to use two version - 3.0 as an "old" version which
does not support new features and 3.1 and a "new" version which does.
Bug-Url: https://bugzilla.redhat.com/1127590
Change-Id: If916e1080686ec037dba6f79264307e73b1502d2
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StoragePoolValidatorTest.java
1 file changed, 12 insertions(+), 13 deletions(-)
Approvals:
Martin Peřina: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32427
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If916e1080686ec037dba6f79264307e73b1502d2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: Decrease updates to VdsDynamic
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Decrease updates to VdsDynamic
......................................................................
core: Decrease updates to VdsDynamic
VdsDynamic updates are heavy on the database. This patch minimizes
these writes by fixing some issues with VdsDynamic equals method
and improving the RowMapper of VdsDynamic to include all fields.
A future patch will move cpu_over_
commitment to VdsStatistics
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1136345
Change-Id: I30711bc02adcc6ebbcac95d609da0fbc54f49cb2
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java
2 files changed, 4 insertions(+), 5 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, but someone else must approve
Liran Zelkha: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31437
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I30711bc02adcc6ebbcac95d609da0fbc54f49cb2
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: Calculate Vds name from VdsStatic not VDS
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Calculate Vds name from VdsStatic not VDS
......................................................................
core: Calculate Vds name from VdsStatic not VDS
Change getVdsName to use VdsStatic which loads faster
than Vds which loads slower
Change-Id: I5b5f5445c4a7b986bfb983051a850b3794d25bfe
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
2 files changed, 36 insertions(+), 7 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, but someone else must approve
Liran Zelkha: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31463
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b5f5445c4a7b986bfb983051a850b3794d25bfe
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-reports[master]: reports: provide reports.xml to engine over http
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: provide reports.xml to engine over http
......................................................................
reports: provide reports.xml to engine over http
this is to support reports integration to webadmin on separate
servers.
Creates a single servlet ReportsServlet that takes
commands as quert string and returns the Status of the
deployment or the reports.xml file
Change-Id: Ifa975703496318f10a73845a94f86b3966ad13da
Bug-Url: https://bugzilla.redhat.com/1116851
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M build.xml
M ovirt-engine-reports.spec.in
R ovirt-engine-reports/ReportsServlet/build.xml
A ovirt-engine-reports/ReportsServlet/src/main/java/org/ovirt/servlet/ReportsServlet.java
D ovirt-engine-reports/ReportsStatus/src/main/java/org/ovirt/status/StatusServlet.java
A packaging/jasper-war-patches/ce/200_002_web-inf_add-reports-servlet.patch
D packaging/jasper-war-patches/ce/200_002_web-inf_add-reports-status-servlet.patch
M packaging/jasper-war-patches/ce/200_005_web-inf_remove_error_on_jboss_start.patch
A packaging/jasper-war-patches/pro/200_002_web-inf_add-reports-servlet.patch
D packaging/jasper-war-patches/pro/200_002_web-inf_add-reports-status-servlet.patch
M packaging/jasper-war-patches/pro/200_005_web-inf_remove_error_on_jboss_start.patch
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py
12 files changed, 96 insertions(+), 75 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30724
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa975703496318f10a73845a94f86b3966ad13da
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-engine[master]: aaa: reduce findbugs non useful warning
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: aaa: reduce findbugs non useful warning
......................................................................
aaa: reduce findbugs non useful warning
Vacuous ior operation on AuthzUtils.java:[line 47] in
org.ovirt.engine.core.aaa.AuthzUtils.fetchPrincipalRecordImpl(ExtensionProxy,
ExtKey, Object, boolean, boolean)
This is an integer bit operation (and, or, or exclusive or) that doesn't
do any useful work (e.g., v & 0xffffffff).
Topic: AAA
Change-Id: Icbcfe4e43c276ee561c526b30afdd0780f3bb5ca
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32443
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icbcfe4e43c276ee561c526b30afdd0780f3bb5ca
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-engine[master]: extapi: aaa: support group resolution control for fetch prin...
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: extapi: aaa: support group resolution control for fetch principal
......................................................................
extapi: aaa: support group resolution control for fetch principal
Topic: AAA
Change-Id: I1e7faed5d0b0fa07e5517925bea5fa62d2369145
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDirectoryUserByPrincipalQuery.java
M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authz.java
3 files changed, 16 insertions(+), 6 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32439
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e7faed5d0b0fa07e5517925bea5fa62d2369145
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-engine-cli[cli_3.5]: cli: Prepare for next release
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: cli: Prepare for next release
......................................................................
cli: Prepare for next release
In preparation for the next release this patch increases the version
number and sets the RPM release number to 0.1.
Change-Id: I676ba94ac1152169e3e8c50cdccef2b46ebd5fd5
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M Makefile
M setup.py
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I676ba94ac1152169e3e8c50cdccef2b46ebd5fd5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: cli_3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-engine-cli[cli_3.5]: cli: Release 3.5.0.4
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: cli: Release 3.5.0.4
......................................................................
cli: Release 3.5.0.4
Change-Id: I5ecf2092255a80400d43803b072741202712790f
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M Makefile
M ovirt-engine-cli.spec.in
2 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32424
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ecf2092255a80400d43803b072741202712790f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: cli_3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-engine-sdk-java[sdk_3.5]: sdk: Prepare for next development iteration
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Prepare for next development iteration
......................................................................
sdk: Prepare for next development iteration
In preparation for the next development iteration this patch increases
the version number, adds the SNAPSHOT suffix to the maven version and
sets the RPM release number to 0.1.
Change-Id: I6eac956f92c3d81f0e2ead4b7af0e6638e11f470
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M ovirt-engine-sdk-java/Makefile
M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in
M ovirt-engine-sdk-java/pom.xml
3 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32423
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6eac956f92c3d81f0e2ead4b7af0e6638e11f470
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months