Change in ovirt-engine[master]: core: Remove version 2.2 from Version and VersionStorageForm...
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Remove version 2.2 from Version and VersionStorageFormatUtil
......................................................................
core: Remove version 2.2 from Version and VersionStorageFormatUtil
Remove last usage of version 2.2 from VersionStorageFormatUtil and
Version classes.
Change-Id: Id43f292215cf35c1e2834c2a2fdac6b08a3bdb2b
Bug-Url: https://bugzilla.redhat.com/1127590
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VersionStorageFormatUtil.java
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java
2 files changed, 1 insertion(+), 3 deletions(-)
Approvals:
Martin Peřina: Verified
Allon Mureinik: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/32234
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id43f292215cf35c1e2834c2a2fdac6b08a3bdb2b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: Remove version 2.2 checks in DataCenterStorageListModel
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Remove version 2.2 checks in DataCenterStorageListModel
......................................................................
core: Remove version 2.2 checks in DataCenterStorageListModel
Removes version 2.2 checks related to storage format type in
DataCenterStorageListModel.
Change-Id: Ida6c034172e797ab4460cd954958663e4d112c12
Bug-Url: https://bugzilla.redhat.com/1127590
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java
1 file changed, 0 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Martin Peřina: Verified
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/32233
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida6c034172e797ab4460cd954958663e4d112c12
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: Use version 3.0 instead of 2.2 UpdateVmCommandTest
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Use version 3.0 instead of 2.2 UpdateVmCommandTest
......................................................................
core: Use version 3.0 instead of 2.2 UpdateVmCommandTest
Uses version 3.0 instead of 2.2 for minimal supported cluster level
version in UpdateVmCommandTest.
Change-Id: I7caebd147a47e1874e3327ce99df4a2de25c51f0
Bug-Url: https://bugzilla.redhat.com/1127590
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Peřina: Verified
Allon Mureinik: Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/32232
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7caebd147a47e1874e3327ce99df4a2de25c51f0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: Use version 3.0 instead of 2.2 in GetCommandsCompatibi...
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Use version 3.0 instead of 2.2 in GetCommandsCompatibilityVersionsQueryTest
......................................................................
core: Use version 3.0 instead of 2.2 in GetCommandsCompatibilityVersionsQueryTest
Uses version 3.0 instead of 2.2 for testing minimal compatibility
version in GetCommandsCompatibilityVersionsQueryTest.
Change-Id: I8b0236bf3ca6360d3fa483df9f23e5a1fe37457d
Bug-Url: https://bugzilla.redhat.com/1127590
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetCommandsCompatibilityVersionsQueryTest.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Martin Peřina: Verified
Allon Mureinik: Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32231
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b0236bf3ca6360d3fa483df9f23e5a1fe37457d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: core: fetch cpu profile id for vm object
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: fetch cpu profile id for vm object
......................................................................
core: fetch cpu profile id for vm object
This field is missing when getting vm from vms view.
To be submitted only in 3.5 branch (since there was
a refactoring made in vm dao mappers in u/s).
Change-Id: Ifbff849008c5e339a6c761a86c5f134e0ad20523
Bug-Url: https://bugzilla.redhat.com/1084930
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Gilad Chaplik: Looks good to me, approved
Omer Frenkel: Verified
--
To view, visit http://gerrit.ovirt.org/32370
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbff849008c5e339a6c761a86c5f134e0ad20523
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: core: use instance type values on update vm
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: use instance type values on update vm
......................................................................
core: use instance type values on update vm
When updating vm which is using instance-type,
the instance-type values cannot be override by the user.
this patch use the same code we have for add-vm that use instance-type,
to override the correct values.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1136372
Change-Id: Ib3ed838af7052f744dccd015f90032fdfc18cc55
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java
3 files changed, 70 insertions(+), 33 deletions(-)
Approvals:
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32367
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3ed838af7052f744dccd015f90032fdfc18cc55
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: Update engine's mgmt net to have the correct vlan id
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Update engine's mgmt net to have the correct vlan id
......................................................................
Update engine's mgmt net to have the correct vlan id
Up until now, when setting the management network over a vlan, the
logical network in the engine would not be automatically updated to
match the real configuration. This addresses the issue.
Change-Id: Ica4c5804395d364438f1e142387376cc7adc7172
Bug-Url: https://bugzilla.redhat.com/1124207
Signed-off-by: Antoni S. Puimedon <asegurap(a)redhat.com>
(cherry picked from commit a6bd8963d3d82af57224227e5f2af7aef6cd3492)
---
M src/ovirt_hosted_engine_setup/Makefile.am
A src/ovirt_hosted_engine_setup/vds_info.py
M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py
M src/plugins/ovirt-hosted-engine-setup/network/bridge.py
4 files changed, 109 insertions(+), 42 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32374
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica4c5804395d364438f1e142387376cc7adc7172
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.2
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: core: trailing spaces removed from dstSdUUID
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: trailing spaces removed from dstSdUUID
......................................................................
core: trailing spaces removed from dstSdUUID
Image.move fails due to trailing spaces in dstSdUUID. Removing them
fixes marshalling issue.
Bug-Url: https://bugzilla.redhat.com/1126531
Change-Id: I7d6b2b51a4f65fa23c1723e262a58deabaeaea83
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32359
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d6b2b51a4f65fa23c1723e262a58deabaeaea83
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-hosted-engine-setup[master]: Update engine's mgmt net to have the correct vlan id
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Update engine's mgmt net to have the correct vlan id
......................................................................
Update engine's mgmt net to have the correct vlan id
Up until now, when setting the management network over a vlan, the
logical network in the engine would not be automatically updated to
match the real configuration. This addresses the issue.
Change-Id: Ica4c5804395d364438f1e142387376cc7adc7172
Bug-Url: https://bugzilla.redhat.com/1124207
Signed-off-by: Antoni S. Puimedon <asegurap(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/Makefile.am
A src/ovirt_hosted_engine_setup/vds_info.py
M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py
M src/plugins/ovirt-hosted-engine-setup/network/bridge.py
4 files changed, 109 insertions(+), 42 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/32269
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica4c5804395d364438f1e142387376cc7adc7172
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: webadmin: Make reinstall dialog slightly bigger
by lvernia@redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Make reinstall dialog slightly bigger
......................................................................
webadmin: Make reinstall dialog slightly bigger
This to obviate a scroll bar that appears when selecting a provider.
Change-Id: Icdaba03bcefb5f65ca4bdecb7008b48c7a0758d1
Bug-Url: https://bugzilla.redhat.com/1117399
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.ui.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/31863
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icdaba03bcefb5f65ca4bdecb7008b48c7a0758d1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months