Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: storage: avoid connecting to the storage pool to check its name
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: storage: avoid connecting to the storage pool to check its name
......................................................................
storage: avoid connecting to the storage pool to check its name
Since 3.6.1 the hosted engine storage domain get imported
into the engine and attached to the storage pool of the
data-center that contains the hosted-engine hosts.
hosted-engine-setup on additional hosts was connecting the
bootstrap storage pool just to check its name but now it
cannot anymore since the master storage domain of the
datacenter storage pool could be a regular storage domain
on a storage server that hosted-engine-setup didn't
connected at all.
Avoid it and simply rely on the name in the answerfile gathered
from the first host.
Change-Id: I912eb3bdd69567e1902ab28f71ce16496b4e9bb3
Bug-Url: https://bugzilla.redhat.com/1293892
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/storage/storage.py
1 file changed, 0 insertions(+), 12 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50971
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I912eb3bdd69567e1902ab28f71ce16496b4e9bb3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.3
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-hosted-engine-setup[master]: storage: avoid connecting to the storage pool to check its name
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: storage: avoid connecting to the storage pool to check its name
......................................................................
storage: avoid connecting to the storage pool to check its name
Since 3.6.1 the hosted engine storage domain get imported
into the engine and attached to the storage pool of the
data-center that contains the hosted-engine hosts.
hosted-engine-setup on additional hosts was connecting the
bootstrap storage pool just to check its name but now it
cannot anymore since the master storage domain of the
datacenter storage pool could be a regular storage domain
on a storage server that hosted-engine-setup didn't
connected at all.
Avoid it and simply rely on the name in the answerfile gathered
from the first host.
Change-Id: I912eb3bdd69567e1902ab28f71ce16496b4e9bb3
Bug-Url: https://bugzilla.redhat.com/1293892
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/storage/storage.py
1 file changed, 0 insertions(+), 12 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50969
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I912eb3bdd69567e1902ab28f71ce16496b4e9bb3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6.2]: frontend: don't auto format sd when detaching from local dc
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: frontend: don't auto format sd when detaching from local dc
......................................................................
frontend: don't auto format sd when detaching from local dc
This patch adds the user the ability to choose whether or not to format
the storage domain when detaching it from a local data center. This is
done by presenting him a checkbox with the label "Format Domain, i.e.
Storage Content will be lost!", like in the "Remove Storage(s)" window.
Change-Id: I78526987f2b6df1e76423c2b74b0d0a5be26032e
Bug-Url: https://bugzilla.redhat.com/1245249
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
3 files changed, 13 insertions(+), 8 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/50985
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I78526987f2b6df1e76423c2b74b0d0a5be26032e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.2
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6.2]: webadmin: import glance image - fix size value
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: import glance image - fix size value
......................................................................
webadmin: import glance image - fix size value
Import image from Glance dialog: fix to appropriate size units.
Change-Id: Ibe5fdb079d72449cf92a47da7088676573d40e42
Bug-Url: https://bugzilla.redhat.com/1290349
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/ImportExportImagePopupView.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50975
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe5fdb079d72449cf92a47da7088676573d40e42
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.2
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6]: frontend: don't auto format sd when detaching from local dc
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: frontend: don't auto format sd when detaching from local dc
......................................................................
frontend: don't auto format sd when detaching from local dc
This patch adds the user the ability to choose whether or not to format
the storage domain when detaching it from a local data center. This is
done by presenting him a checkbox with the label "Format Domain, i.e.
Storage Content will be lost!", like in the "Remove Storage(s)" window.
Change-Id: I78526987f2b6df1e76423c2b74b0d0a5be26032e
Bug-Url: https://bugzilla.redhat.com/1245249
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
3 files changed, 13 insertions(+), 8 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/50976
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I78526987f2b6df1e76423c2b74b0d0a5be26032e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: import glance image - fix size value
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: import glance image - fix size value
......................................................................
webadmin: import glance image - fix size value
Import image from Glance dialog: fix to appropriate size units.
Change-Id: Ibe5fdb079d72449cf92a47da7088676573d40e42
Bug-Url: https://bugzilla.redhat.com/1290349
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/ImportExportImagePopupView.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Daniel Erez: Verified
--
To view, visit https://gerrit.ovirt.org/50974
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe5fdb079d72449cf92a47da7088676573d40e42
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: DiskImage.hasRawBlock()
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: DiskImage.hasRawBlock()
......................................................................
core: DiskImage.hasRawBlock()
isRawBlock() is used to check whether a DiskImage needs refreshing on
VDSM's side before an action is performed on it.
Theoretically, a DiskImage can have several copies on several domains,
and only some of them may be block domains (thus requiring a refresh).
This patch removes the assumption that the block domain would
necessarily be the first domain returned in getStorageTypes() and
instead checks all the domains to see if at least one of them is a block
domain.
Currently, this situation is only possible for templates, which don't
participate in Live Merging, so this patch is more of a future-proofing
effort than an actual bugfix.
Change-Id: Ief879683c433e52efcf4c2d2dc43db81f0475835
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeExtendCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ExtendImageSizeCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/DiskImage.java
3 files changed, 12 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Greg Padgett: Looks good to me, but someone else must approve
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50477
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief879683c433e52efcf4c2d2dc43db81f0475835
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: Move ImagesHandler#isDiskImageRawBlock
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Move ImagesHandler#isDiskImageRawBlock
......................................................................
core: Move ImagesHandler#isDiskImageRawBlock
Since this method is just a convenient accessor to the DiskImage's
methods it makes more sense to just put it there instead of having it in
ImagesHandler.
Change-Id: Ie66e7a85ed159f04fdfa04079d2669057a8cbcb4
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeExtendCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ExtendImageSizeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/DiskImage.java
4 files changed, 6 insertions(+), 8 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Greg Padgett: Looks good to me, but someone else must approve
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50476
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie66e7a85ed159f04fdfa04079d2669057a8cbcb4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: ImagesHandler#isDiskImageRawBlock performance
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ImagesHandler#isDiskImageRawBlock performance
......................................................................
core: ImagesHandler#isDiskImageRawBlock performance
Since a DiskImage object has the getStorageTypes() methods, there's no
need to re-read them from the database, and the in-memory values could
be used to improve performance.
Change-Id: Id031970a8ef5a79c185f5dd94f496384c8032a6a
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Greg Padgett: Looks good to me, but someone else must approve
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50475
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id031970a8ef5a79c185f5dd94f496384c8032a6a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: Remove VM#runOnce
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove VM#runOnce
......................................................................
core: Remove VM#runOnce
The private field VM#runOnce is never set, and is only read in the
hashCode() method. Hence, it could savely be removed.
It's worth noting that a VM actually does have a runOnce property
exposed by the isRunOnce() and setRunOnce(boolean) methods, but it's
value is stored by the VmDynamic object the VM holds.
Change-Id: Icbf21832633d0b0ff86abde7af3fae4388c8180b
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50956
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icbf21832633d0b0ff86abde7af3fae4388c8180b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months