Change in ovirt-engine[master]: core: Remove unused ResourceManager method
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused ResourceManager method
......................................................................
core: Remove unused ResourceManager method
Change-Id: Iae7cb1b867cf9e30bee7b6b443fd25d2c451cc95
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
1 file changed, 0 insertions(+), 8 deletions(-)
Approvals:
Allon Mureinik: Verified; Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50611
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae7cb1b867cf9e30bee7b6b443fd25d2c451cc95
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: Set a proper service ordering of HA and Node's persistence l...
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Set a proper service ordering of HA and Node's persistence layer
......................................................................
Set a proper service ordering of HA and Node's persistence layer
Change-Id: Id7ed352e08d2d4c10bfaf870a0a761cef1bc4f7f
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
(cherry picked from commit b169544ed2fb69d134d7e3d7da115a0beafa4de8)
---
M initscripts/ovirt-ha-agent.service.in
M initscripts/ovirt-ha-broker.service.in
2 files changed, 8 insertions(+), 0 deletions(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50799
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7ed352e08d2d4c10bfaf870a0a761cef1bc4f7f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.3
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: upgrade: Add (un)persist verbs to sudo
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: upgrade: Add (un)persist verbs to sudo
......................................................................
upgrade: Add (un)persist verbs to sudo
Previously sudo calls to persist and unpersist failed, because the sudo
configuration for the vdsm user did not allow it.
With this patch the vdsm user is allowed to run persist and unpersist.
Fixing also suders file for changing owner and goup of the same
config file with hust a command after
https://gerrit.ovirt.org/#/c/48700
Change-Id: Ic0fc4abaaf78b4b010031eca2a0d138743932989
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1280310
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
(cherry picked from commit 08c050a384ac03499172dd999e181d789a106bff)
---
M ovirt_hosted_engine_ha/lib/upgrade.py
M sudoers/sudoers.in
2 files changed, 6 insertions(+), 5 deletions(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50798
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0fc4abaaf78b4b010031eca2a0d138743932989
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.3
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
8 years, 11 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: Revert "persistence: Use pythonic persistence"
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Revert "persistence: Use pythonic persistence"
......................................................................
Revert "persistence: Use pythonic persistence"
This reverts commit ecf2f530ac47300e308eeb900a5bf01a4f2b5afc.
Reason: Use sudo again, to escape the vdsm user
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1280310
Change-Id: Ib5e819dbc9042e5a83fe6c5deadead141cb39b40
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
(cherry picked from commit 9a6b26a506a1a3d5502b1d6dd09ca2e1379a26ec)
---
M ovirt_hosted_engine_ha/lib/upgrade.py
M ovirt_hosted_engine_ha/lib/util.py
2 files changed, 27 insertions(+), 9 deletions(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50797
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5e819dbc9042e5a83fe6c5deadead141cb39b40
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.3
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
8 years, 11 months
Change in ovirt-hosted-engine-ha[master]: Set a proper service ordering of HA and Node's persistence l...
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Set a proper service ordering of HA and Node's persistence layer
......................................................................
Set a proper service ordering of HA and Node's persistence layer
Change-Id: Id7ed352e08d2d4c10bfaf870a0a761cef1bc4f7f
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M initscripts/ovirt-ha-agent.service.in
M initscripts/ovirt-ha-broker.service.in
2 files changed, 8 insertions(+), 0 deletions(-)
Approvals:
Fabian Deutsch: Looks good to me, but someone else must approve
Martin Sivák: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50796
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7ed352e08d2d4c10bfaf870a0a761cef1bc4f7f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-hosted-engine-ha[master]: upgrade: Add (un)persist verbs to sudo
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: upgrade: Add (un)persist verbs to sudo
......................................................................
upgrade: Add (un)persist verbs to sudo
Previously sudo calls to persist and unpersist failed, because the sudo
configuration for the vdsm user did not allow it.
With this patch the vdsm user is allowed to run persist and unpersist.
Fixing also suders file for changing owner and goup of the same
config file with hust a command after
https://gerrit.ovirt.org/#/c/48700
Change-Id: Ic0fc4abaaf78b4b010031eca2a0d138743932989
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1280310
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
---
M ovirt_hosted_engine_ha/lib/upgrade.py
M sudoers/sudoers.in
2 files changed, 6 insertions(+), 5 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50783
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0fc4abaaf78b4b010031eca2a0d138743932989
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-hosted-engine-ha[master]: Revert "persistence: Use pythonic persistence"
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Revert "persistence: Use pythonic persistence"
......................................................................
Revert "persistence: Use pythonic persistence"
This reverts commit ecf2f530ac47300e308eeb900a5bf01a4f2b5afc.
Reason: Use sudo again, to escape the vdsm user
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1280310
Change-Id: Ib5e819dbc9042e5a83fe6c5deadead141cb39b40
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
---
M ovirt_hosted_engine_ha/lib/upgrade.py
M ovirt_hosted_engine_ha/lib/util.py
2 files changed, 27 insertions(+), 9 deletions(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50782
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5e819dbc9042e5a83fe6c5deadead141cb39b40
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: replace Runnable creation with lambda exp
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: replace Runnable creation with lambda exp
......................................................................
core: replace Runnable creation with lambda exp
replace Runnable creation with lambda exp in bll
Change-Id: Ic490c0eb7b846853d22b18ed2ba9fb32acc28aff
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ParallelMultipleActionsRunner.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtilsTest.java
M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHClient.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
12 files changed, 121 insertions(+), 209 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Verified; Looks good to me, approved; Passed CI tests
Moti Asayag: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/50149
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic490c0eb7b846853d22b18ed2ba9fb32acc28aff
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6]: engine: Delete copied disk delete source disk
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Delete copied disk delete source disk
......................................................................
engine: Delete copied disk delete source disk
Deleting a copied disk also deletes the source disk in the case
the source disk is part of a VM snapshot.
In order to prevent this issue, the new disk should nullify
the VmSnapshotId and the ParentId and ImageTemplateId should
be Guid.Empty.
Change-Id: Icb2eccb1dec0c2326e47d44e2da79a3fdae399f6
Bug-Url: https://bugzilla.redhat.com/1292196
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/50788
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb2eccb1dec0c2326e47d44e2da79a3fdae399f6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6]: core: Fetch cinder disk with for loop when committing a snap...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fetch cinder disk with for loop when committing a snapshot.
......................................................................
core: Fetch cinder disk with for loop when committing a snapshot.
Use a for loop to get the unused Cinder disk for removal when committing
a previewed snapshot instead of using a condition for filtering the image
along with the Cinder disk logic which caused the disk to be removed from
VDSM and throw an error.
Change-Id: Ic4e2c2c9d4cec4be3272acc20a121c45e100aed6
Bug-Url: https://bugzilla.redhat.com/1256049
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
1 file changed, 15 insertions(+), 11 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/50781
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4e2c2c9d4cec4be3272acc20a121c45e100aed6
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
8 years, 11 months