Change in ovirt-engine[master]: core: handle negative flow for add cinder disk
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: handle negative flow for add cinder disk
......................................................................
core: handle negative flow for add cinder disk
Set TaskGroupSuccess to false to ensure endWithFailure is called.
Change-Id: Ieb678ba506a134650b12125098c4fb3f2a084a7f
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/…
[View More]main/java/org/ovirt/engine/core/bll/storage/AddCinderDiskCommandCallback.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39859
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb678ba506a134650b12125098c4fb3f2a084a7f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years
Change in ovirt-engine[master]: core: handle negative flow for extend cinder disk
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: handle negative flow for extend cinder disk
......................................................................
core: handle negative flow for extend cinder disk
* Added ErrorExtending key to mapCinderVolumeStatusToImageStatus
(needed for setting disk status to Illegal on extend error).
* Set disk status in 'onFailed' method
* Set TaskGroupSuccess to false to ensure endWithFailure is called.
Change-Id: …
[View More]I5457f8d81b283f208902036865d487e1130536e4
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendCinderDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendCinderDiskCommandCallback.java
3 files changed, 8 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39858
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5457f8d81b283f208902036865d487e1130536e4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years
Change in ovirt-engine[master]: webadmin: Buttons on Hosts tab are not unified
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: Buttons on Hosts tab are not unified
......................................................................
webadmin: Buttons on Hosts tab are not unified
On hosts tab enable/disable buttons instead of
hiding them
Change-Id: Ia6ff00bea3f65e8be6090b4408e57984bf67c2ad
Bug-Url: https://bugzilla.redhat.com/1209876
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/…
[View More]src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
1 file changed, 0 insertions(+), 10 deletions(-)
Approvals:
Ravi Nori: Verified
Alexander Wels: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39846
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6ff00bea3f65e8be6090b4408e57984bf67c2ad
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years
Change in ovirt-engine[master]: core: Rephrase validation message.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Rephrase validation message.
......................................................................
core: Rephrase validation message.
Rephrase validation message
Change-Id: Ide048e1071da3a9ab3fe4f59f2609c865a1d51dc
Bug-Url: https://bugzilla.redhat.com/1213745
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/…
[View More]webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40084
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ide048e1071da3a9ab3fe4f59f2609c865a1d51dc
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years
Change in ovirt-engine[master]: webadmin Add UI Error handling in rebalance start
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin Add UI Error handling in rebalance start
......................................................................
webadmin Add UI Error handling in rebalance start
This patch adds error handling to UI action rebalance
start by utilising the Frontend#runMultipleAction
that takes showErrorDialog flag.
It is just a UI fix for this bug because, gluster also
errors out under the circumstances reported by the bug.
If …
[View More]this is a gluster bug and it is actually supposed to
allow rebalance as I see in the bug description, then
the fix might need to go to GlusterTaskUtils#hasTaskCompleted
Change-Id: I3854d77ef8e50f88a0b64ab6a0e39e86123f8569
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1042808
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
anmolbabu: Verified
Kanagaraj M: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40233
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3854d77ef8e50f88a0b64ab6a0e39e86123f8569
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years
Change in ovirt-engine[master]: restapi: Move providers to implementation module
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Move providers to implementation module
......................................................................
restapi: Move providers to implementation module
Currently the implementations of the providers (JAXB, JSON and PDF) are
part of the "definition" module, but this module should contain only the
contracts of the RESTAPI, not the implementations. This patch moves
these implementations to the "jaxrs" …
[View More]module.
Change-Id: I810fbfafef5454fe0e1fadcba85fa522d42bbbfa
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/pom.xml
M backend/manager/modules/restapi/interface/definition/src/main/modules/org/ovirt/engine/api/restapi-definition/main/module.xml
D backend/manager/modules/restapi/interface/definition/src/main/resources/META-INF/services/javax.ws.rs.ext.Providers
M backend/manager/modules/restapi/jaxrs/pom.xml
R backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/json/CustomBeanFactory.java
R backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/json/CustomObjectMapper.java
R backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/json/JSONProvider.java
R backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/pdf/FOPMessageBodyWriter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java
R backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/ExpectationHelper.java
R backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/xml/JAXBProvider.java
R backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/xml/JAXBValidationEventHandler.java
M backend/manager/modules/restapi/jaxrs/src/main/modules/org/ovirt/engine/api/restapi-jaxrs/main/module.xml
R backend/manager/modules/restapi/jaxrs/src/main/resources/GlusterVolumeProfileDetailsAsPdf.xsl
A backend/manager/modules/restapi/jaxrs/src/main/resources/META-INF/services/javax.ws.rs.ext.Providers
16 files changed, 50 insertions(+), 49 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39966
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I810fbfafef5454fe0e1fadcba85fa522d42bbbfa
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years
Change in ovirt-engine[master]: restapi: Add the "async" matrix parameter implicitly
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Add the "async" matrix parameter implicitly
......................................................................
restapi: Add the "async" matrix parameter implicitly
Actions, delete and update operations support the "async" matrix
parameter, so it is better to add it implicitly to the generated RSDL
document and remove it from the metadata file.
Change-Id: I0a4c8ae8109b9f73a13f65915260ca069157df4c
Signed-…
[View More]off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlBuilder.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
2 files changed, 40 insertions(+), 251 deletions(-)
Approvals:
Ori Liel: Looks good to me, approved
Juan Hernandez: Verified
--
To view, visit https://gerrit.ovirt.org/40139
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a4c8ae8109b9f73a13f65915260ca069157df4c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years
Change in ovirt-engine[master]: restapi: Add the "Expect" header to update actions
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Add the "Expect" header to update actions
......................................................................
restapi: Add the "Expect" header to update actions
The actions used to update entities support the "Expect" header with
the "202-accepted" value, so it should be explicitly added to the
generated RSDL document.
Change-Id: I07ff97f1bbf895043ba82c5ef1dce49e9a9f8197
Signed-off-by: Juan Hernandez &…
[View More]lt;juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlBuilder.java
1 file changed, 11 insertions(+), 3 deletions(-)
Approvals:
Ori Liel: Looks good to me, approved
Juan Hernandez: Verified
--
To view, visit https://gerrit.ovirt.org/39940
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I07ff97f1bbf895043ba82c5ef1dce49e9a9f8197
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years
Change in ovirt-engine[master]: webadmin: restore progress indication in import-vm
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: restore progress indication in import-vm
......................................................................
webadmin: restore progress indication in import-vm
In the process of refactoring the import VM dialog, the progress
indication that is shown in the sync part of the import VM operation was
dropped. This patch brings it back.
Change-Id: Ie40e32c083de0ad9dfa98d9a16b809ad670d2be5
Signed-off-by: Arik …
[View More]Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40111
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie40e32c083de0ad9dfa98d9a16b809ad670d2be5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Beták <matobet(a)gmail.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years
Change in jenkins[master]: mock_install.sh: use dnf-acceptable `yum install`
by dcaroest＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: mock_install.sh: use dnf-acceptable `yum install`
......................................................................
mock_install.sh: use dnf-acceptable `yum install`
As explained in https://bugzilla.redhat.com/show_bug.cgi?id=957833#c2
`yum localinstall` was a legacy yum command, that was discontinued from
dnf. As such, mock_install fails on Fedora 22, where yum is replaced by
mock.
This patch attempt to fix these …
[View More]failures by using `yum install` instead,
which has the same functionality.
Change-Id: I23ca86764d9623015469f8dbad19812c7d60d0e1
Bug-Url: https://bugzilla.redhat.com/1186650
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M jobs/confs/shell-scripts/mock_install.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
David Caro: Verified; Looks good to me, approved; Ready for merge
--
To view, visit https://gerrit.ovirt.org/40306
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I23ca86764d9623015469f8dbad19812c7d60d0e1
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years