Change in ovirt-engine[master]: core: Use "Integer.parseInt" in "AbstractDiskVmCommand"
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Use "Integer.parseInt" in "AbstractDiskVmCommand"
......................................................................
core: Use "Integer.parseInt" in "AbstractDiskVmCommand"
This is needed in order to avoid the following findbugs error:
Boxing/unboxing to parse a primitive
A boxed primitive is created from a String, just to extract the
unboxed primitive value. It is more efficient to just call the static
parseXXX method.
Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING
Change-Id: I2828c0d7ae4130697d510a35d83333195bb8bf25
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46567
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2828c0d7ae4130697d510a35d83333195bb8bf25
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: core: Use "Integer.compare" in "InitDictinoaries"
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Use "Integer.compare" in "InitDictinoaries"
......................................................................
core: Use "Integer.compare" in "InitDictinoaries"
This is needed in order to avoid the following findbugs error:
Boxing a primitive to compare
A boxed primitive is created just to call compareTo method. It's more
efficient to use static compare method (for double and float since
Java 1.4, for other primitive types since Java 1.7) which works on
primitives directly.
Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_COMPARE
Change-Id: I8111481cf815abc0aa4da66a0cf47b8cb72b3a9b
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46565
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8111481cf815abc0aa4da66a0cf47b8cb72b3a9b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: core: Make "Version.ALL" unmodifiable
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Make "Version.ALL" unmodifiable
......................................................................
core: Make "Version.ALL" unmodifiable
This is needed in order to avoid the following findbugs warning:
Field is a mutable collection which should be package protected
A mutable collection instance is assigned to a final static field, thus
can be changed by malicious code or by accident from another package.
The field could be made package protected to avoid this vulnerability.
Alternatively you may wrap this field into
Collections.unmodifiableSet/List/Map/etc. to avoid this vulnerability.
Bug kind and pattern: MS - MS_MUTABLE_COLLECTION_PKGPROTECT
Change-Id: If185a4e600c1e893229b3d7e72bf0cbed76ff58a
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46616
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If185a4e600c1e893229b3d7e72bf0cbed76ff58a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: core: Check result of "list" in "Tar"
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Check result of "list" in "Tar"
......................................................................
core: Check result of "list" in "Tar"
This is needed in order to avoid the following findbugs warning:
Possible null pointer dereference due to return value of called method
The return value from a method is dereferenced without a null check,
and the return value of that method is one that should generally be
checked for null. This may lead to a NullPointerException when the
code is executed.
Bug kind and pattern: NP - NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE
Change-Id: I942994dc5d9d5e4470a4a8f28903807c820c071d
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/archivers/tar/Tar.java
1 file changed, 9 insertions(+), 6 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46597
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I942994dc5d9d5e4470a4a8f28903807c820c071d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: core: Remove server hooks correctly
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Remove server hooks correctly
......................................................................
core: Remove server hooks correctly
According to findbugs the "deletedServerHooks" map used in the
"GlusterHookSyncJob" class is useless, as it is populated but never
queried:
Useless object created
Our analysis shows that this object is useless. It's created and
modified, but its value never go outside of the method or produce any
side-effect. Either there is a mistake and object was intended to be
used or it can be removed.
This analysis rarely produces false-positives. Common false-positive
cases include:
- This object used to implicitly throw some obscure exception.
- This object used as a stub to generalize the code.
- This object used to hold strong references to weak/soft-referenced
objects.
Bug kind and pattern: UC - UC_USELESS_OBJECT
This patch changes the sync job so that the unused object is removed.
Change-Id: Icb7de1c5a4bf38f641960baf4b6cf3dd86b0b850
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJob.java
1 file changed, 1 insertion(+), 8 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46579
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb7de1c5a4bf38f641960baf4b6cf3dd86b0b850
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: core: Avoid potential NPE in "SSHDialog"
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Avoid potential NPE in "SSHDialog"
......................................................................
core: Avoid potential NPE in "SSHDialog"
This is needed in order to avoid the following findbugs warning:
Possible null pointer dereference in method on exception path
A reference value which is null on some exception control path is
dereferenced here. This may lead to a NullPointerException when the
code is executed. Note that because FindBugs currently does not prune
infeasible exception paths, this may be a false warning.
Also note that FindBugs considers the default case of a switch statement
to be an exception path, since the default case is often infeasible.
Bug kind and pattern: NP - NP_NULL_ON_SOME_PATH_EXCEPTION
Change-Id: I598c3c490a9b6c152ac0245b7b89842081b16b01
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHDialog.java
1 file changed, 11 insertions(+), 4 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46609
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I598c3c490a9b6c152ac0245b7b89842081b16b01
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: core: Check result of "listFiles" in "ContextSensitiveHelpMa...
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Check result of "listFiles" in "ContextSensitiveHelpMappingServlet"
......................................................................
core: Check result of "listFiles" in "ContextSensitiveHelpMappingServlet"
This is needed in order to avoid the following findbugs warning:
Possible null pointer dereference due to return value of called method
The return value from a method is dereferenced without a null check,
and the return value of that method is one that should generally be
checked for null. This may lead to a NullPointerException when the
code is executed.
Bug kind and pattern: NP - NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE
Change-Id: I6fa5bf732c459c7e1dad0f69033f199662899ebd
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/docs/src/main/java/org/ovirt/engine/docs/utils/servlet/ContextSensitiveHelpMappingServlet.java
1 file changed, 15 insertions(+), 9 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46615
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6fa5bf732c459c7e1dad0f69033f199662899ebd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: restapi: Make "AlertPanel.Type" enum fields private
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Make "AlertPanel.Type" enum fields private
......................................................................
restapi: Make "AlertPanel.Type" enum fields private
This is needed in order to avoid the following findbugs warning:
Enum field is public and mutable
A mutable public field is defined inside a public enum, thus can be
changed by malicious code or by accident from another package. Though
mutable enum fields may be used for lazy initialization, it's a bad
practice to expose them to the outer world. Consider declaring this
field final and/or package-private.
Bug kind and pattern: ME - ME_MUTABLE_ENUM_FIELD
Change-Id: Ic1d2ddf68985e020dd156900184ed8df2d1d1e15
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/panel/AlertPanel.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Passed CI tests
Greg Sheremeta: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46558
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1d2ddf68985e020dd156900184ed8df2d1d1e15
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: restapi: not possible to edit blank template using REST API
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: restapi: not possible to edit blank template using REST API
......................................................................
restapi: not possible to edit blank template using REST API
The problem was that when editing the template the cluster version needed
to be loaded. It is not possible to do it in case of Blank template since it is
not attached to the cluster and it's version is always the latest.
Change-Id: I78cd46d8949dfe9eb3d7de207cc8646b7f1060ee
Bug-Url: https://bugzilla.redhat.com/1262287
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java
15 files changed, 48 insertions(+), 225 deletions(-)
Approvals:
Tomas Jelinek: Verified
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46058
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I78cd46d8949dfe9eb3d7de207cc8646b7f1060ee
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernández
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[ovirt-engine-3.6.0]: exttool: do not modify map keySet()
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: exttool: do not modify map keySet()
......................................................................
exttool: do not modify map keySet()
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1177762
Change-Id: Idbe9f4eccc6f7ff37bc2bbdd1633a4b4556e424b
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
(cherry picked from commit ef159429829ddd76cf8517695dc46577bdaaa893)
---
M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/aaa/AAAServiceImpl.java
M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/InfoServiceImpl.java
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46710
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idbe9f4eccc6f7ff37bc2bbdd1633a4b4556e424b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.0
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months