Change in ovirt-engine[ovirt-engine-3.6]: webadmin, userportal: Fix IE image size quirk
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin,userportal: Fix IE image size quirk
......................................................................
webadmin,userportal: Fix IE image size quirk
IE automatically adds "width" and "height" attributes, with
values taken from "src" image data, when an <img> element is
created via Image constructor function. For example:
var img = new Image();
img.src = "foo.png";
// adds "width" and "height" automatically
document.body.appendChild(img);
This causes render issues for images that use "src" attribute
for initial placeholder image and CSS styling for the actual
image. For example:
<style>
.fooImage {
background: url("foo.png");
width: 400px;
height: 200px;
}
</style>
<img src="clear.cache.gif" class="fooImage">
In IE, above <img> element would have "width" and "height"
attributes, with values from "clear.cache.gif" placeholder
image, added automatically:
<img src="clear.cache.gif"
width="1" height="1" class="fooStyle">
To fix this quirk, "width" and "height" attributes of such
images are set to value "auto":
<img src="clear.cache.gif"
width="auto" height="auto" class="fooStyle">
Change-Id: Ia17eb684cb08c0cb2cd610e38974bc9992e48285
Bug-Url: https://bugzilla.redhat.com/1255428
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BrowserHacks.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/ClientAgentType.java
3 files changed, 85 insertions(+), 2 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46726
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia17eb684cb08c0cb2cd610e38974bc9992e48285
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: restapi: Use multiple "boot.devices.device" instead of multi...
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Use multiple "boot.devices.device" instead of multiple "boot"
......................................................................
restapi: Use multiple "boot.devices.device" instead of multiple "boot"
Currently the way to specify the boot sequence when starting a virtual
machine was to use multiple "boot" elements, each containing a "dev"
element. For example, to specify that the virtual machine should first
try to boot from CDROM and then from hard disk the following request was
used:
POST /vms/{vm:id}/start
<action>
<vm>
...
<boot>
<dev>cdrom</dev>
</boot>
<boot>
<dev>hd</dev>
</boot>
</vm>
</action>
The common practice in other parts of the API is to represent arrays
with a wrapper element. In that case that wrapper element could be named
"boots", but that doesn't make much sense, as what can have multiple
values here is the boot device, not the boot sequence. To fix this
inconsistence this patch replaces that with a single "boot" element that
can contain multiple devices:
POST /vms/{vm:id}/start
<action>
<vm>
...
<boot>
<devices>
<device>cdrom</device>
<device>hd</device>
</devices>
</boot>
</vm>
</action>
Change-Id: I63fbcef5cdfafc76cc95a3862ff8ac3457ee9074
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/README.md
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/BootValidator.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/OsValidator.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/InstanceTypeMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmBaseMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/TemplateMapperTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java
12 files changed, 149 insertions(+), 97 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46744
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I63fbcef5cdfafc76cc95a3862ff8ac3457ee9074
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: restapi: Removed the disk "clone" and "detach_only" elements
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Removed the disk "clone" and "detach_only" elements
......................................................................
restapi: Removed the disk "clone" and "detach_only" elements
These elements aren't really part of the representation of disks, but
parameters of the operations to add and remove virtual machines.
The "disks.clone" element was used to indicate that the disks of a new
virtual machine have to be cloned:
POST /vms
<vm>
...
<disks>
<clone>true</clone>
</disks>
<vm>
This has been now removed, and replaced by a new "clone" matrix
parameter:
POST /vms;clone=true
<vm>
...
</vm>
The "disks.detach_only" element was used to indicate that when removing
a virtual machine the disks don't have to be removed, but just detached
from the virtual machine:
DELETE /vms/{vm:id}
<action>
<vm>
<disks>
<detach_only>true</detach_only>
</disks>
</vm>
</action>
This has been now removed, and replaced by a new "detach_only" matrix
parameter:
DELETE /vms/{vm:id};detach_only=true
Change-Id: I4b3f4d00377c7dd1a102ec8aa8d87059c11d9cd0
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/README.md
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
7 files changed, 81 insertions(+), 19 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46734
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b3f4d00377c7dd1a102ec8aa8d87059c11d9cd0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: restapi: Add methods to get boolean and integer matrix param...
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Add methods to get boolean and integer matrix parameters
......................................................................
restapi: Add methods to get boolean and integer matrix parameters
This patch adds two methods to the "QueryHelper" class to simplify
access to boolean and integer matrix parameters.
Change-Id: I87976ca26036577dddd0bf34a1eaff0773a9ea56
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/QueryHelper.java
1 file changed, 66 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46729
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I87976ca26036577dddd0bf34a1eaff0773a9ea56
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: restapi: Don't assume names in completeness assertor
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Don't assume names in completeness assertor
......................................................................
restapi: Don't assume names in completeness assertor
Currently the completeness assertor assumes that access to a element of
a list in the code generated by the XJC compiler is always done calling
two methods with identical names. For example, it assumes that getting
the slaves of a bonding works like this:
Bonding bonding = ...;
Slave slave = bonding.getSlaves().getSlaves().get(0);
This kind of call isn't performed directly, but using reflection, but
anyhow the completeness assertor assumes that there will be two
consecutive calls to methods named "getSlaves" and "getSlaves".
Internally this is used when checking validations like the following:
validateParameters(bonding, "bonding.slaves.id|name");
This works fine in the current environment, but if the types are changed
it breaks. For example, assume that the code is changed so that
"Bonding.getSlaves()" returns an object of type "HostNics" instead of
"Slaves". The way to get slaves will then be like this:
Bonding bonding = ...;
Slave slave = bonding.getSlaves().getHostNics().get(0);
But the completeness assertor won't be able to do this via reflection,
because the names of the method are now different, "getSlaves" and then
"getHostNics".
To avoid this limitation this patch changes the completeness assertor so
instead of assuming the two method names it will only assume the first
and will find the second method assuming that objects that represent
lists have only one getter that returns a list object.
Change-Id: I35badb0f5365a41a1d57ce7a99f81bbe32e5a451
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/CompletenessAssertor.java
1 file changed, 44 insertions(+), 8 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46727
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I35badb0f5365a41a1d57ce7a99f81bbe32e5a451
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: restapi: Rename element "vmpool" to "vm_pool"
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Rename element "vmpool" to "vm_pool"
......................................................................
restapi: Rename element "vmpool" to "vm_pool"
Currently the names of the elements that represent pools of virtual
machines are "vmpool" and "vmpools". This patch renames them "vm_pool"
and "vm_pools" in order to have a consistent correspondence between
names of complex types ("VmPool" and "VmPools" in this case) and
elements.
Change-Id: I4988e97d4c81d4806b1cbb3da9930f80511dbe53
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/README.md
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermissionMapper.java
4 files changed, 40 insertions(+), 26 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46752
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4988e97d4c81d4806b1cbb3da9930f80511dbe53
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: restapi: Remove complex type "BaseDevices"
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Remove complex type "BaseDevices"
......................................................................
restapi: Remove complex type "BaseDevices"
This complex type doesn't add any thing and complicates the inheritance
hierarchy. This patch removes it.
Change-Id: If28141e72c6453ed7755e03801c9e46a14311efb
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DevicesResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/ReadOnlyDevicesResource.java
M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendDevicesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendReadOnlyDevicesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDeviceResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyDeviceResource.java
7 files changed, 18 insertions(+), 26 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46753
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If28141e72c6453ed7755e03801c9e46a14311efb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: restapi: Support mocking matrix parameter with value
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Support mocking matrix parameter with value
......................................................................
restapi: Support mocking matrix parameter with value
Currently the mocking infrastructure of the RESTAPI doesn't easily
support mocking a matrix parameter with a value. This patch adds that
support.
Change-Id: I88a649b3165d7d46ca4b6375d7910f4b40c8fc66
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java
1 file changed, 11 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46728
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I88a649b3165d7d46ca4b6375d7910f4b40c8fc66
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: core: GetDeviceListQueryTest javadoc
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: GetDeviceListQueryTest javadoc
......................................................................
core: GetDeviceListQueryTest javadoc
Placed Javadoc in the correct place, above the methods' annotations.
Change-Id: I9a8a4fb9c37ef72cfbe1c040ab1ace11d7c1891f
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetDeviceListQueryTest.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Allon Mureinik: Verified
Freddy Rolland: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/46437
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a8a4fb9c37ef72cfbe1c040ab1ace11d7c1891f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: core: ConnectVdsToLun -> connectVdsToLun
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: ConnectVdsToLun -> connectVdsToLun
......................................................................
core: ConnectVdsToLun -> connectVdsToLun
Rename method to adhere to Java naming conventions.
Change-Id: If132a8a0a978df5a5aa027629cf0db69a0cd5e0d
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Allon Mureinik: Verified
Freddy Rolland: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/46436
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If132a8a0a978df5a5aa027629cf0db69a0cd5e0d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months