December 2016 - Engine-commits - Ovirt List Archives

Change in ovirt-host-deploy[ovirt-host-deploy-1.6]: automation: check-patch.sh: Also build artifacts

by Code Review

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: automation: check-patch.sh: Also build artifacts ...................................................................... automation: check-patch.sh: Also build artifacts Change-Id: Iceca3664e0c495f71b53cac8322488ec43a079d4 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit f5abd31960d7ece1e28d918d4f853c468e9ddb70) --- M … [View More]

8 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: core: dropping sd_static luns fk

by Code Review

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: dropping sd_static luns fk ...................................................................... core: dropping sd_static luns fk Currently storage_domain_static has FKs to the luns table for its metadata devices (relevant for block domains). Some of the flows remove the lun before the sd, causing to FK violation. As a quick fix, the FK is removed and we'll … [View More]

8 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Update enum QCOW2_V2 value to 0.10.

by Code Review

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: core: Update enum QCOW2_V2 value to 0.10. ...................................................................... core: Update enum QCOW2_V2 value to 0.10. Update enum value from 0.1 to 0.10. Change-Id: I6fc31d757e04001bbcf949c052be35e062828526 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/… [View More]

8 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: core: add Discard After Delete to storage domain

by Code Review

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: add Discard After Delete to storage domain ...................................................................... core: add Discard After Delete to storage domain This patch introduces a new boolean property for storage domains - "Discard After Delete". When configured to true, vdsm will free the blocks of each disk or snapshot on that storage domain right before … [View More]they are removed. Note that: * This property can be configured to true only for block storage domains which are built on luns that support discard. * This patch does not add the code that actually tells vdsm to free the space, it just adds the new property to the Storage Domain entity. * Another patch will be sent to update all the relevant flows with the new flag. For more information please refer to the feature page: http://www.ovirt.org/develop/release-management/features/storage/discard-... Change-Id: I89c43103ae0ccdba002b0454007d5830649716cb Bug-Url: https://bugzilla.redhat.com/1342919 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddSANStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommon.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/UpdateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/utils/BlockStorageDiscardFunctionalityHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/UpdateStorageDomainCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/utils/BlockStorageDiscardFunctionalityHelperTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainStaticDaoImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/create_views.sql M packaging/dbscripts/inst_sp.sql M packaging/dbscripts/storages_sp.sql A packaging/dbscripts/upgrade/04_01_0620_add_discard_after_delete_column_to_storage_domain_static_table.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 28 files changed, 380 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/67847 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89c43103ae0ccdba002b0454007d5830649716cb Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> [View Less]

8 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: add Discard After Delete to storage view

by Code Review

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: add Discard After Delete to storage view ...................................................................... webadmin: add Discard After Delete to storage view This patch adds a new checkbox to the storage view, "Discard After Delete", right below the "Wipe After Delete" checkbox under the "Advanced Parameters" expander. Note that the new checkbox will be … [View More]

8 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: core: send discard to vdsm according to DAD value

by Code Review

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: send discard to vdsm according to DAD value ...................................................................... core: send discard to vdsm according to DAD value This patch adds a new parameter, "discard", to all 5 relevant VDS commands: CopyImage, DeleteImage, DestroyImage, MergeSnapshots and MoveImageGroup. Each VDS command is given with the new parameter … [View More]according to the value of "Discard After Delete" of the relevent storage domain. Note that since only 4.1 engines and vdsms are updated with the new api, in vdsm the parameter has a default value of false, and old engines will still call the old api. Therefore, old engines can work with new vdsms and so for new engines and old vdsms. Change-Id: I0d4239816927d313674553fbfa5c1744c5c54174 Bug-Url: https://bugzilla.redhat.com/1342919 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverFromExportDomain.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveTemplateSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CreateImageTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/DestroyImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RemoveImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/PostDeleteActionHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/PostDeleteActionHandlerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CopyImageVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DeleteImageGroupVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DestroyImageVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MergeSnapshotsVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MoveImageGroupVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/PostDeleteAction.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CopyImageVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DeleteImageGroupVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DestroyImageVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/MergeSnapshotsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/MoveImageGroupVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java 26 files changed, 404 insertions(+), 44 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/68084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d4239816927d313674553fbfa5c1744c5c54174 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> [View Less]

8 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: core: remove redundant validation in create-vm

by Code Review

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: remove redundant validation in create-vm ...................................................................... core: remove redundant validation in create-vm We usually do not validate things in vds commands since they are supposed to be validated in the bll commands. We have some legacy checks in CreateVm though. This patch removes one of them since we need the … [View More]

8 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Improve HE Management in Host Dialogs

by Code Review

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Improve HE Management in Host Dialogs ...................................................................... webadmin: Improve HE Management in Host Dialogs Currently, the hosted engine side tab is shown only in the New Host popup and is shown regardless of whether the engine is a hosted engine installation or not. The side tab displays three options in … [View More]radio button form: NONE, DEPLOY, and UNDEPLOY. This patch makes the following changes to improve the overall UX of this feature: 1. The hosted engine side tab is only displayed if the engine is a host engine installation. 2. The side tab is shown in the Edit Host popup in addition to the New Host popup. 3. In the New Host popup, only the NONE and DEPLOY options are displayed. 4. In the Edit Host popup the options displayed are dependent on whether the host is an HE node or not. a. If the host is an HE node, the NONE and UNDEPLOY options are displayed, unless the host is the last HE node in the system. If it is the last HE node, the element is disabled and a tooltip is added explaining that HE cannot be undeployed from the last HE node. b. If the host is not an HE node, the NONE and DEPLOY options are displayed. 5. Changes the element from a radio button group to a dropdown list. Feature page: http://www.ovirt.org/develop/release-management/features /hosted-engine-improve-management-in-host-dialogs/ Depends on: https://gerrit.ovirt.org/#/c/68120/ Change-Id: Ia5b5012a820289700c4f491229325f4ea9b11630 Bug-Url: https://bugzilla.redhat.com/1369827 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostedEngineHostModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 9 files changed, 104 insertions(+), 27 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Phillip Bailey: Verified -- To view, visit https://gerrit.ovirt.org/66773 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5b5012a820289700c4f491229325f4ea9b11630 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> [View Less]

8 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: add GetVnicProfilesByClusterIdQuery

by Code Review

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: add GetVnicProfilesByClusterIdQuery ...................................................................... engine: add GetVnicProfilesByClusterIdQuery Change-Id: I278e77ce39526a55524a372684dbbd69fa4694c5 Bug-Url: https://bugzilla.redhat.com/1277675 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/… [View More]

8 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Add VnicProfileViewDao.getAllForCluster method

by Code Review

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Add VnicProfileViewDao.getAllForCluster method ...................................................................... engine: Add VnicProfileViewDao.getAllForCluster method Change-Id: Ie80b01e26329981262982ed291c0c74ec1ea2c25 Bug-Url: https://bugzilla.redhat.com/1277675 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/… [View More]

8 years, 4 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits December 2016