Change in mom[master]: Do less ioTune VDSM requests
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Do less ioTune VDSM requests
......................................................................
Do less ioTune VDSM requests
This patch lowers the number of API calls in cases
where no ioTune is available or no change was detected.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1337228
Change-Id: I5f190eb49e77f19e391bc27535f67c5b05fded8c
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/57794
Reviewed-by: Roman Mohr <rmohr(a)redhat.com>
Continuous-Integration: Jenkins CI
---
M mom/Collectors/GuestIoTune.py
M mom/Controllers/IoTune.py
2 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved
Roman Mohr: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57794
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f190eb49e77f19e391bc27535f67c5b05fded8c
Gerrit-PatchSet: 4
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in mom[master]: Add GuestBalloonOptional collector
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Add GuestBalloonOptional collector
......................................................................
Add GuestBalloonOptional collector
This collector allows VM processing even when
the balloon device is missing.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1337834
Change-Id: Iaa5427212bc1f4c755c2b8fe18cd18662d7e2316
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/57795
Reviewed-by: Roman Mohr <rmohr(a)redhat.com>
Reviewed-by: Adam Litke <alitke(a)redhat.com>
Continuous-Integration: Jenkins CI
---
A mom/Collectors/GuestBalloonOptional.py
M mom/Collectors/Makefile.am
2 files changed, 17 insertions(+), 0 deletions(-)
Approvals:
Adam Litke: Looks good to me, but someone else must approve
Martin Sivák: Verified; Looks good to me, approved
Roman Mohr: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57795
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa5427212bc1f4c755c2b8fe18cd18662d7e2316
Gerrit-PatchSet: 2
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-release[ovirt-3.6]: gluster: explicit release 7 in URL
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: gluster: explicit release 7 in URL
......................................................................
gluster: explicit release 7 in URL
Use explicitly release 7 in order to avoid
7Server and 7Workstation to break yum.
Change-Id: I6c8d79c78bb02fdb3e2500ae43c8da237fe5bcba
(cherry picked from commit a282ad489cf228dc9e2d919c4c7cb91e891dc7a6)
---
M ovirt-el7-deps.repo.in
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57975
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c8d79c78bb02fdb3e2500ae43c8da237fe5bcba
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: AddDiskCommand - set correct DiskVmElement
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: AddDiskCommand - set correct DiskVmElement
......................................................................
core: AddDiskCommand - set correct DiskVmElement
AddDiskCommand -> buildAddCinderDiskParameters:
setting DiskVmElement correctly.
Change-Id: Id05c7ed070a27c30a6c0cf278f5e9d6683b23c1f
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Daniel Erez: Verified
--
To view, visit https://gerrit.ovirt.org/57886
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id05c7ed070a27c30a6c0cf278f5e9d6683b23c1f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: engine: Log message for provider connection failure
by mperina@redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: engine: Log message for provider connection failure
......................................................................
engine: Log message for provider connection failure
Change-Id: If1584c74228f5d36938e1d4a2a581c4691a3476d
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/57930
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1584c74228f5d36938e1d4a2a581c4691a3476d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-release[ovirt-4.0]: gluster: explicit release 7 in URL
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: gluster: explicit release 7 in URL
......................................................................
gluster: explicit release 7 in URL
Use explicitly release 7 in order to avoid
7Server and 7Workstation to break yum.
Change-Id: I6c8d79c78bb02fdb3e2500ae43c8da237fe5bcba
(cherry picked from commit a282ad489cf228dc9e2d919c4c7cb91e891dc7a6)
---
M ovirt-el7-deps.repo.in
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57966
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c8d79c78bb02fdb3e2500ae43c8da237fe5bcba
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-release[master]: gluster: explicit release 7 in URL
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: gluster: explicit release 7 in URL
......................................................................
gluster: explicit release 7 in URL
Use explicitly release 7 in order to avoid
7Server and 7Workstation to break yum.
Change-Id: I6c8d79c78bb02fdb3e2500ae43c8da237fe5bcba
---
M ovirt-el7-deps.repo.in
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/57950
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c8d79c78bb02fdb3e2500ae43c8da237fe5bcba
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: userportal, webadmin: CheckBoxCell HandlesEvent
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: userportal, webadmin: CheckBoxCell HandlesEvent
......................................................................
userportal, webadmin: CheckBoxCell HandlesEvent
- CheckBoxCells didn't mark themselves as handling events
this would cause issues on multi select grids. This patch
add the EventHandlingCell interface to the CheckBoxCell.
Change-Id: I6acffe4f9a8606da3de82086c835e7e3606da9f8
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/CheckboxCell.java
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved; Passed CI tests
Alexander Wels: Verified
--
To view, visit https://gerrit.ovirt.org/57964
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6acffe4f9a8606da3de82086c835e7e3606da9f8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: added logging of missing permissions
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: added logging of missing permissions
......................................................................
core: added logging of missing permissions
In CommandBase we log if the permission check fails, but in AddVmCommand this
method has been overridden completely not logging failed attempts.
Fixed by logging it also in AddVmCommand.
Change-Id: I1ad67c22f12762674a6b817339f5f167422475ea
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
2 files changed, 14 insertions(+), 9 deletions(-)
Approvals:
Tomas Jelinek: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/57798
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ad67c22f12762674a6b817339f5f167422475ea
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: gluster: add heal info column to bricks subtab under hosts
by awels@redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: gluster: add heal info column to bricks subtab under hosts
......................................................................
gluster: add heal info column to bricks subtab under hosts
Add Gluster Heal Info column to bricks subtab under hosts
tab.
Change-Id: If947cdcceff69138bf9457f452bb89e08b2e6ec4
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeBrickView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostBrickView.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/BrickHealInfoColumn.java
3 files changed, 49 insertions(+), 33 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Ramesh N: Verified
--
To view, visit https://gerrit.ovirt.org/57777
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If947cdcceff69138bf9457f452bb89e08b2e6ec4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months