Change in ovirt-engine[master]: core: fix inconsistency with empty cd-rom value
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: fix inconsistency with empty cd-rom value
......................................................................
core: fix inconsistency with empty cd-rom value
By default, the CD-ROM attached to the VM is NULL.
VDSM also reports NULL value in case no CD-ROM is attached.
Recently RunVmCommand was changed to persist the CD-ROM
that is attached to a VM as well, however, it is then set
to an empty string if no CD-ROM is attached. Therefore, the
monitoring gets empty string from the DB and NULL value
from VDSM and decides to update VM dynamic data because of
this change. But later on, the NULL value from VDSM is
ignored and thus, this flow will happen on every monitoring
cycle, leading to many redundant updates of VM dynamic daa.
Change-Id: I5e2afff36f3ee02b57a43760ab88f0a9c3176f37
Bug-Url: https://bugzilla.redhat.com/1340722
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
A packaging/dbscripts/upgrade/04_00_0740_empty_current_cd_to_null.sql
2 files changed, 3 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/58304
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e2afff36f3ee02b57a43760ab88f0a9c3176f37
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: webadmin: EntityModelWidgetWithInfo labelPanel floats left
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: EntityModelWidgetWithInfo labelPanel floats left
......................................................................
webadmin: EntityModelWidgetWithInfo labelPanel floats left
... to prevent it from spanning over whole horizontal space which caused
contentWidgetContainer to be vertically shifted below label.
The problem was reported in Import VMs dialog > VmWare > vCenter and
Import VMs dialog > XEN (via RHEL) > URI + 'Proxy Host'.
Change-Id: Ie9e3933f70c1a2fea5313ed24ec16e68214f3033
Bug-Url: https://bugzilla.redhat.com/1338723
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/EntityModelWidgetWithInfo.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/EntityModelWidgetWithInfo.ui.xml
2 files changed, 17 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58293
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9e3933f70c1a2fea5313ed24ec16e68214f3033
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: Add video device if not present in the ovf store
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Add video device if not present in the ovf store
......................................................................
Add video device if not present in the ovf store
Because the video device was not always reported correct in the past
there are ways to import the HE VM into ovirt-engine without the video
device. This means that it will not appear in the ovf store and
therefore we would not ask for it on the next VM restart.
Here a fallback video device configuration is provided in that case.
This is only 3.6 related. On 4.0 all involved components are fixed.
Change-Id: I8b412e2d93ba6269743257e93342ceaa47eb2299
Related-To: https://bugzilla.redhat.com/1326810
Related-To: https://bugzilla.redhat.com/1328921
Bug-Url: https://bugzilla.redhat.com/1339305
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams.py
1 file changed, 24 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved
Roman Mohr: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/58239
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b412e2d93ba6269743257e93342ceaa47eb2299
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.3
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: Extract video device from OVF store
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Extract video device from OVF store
......................................................................
Extract video device from OVF store
To stay in sync with ovirt-engine, also extract video devices from the
OVF store.
Change-Id: I72f42a299578975a6a1a838ee65eff15586264a9
Related-To: https://bugzilla.redhat.com/1326810
Related-To: https://bugzilla.redhat.com/1328921
Bug-Url: https://bugzilla.redhat.com/1339305
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams.py
M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams_test.py
M ovirt_hosted_engine_ha/lib/ovf/ovf_test.xml
3 files changed, 29 insertions(+), 0 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
Roman Mohr: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57887
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I72f42a299578975a6a1a838ee65eff15586264a9
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.3
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-3.6]: aaa: fix group's permissions removal
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: aaa: fix group's permissions removal
......................................................................
aaa: fix group's permissions removal
Commit - Ica8610e4cf613629c0fbc0a8d7414598a8bbd899
introduced regression which disabled removal of permission assigned to a group.
This patch fixes it.
Change-Id: I621dcf89e71062c7bc5b315f085135805d39f1b9
Bug-Url: https://bugzilla.redhat.com/1340932
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemovePermissionCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Passed CI tests
Ondra Machacek: Verified
Martin Peřina: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/58357
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I621dcf89e71062c7bc5b315f085135805d39f1b9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-3.6]: engine: don't allow removal of inherited perms via rest
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: don't allow removal of inherited perms via rest
......................................................................
engine: don't allow removal of inherited perms via rest
Previously it was possible to remove inherited permissions from user/group
via rest api call. Now we do check at backend if user is trying to remove
inherited permissions from user/group and if yes we do not allow it.
Change-Id: Ica8610e4cf613629c0fbc0a8d7414598a8bbd899
Bug-Url: https://bugzilla.redhat.com/1340932
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemovePermissionCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/PermissionsOperationsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendPermissionResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendPermissionResourceTest.java
7 files changed, 33 insertions(+), 3 deletions(-)
Approvals:
Piotr Kliczewski: Passed CI tests
Ondra Machacek: Verified
Martin Peřina: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/58355
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica8610e4cf613629c0fbc0a8d7414598a8bbd899
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: core: adding CreateVolumeCommand
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: adding CreateVolumeCommand
......................................................................
core: adding CreateVolumeCommand
Change-Id: I06833f0c13ea08cb79e0e15e6dc06615b65a3f72
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CreateVolumeCommand.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateVolumeParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
3 files changed, 235 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/44784
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I06833f0c13ea08cb79e0e15e6dc06615b65a3f72
Gerrit-PatchSet: 33
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: core: adding CreateVolumeContainerCommand
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: adding CreateVolumeContainerCommand
......................................................................
core: adding CreateVolumeContainerCommand
Change-Id: I6a2bb536a873005bc69c6a981046db6151e55945
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CreateVolumeContainerCommand.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateVolumeContainerCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
3 files changed, 124 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/44783
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a2bb536a873005bc69c6a981046db6151e55945
Gerrit-PatchSet: 32
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: core: AddImageFromScratchCommand - adjust to dc without spm
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: AddImageFromScratchCommand - adjust to dc without spm
......................................................................
core: AddImageFromScratchCommand - adjust to dc without spm
This patch adjusts AddImageFromScratchCommand to support DC
without spm, in case of dc without spm CreateVolume command will
be executed.
Change-Id: I600d649d49327473cb357a3bd17bcc161740f9e3
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AddImageFromScratchCommand.java
1 file changed, 76 insertions(+), 20 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/57650
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I600d649d49327473cb357a3bd17bcc161740f9e3
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: core: moving size calc for disk copy with collapse to Images...
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: moving size calc for disk copy with collapse to ImagesHandler
......................................................................
core: moving size calc for disk copy with collapse to ImagesHandler
When creating a disk in SDM DC the engine needs to allocate enough space
so that the data copy will succeed.
This patch moves a method that contains the calculation to ImagesHandler so
that it can be reused.
Change-Id: I7d5e86c06bab82f1babee294ab072d6a75c176f9
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidator.java
2 files changed, 33 insertions(+), 25 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/58232
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d5e86c06bab82f1babee294ab072d6a75c176f9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months