Change in ovirt-engine[master]: core: adding support to callback end method retries
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: adding support to callback end method retries
......................................................................
core: adding support to callback end method retries
Currently we call onSuccedded()/onFailed() upon the callback
polling end. In case of failure the command status will be marked
as failed. This patch adds support for retries in case of failure
in executing the end methods.
Change-Id: Ie82204c62ab158ef7e2e210b8e7e678c5522f006
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCallbacksPoller.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCallback.java
3 files changed, 63 insertions(+), 7 deletions(-)
Approvals:
Moti Asayag: Looks good to me, approved
Liron Aravot: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55922
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie82204c62ab158ef7e2e210b8e7e678c5522f006
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: Unbreak RunVmValidatorTest
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Unbreak RunVmValidatorTest
......................................................................
core: Unbreak RunVmValidatorTest
Fixed RunVmValidatorTest that was broken by commit 6559261.
The aforementioned commit moved the handling of OsRepository from
RunVmValidatorTest to VmCommonUtils, but neglected to change the way the
test was mocking it accordingly.
Change-Id: I0c325650cd929e52ad5a6ac913eb7dcf0931a4a1
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java
1 file changed, 9 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/57468
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c325650cd929e52ad5a6ac913eb7dcf0931a4a1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: Remove RunVmValidator#osRepository
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove RunVmValidator#osRepository
......................................................................
core: Remove RunVmValidator#osRepository
Remove the osRepository member and its getter that were no longer used
since commit 6559261.
Change-Id: Ic5f38663756881c42a9d031af8669e4538e8261a
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
1 file changed, 0 insertions(+), 8 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/57469
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5f38663756881c42a9d031af8669e4538e8261a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: VdcActionParametersBase - replacing shouldBeEndedByPar...
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: VdcActionParametersBase - replacing shouldBeEndedByParent with enum
......................................................................
core: VdcActionParametersBase - replacing shouldBeEndedByParent with enum
Currently we use a boolean (shouldBeEndedByParent) to indicate to the infra
how a child command should be ended (either when its async operations ends or
by its parent command).
In order to attempt endAction() retries in the CoCo infrastacture, this flag
should be converted to an enum. The reason is that when using a boolean flag,
in case of retrying to execute the parent endAction() it won't be able to detect
which child commands it should "collect" in CommandBase.handleChildCommands()
as their shouldBeEndedByParent flag was already updated.
This patch adds an enum called EndProcedure to replace the boolean, when the parent
"takes over" a child command this flag will be updated to indicate that.
Change-Id: I61b201dcc7742975a2d363be252ea00003adaf48
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalProviderCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveAllCinderSnapshotDisksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveAllVmCinderDisksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderVolumeParentCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RestoreAllCinderSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainWithOvfUpdateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStorageDomainCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java
19 files changed, 78 insertions(+), 30 deletions(-)
Approvals:
Liron Aravot: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55921
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I61b201dcc7742975a2d363be252ea00003adaf48
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: commands in EXECUTION_FAILED status might have running...
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: commands in EXECUTION_FAILED status might have running childs
......................................................................
core: commands in EXECUTION_FAILED status might have running childs
When the command status is EXECUTION_FAILED the command might
still have running child commands, there command shouldn't be
considered as ended until all of its child commands were ended.
Currently not all callbacks has the appropiate handling to that
status and its sometimes assumed that a child command on that status
was ended with failure.
This patch adds pollOnExecutionFailed() to indicate whether doPolling()
should be executed for the command if its on EXECUTION_FAILED status
untill all the callbacks will inheirt from the same base callback.
Change-Id: I713b4d179316e056466d402fe3201fad5666b849
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCallbacksPoller.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCallback.java
3 files changed, 22 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/53158
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I713b4d179316e056466d402fe3201fad5666b849
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: fix NPE while detecting external vm
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: fix NPE while detecting external vm
......................................................................
core: fix NPE while detecting external vm
A regression that was caused by recent refactoring in VMs-monitoring lead
to a NPE when an external VM is detected. Therefore, adding a null-check
to prevent this from happening.
Change-Id: I71ca5639661e493d511a97928949624b183c3923
Bug-Url: https://bugzilla.redhat.com/1335186
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerFactory.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/57458
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I71ca5639661e493d511a97928949624b183c3923
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: webadmin: Change button name to import for unregistered disks.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: webadmin: Change button name to import for unregistered disks.
......................................................................
webadmin: Change button name to import for unregistered disks.
Storage -> Import Disks
Change the butoon name "Register" to "Import" for importing unregistered
disks, so it will be the same button name we use also for
importing VMs and Templates
Change-Id: Idfe67a62e92e61418d42f454f96eb34449629219
Signed-off-by: Maor Lipchuk <maorlipchuk(a)gmail.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageRegisterDiskImageView.java
2 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57325
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idfe67a62e92e61418d42f454f96eb34449629219
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: engine : No debug log entry for user executing multiple actions
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine : No debug log entry for user executing multiple actions
......................................................................
engine : No debug log entry for user executing multiple actions
Debug log entry needs to be added
when the user executes a mutiple actions
command.
Change-Id: I64025fc448a4806f4cd58c60086a47f4bcc4381a
Bug-Url: https://bugzilla.redhat.com/1314826
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PrevalidatingMultipleActionsRunner.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SequentialMultipleActionsRunner.java
3 files changed, 31 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Ravi Nori: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/57423
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64025fc448a4806f4cd58c60086a47f4bcc4381a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: remove internal query for watchdog device
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: remove internal query for watchdog device
......................................................................
core: remove internal query for watchdog device
AddWatchdogCommand used to call GetWatchdog query. This is
not the standard way to do it in the backend, but to use
the DAO explicitly instead.
Change-Id: Ie5f58b752a71b2d03a4c727d804335f220b72aa1
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddWatchdogCommand.java
1 file changed, 9 insertions(+), 10 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/54146
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie5f58b752a71b2d03a4c727d804335f220b72aa1
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine-sdk[master]: Update to version 4.0.17 model and 1.0.11 of metamodel
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Update to version 4.0.17 model and 1.0.11 of metamodel
......................................................................
Update to version 4.0.17 model and 1.0.11 of metamodel
The more relevant changes in this new version of the model is that the
"Status" type has been removed, and replaced by enums or strings. So the
tests and examples need to be updated to use "whatever.status" instead
of "whatever.status.state".
Change-Id: Id251ca889db9dc47221cd21e4e50191fc0430b52
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M pom.xml
M sdk/examples/add_host.py
M sdk/examples/add_nfs_data_storage_domain.py
M sdk/examples/add_nfs_iso_storage_domain.py
M sdk/examples/add_vm_disk.py
M sdk/examples/attach_nfs_data_storage_domain.py
M sdk/examples/attach_nfs_iso_storage_domain.py
M sdk/examples/remove_host.py
M sdk/examples/start_vm.py
M sdk/examples/stop_vm.py
10 files changed, 11 insertions(+), 19 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57426
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id251ca889db9dc47221cd21e4e50191fc0430b52
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months