Change in ovirt-engine[ovirt-engine-4.0]: webadmin: v2v -moving vms between lists got stuck
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: v2v -moving vms between lists got stuck
......................................................................
webadmin: v2v -moving vms between lists got stuck
when choosing vms to import in the import VMs dialog, then clicking
"Next" to next import dialog for choosing cluster and then clicking
"Back" to display the first import dialog again:
in this senario when moving vms from importedVmModels list to
externalVmModels and vice versa, at some point clicking the arrow
button does nothing (arrow button is clicked and button callback is
called but VM is not moved).
This problem occurred because when clicking "back" button and
displaying 1st dialog, new UI objects are created for the 1st dialog
(SplitTable,ImportVmsPopupView...), but the old ones for this 1st dialog
are still alive and both old and new UI objects share the same model.
This causes the old UI button callbacks to disrupt the data for the new
UI objects. in some point when clicking on
a vm to select it with checkbox, the "old" button callback calulated it
as 2 vms checked although only one vm is actually checked.
Trying to move this VM by clicking the arrow causes failure and nothing
is moved.
The fix for this bug includes reseting both importedVmModels and
externalVmModels lists of the model (copying the items list only)
before creating the new UI instances for the "Back" operation.
Change-Id: Ib34d108a2959a50df0e39edd21360d2e5feb4f54
Bug-Url: https://bugzilla.redhat.com/1338740
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
2 files changed, 13 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
--
To view, visit https://gerrit.ovirt.org/58354
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib34d108a2959a50df0e39edd21360d2e5feb4f54
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: aaa : Automatic logout does not terminate user session
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: aaa : Automatic logout does not terminate user session
......................................................................
aaa : Automatic logout does not terminate user session
Automatic logout at the expiration of
UserSessionTimeOutInterval should terminate
the session if the session has been inactive
Change-Id: I6712291801ba579b3c4ac7da161f39fbaf38a32e
Bug-Url: https://bugzilla.redhat.com/1340471
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/58398
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6712291801ba579b3c4ac7da161f39fbaf38a32e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: Domain Object builder for unit, DAO and integration tests
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: Domain Object builder for unit, DAO and integration tests
......................................................................
Domain Object builder for unit, DAO and integration tests
Add builders vor VMs, Hosts and clusters. These builders contain two
methods to actually create an entity:
* AbstractBuilder#persist() to persist the built object in a real
database. This is very useful when running DAO or integration tests
with an available database.
* AbstractBuilder#build() to just build the objects and return them.
This is very useful when writing unit tests. No database needs to be
present and no DAOs are involved.
Change-Id: Ia02585332f997e4eab151f62c5c2208e65b84346
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/builder/AbstractBuilder.java
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/builder/ClusterBuilder.java
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/builder/MacPoolBuilder.java
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/builder/VdsBuilder.java
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/builder/VmBuilder.java
M backend/manager/modules/dal/src/test/resources/test-beans.xml
6 files changed, 481 insertions(+), 0 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, but someone else must approve
Roman Mohr: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47007
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia02585332f997e4eab151f62c5c2208e65b84346
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: packaging: setup: postgres applyEnvironment: Allow missing keys
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: postgres applyEnvironment: Allow missing keys
......................................................................
packaging: setup: postgres applyEnvironment: Allow missing keys
This allows not calling setdefault for each key separately.
Change-Id: I4cbcdb4160df403fc6f58b6757e52c7bcfbe6485
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/engine_common/postgres.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/57967
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4cbcdb4160df403fc6f58b6757e52c7bcfbe6485
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months