Change in ovirt-engine[master]: restapi: Update to model 4.1.6
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Update to model 4.1.6
......................................................................
restapi: Update to model 4.1.6
The more relevant changes in the new version of the model are the
following:
* Add the `originalTemplate` link to the virtual machine type.
* Add `permits` to the cluster level type.
* Add the `current` parameter to the virtual machine graphics consoles
service.
* Fix the name of the output parameter of the method to list affinity
groups, should be `groups` instead of `list`.
Change-Id: I2bf6100d27cfb85aa2aed63fcc70ee7b6d92a5a4
Related-To: https://bugzilla.redhat.com/1355647
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60810
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2bf6100d27cfb85aa2aed63fcc70ee7b6d92a5a4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi: Fix VMs/Templates disks link
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Fix VMs/Templates disks link
......................................................................
restapi: Fix VMs/Templates disks link
Change-Id: Ia3b810448affdf93136dac46eb72cc5002d5d4fa
Bug-Url: https://bugzilla.redhat.com/1356649
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
(cherry picked from commit 8db57b2d9d5a5ade0c96427f1804ce68d192ff07)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3TemplateHelper.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java
2 files changed, 2 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Verified
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60906
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3b810448affdf93136dac46eb72cc5002d5d4fa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-hosted-engine-setup[master]: upgrade: fix initial loading of domainType value
by stirabos@redhat.com
Simone Tiraboschi has submitted this change and it was merged.
Change subject: upgrade: fix initial loading of domainType value
......................................................................
upgrade: fix initial loading of domainType value
Fix the initial loading of domainType value from
hosted-engine.conf since otherwise on upgrades it's not
possible to load the initial answer file from the shared
storage if on glusterFS.
Change-Id: I87220f33497e2fcb5dd54e30ab0667a708d61afc
Bug-Url: https://bugzilla.redhat.com/1356221
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/gr-he-rollbackupgrade/core/misc.py
M src/plugins/gr-he-upgradeappliance/core/misc.py
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Simone Tiraboschi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Rafael Martins: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/60902
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I87220f33497e2fcb5dd54e30ab0667a708d61afc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[master]: restapi: Fix VMs/Templates disks link
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Fix VMs/Templates disks link
......................................................................
restapi: Fix VMs/Templates disks link
Change-Id: Ia3b810448affdf93136dac46eb72cc5002d5d4fa
Bug-Url: https://bugzilla.redhat.com/1356649
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3TemplateHelper.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java
2 files changed, 2 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Verified
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60901
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3b810448affdf93136dac46eb72cc5002d5d4fa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[ovirt-engine-4.0]: bll: search: don't replace all ocurrence of pattern
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: bll: search: don't replace all ocurrence of pattern
......................................................................
bll: search: don't replace all ocurrence of pattern
Previously we replaced all occurances of pattern in search text,
which could lead in replacing unwanted characters. This patch
changes the behaviour in a way, that we just replace first found
characters.
Change-Id: I659b9a6043643cc3ad2358bb12fa46cadb6e0f4d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1356675
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
(cherry picked from commit 85642149c1780dd943b2aef817f586b7defb0cc2)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ondra Machacek: Verified
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60892
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I659b9a6043643cc3ad2358bb12fa46cadb6e0f4d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in jenkins[master]: Fix wrong jenkins repo conf in coverity job
by eedri@redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: Fix wrong jenkins repo conf in coverity job
......................................................................
Fix wrong jenkins repo conf in coverity job
Change-Id: Ib73beca81e30ab5d40f4686c1a8ea984303d5098
Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com>
---
M jobs/confs/yaml/jobs/ovirt-engine_master_coverity-analysis.yaml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sharon Naftaly: Verified; Ready for review
Eyal Edri: Ready for merge
Barak Korren: Looks good to me
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60890
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib73beca81e30ab5d40f4686c1a8ea984303d5098
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Fix disable of the entire edit disk popup when VM ...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fix disable of the entire edit disk popup when VM is running
......................................................................
webadmin: Fix disable of the entire edit disk popup when VM is running
Change I14dcbfb50a6249de6380346469baa055f7130662 (937704c5) introduced
the ReadOnlyDiskModel used for image upload purposes, to decide whether to
disable the entire dialog it used the isEditEnabled() methods from the
parent model which although the misleading does not mean that the entire
panel should be disabled but whether properties that are no editable when
the VM is up should be disabled, this cause the edit dialog to be disabled
at all times.
This fixes it by calling getIsModelDisabled() after the initial load of
the data centers
Change-Id: I274635fbf97f0af45c1b1170dce887d480424b74
Bug-Url: https://bugzilla.redhat.com/1349498
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ReadOnlyDiskModel.java
2 files changed, 3 insertions(+), 10 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/60891
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I274635fbf97f0af45c1b1170dce887d480424b74
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[master]: core: VmDeviceUtils#addImportedOtherDevices local var
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: VmDeviceUtils#addImportedOtherDevices local var
......................................................................
core: VmDeviceUtils#addImportedOtherDevices local var
Removed the unused hasSound local variable.
Change-Id: I27f98080f6a4d8d48370d2bd4094e511f8b3db9d
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Allon Mureinik: Verified; Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/60878
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I27f98080f6a4d8d48370d2bd4094e511f8b3db9d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[master]: core: VmDeviceUtils type inference
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: VmDeviceUtils type inference
......................................................................
core: VmDeviceUtils type inference
Change-Id: Ie155a036aa1a6c04ede8de56070afa777e5ce744
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Allon Mureinik: Verified; Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/60877
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie155a036aa1a6c04ede8de56070afa777e5ce744
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[master]: core: VmDeviceUtils - use addAll
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: VmDeviceUtils - use addAll
......................................................................
core: VmDeviceUtils - use addAll
Use List's addAll method instead of looping over add methods. This
reduces some boilerplate code from the class and makes these calls
slightly neater.
Change-Id: I93c3e2d9a057094dc11b3b7d3e64020d50c45fc9
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 2 insertions(+), 6 deletions(-)
Approvals:
Allon Mureinik: Verified; Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/60880
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93c3e2d9a057094dc11b3b7d3e64020d50c45fc9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months