Change in ovirt-engine[master]: core: add ctor to vm-statistics
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: add ctor to vm-statistics
......................................................................
core: add ctor to vm-statistics
Add a constructor to VmStatistics that gets only VM ID.
It seems to be useful in several flows now.
Change-Id: Ia8e89760dff032a24d65bfb69498b20ff18248ae
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
5 files changed, 9 insertions(+), 8 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/60682
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8e89760dff032a24d65bfb69498b20ff18248ae
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[master]: core: cleanup handOverVm
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: cleanup handOverVm
......................................................................
core: cleanup handOverVm
Do the following changes in VmAnalyzer#handOverVm:
1. remove its argument and use VmAnalyzer#dbVm instead
2. remove unneeded empty lines
3. extract the log printing into a separate method
Change-Id: Ib4dc89b83f8a42dc7161fc0a5a980c4cb213be11
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
1 file changed, 16 insertions(+), 17 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/60681
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4dc89b83f8a42dc7161fc0a5a980c4cb213be11
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[master]: restapi: Document change in "action.iscsi_target"
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Document change in "action.iscsi_target"
......................................................................
restapi: Document change in "action.iscsi_target"
In version 3 of the API the operation to discover unregistered storage
domains used to receive a list of iSCSI targets, using multiple
iscsi_target elements:
POST /hosts/{host:id}/unregisteredstoragedomaindiscover
<action>
<iscsi>
<address>myiscsiserver</address>
</iscsi>
<iscsi_target>iqn.2016-07.com.example:mytarget1</iscsi_target>
<iscsi_target>iqn.2016-07.com.example:mytarget2</iscsi_target>
</action>
In version 4 of the API all repeating elements, like iscsi_target in
this case, are wrapped with another element, iscsi_targets in case. So
the same request should now look like this:
POST /hosts/{host:id}/unregisteredstoragedomaindiscover
<action>
<iscsi>
<address>myiscsiserver</address>
</iscsi>
<iscsi_targets>
<iscsi_target>iqn.2016-07.com.example:mytarget1</iscsi_target>
<iscsi_target>iqn.2016-07.com.example:mytarget2</iscsi_target>
</iscsi_targets>
</action>
Change-Id: Ic33c11c09714c003e5e8309156a19d14ffcf6820
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/README.adoc
1 file changed, 36 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60677
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic33c11c09714c003e5e8309156a19d14ffcf6820
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[master]: packaging: setup: Verify Postgresql server version
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Verify Postgresql server version
......................................................................
packaging: setup: Verify Postgresql server version
Verify that server and client versions are equal.
Change-Id: Id316925392c712a4e5471d3d9c6625f4b10194c3
Bug-Url: https://bugzilla.redhat.com/1331168
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/engine_common/database.py
M packaging/setup/ovirt_engine_setup/engine_common/postgres.py
2 files changed, 30 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/59941
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id316925392c712a4e5471d3d9c6625f4b10194c3
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in jenkins[master]: ovirt-host-deploy: move from fc22 to fc24
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-host-deploy: move from fc22 to fc24
......................................................................
ovirt-host-deploy: move from fc22 to fc24
- drop fc22 since gone EOL
- move master to fc24
- 4.0 use newly created 4.0 branch
Change-Id: Ia3ebf103a36a54dbc5406f107d18ab53e001549c
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/ovirt-host-deploy/ovirt-host-deploy_create-rpms.yaml
M jobs/confs/projects/ovirt-host-deploy/ovirt-host-deploy_standard.yaml
2 files changed, 11 insertions(+), 7 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60701
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3ebf103a36a54dbc5406f107d18ab53e001549c
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in jenkins[master]: publisher: use 4.0 jobs for 4.0 publishing
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: publisher: use 4.0 jobs for 4.0 publishing
......................................................................
publisher: use 4.0 jobs for 4.0 publishing
- copycreate branched for supporting fc24 on master
- use 4.0 jobs with 4.0 publisher where a 4.0 job exists
- fix 3.6 publisher which was using master copy on 3.6 jobs
Change-Id: I8640ea7962cf4f5502e0e63011ea2ae9f554258b
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml
M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml
M jobs/confs/yaml/builders/copy-create-job-artifact.yaml
3 files changed, 75 insertions(+), 48 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Ready for merge
Barak Korren: Looks good to me
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60696
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8640ea7962cf4f5502e0e63011ea2ae9f554258b
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[master]: core: Logging of VmPoolMonitor fixed
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: Logging of VmPoolMonitor fixed
......................................................................
core: Logging of VmPoolMonitor fixed
* Log message about failed VM prestarting was not always printed. E.g.
when there was only one VM in the pool. Fixed.
* Log level of failures during prestarting was changed from INFO to
WARN.
* Ids of VMs that failed to prestart were added to the log.
Change-Id: I1384c893015b8abf91e2863d4181d14c807dee50
Bug-Url: https://bugzilla.redhat.com/1346848
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolMonitor.java
1 file changed, 17 insertions(+), 18 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/60144
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1384c893015b8abf91e2863d4181d14c807dee50
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in jenkins[master]: Don't try to build Java SDK 4 using standard CI
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: Don't try to build Java SDK 4 using standard CI
......................................................................
Don't try to build Java SDK 4 using standard CI
There are currently two job configuration files for the Java SDK:
* ovirt-engine-sdk-java_create-rpms.yaml
This configuration file defines the jobs that build version 3 of
the SDK, and those jobs don't use the "automation" directory
used by the oVirt "standard CI" mechanism. Instead of that the
job just calls "make" to do the build.
* ovirt-engine-sdk-java_build-artifacts.yaml
This configuration file defines the jobs that build version 4 of
the SDK, using the "automation" directory.
But currently we are trying to build version 4 of the SDK (from branch
"sdk_4.0") from both job configuration files, and that will always fail
because that branch does't contain a Makefile that can be executed just
with the "make" command.
This patch changes the job configuration files of the SDK so that we
don't try to build version 4 of the Java SDK using the old approach
based on the "make" command.
Version 3 of the SDK will still be built the old way, as we don't expect
big changes there and we don't consider it worth the effort.
Change-Id: If4b8188ef5b68a1a94d5fdfa9375a7951cf49537
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M jobs/confs/projects/ovirt-engine-sdk-java/ovirt-engine-sdk-java_build-artifacts.yaml
M jobs/confs/projects/ovirt-engine-sdk-java/ovirt-engine-sdk-java_create-rpms.yaml
2 files changed, 0 insertions(+), 8 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me; Ready for review
Eyal Edri: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60626
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If4b8188ef5b68a1a94d5fdfa9375a7951cf49537
Gerrit-PatchSet: 4
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in jenkins[master]: ovirt-setup-lib: move from fc22 to fc24
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-setup-lib: move from fc22 to fc24
......................................................................
ovirt-setup-lib: move from fc22 to fc24
- Dropped fc22 since gone EOL
- Moved master to fc24
Change-Id: Ifc2ce9555dffacc2dce3263fb4fb296240df2bef
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/ovirt-setup-lib/ovirt-setup-lib_build-artifacts.yaml
1 file changed, 12 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60673
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc2ce9555dffacc2dce3263fb4fb296240df2bef
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[master]: core: replacing DataCenterWithoutSpm config value
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: replacing DataCenterWithoutSpm config value
......................................................................
core: replacing DataCenterWithoutSpm config value
This patch replaces the DataCenterWithoutSpm with a new
DataOperationsByHSM config value because of the change in the
feature scope.
Change-Id: Ie11ac48f0c501677ccc972af10d2cd2070f86532
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AddImageFromScratchCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/BaseImagesCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
A packaging/dbscripts/upgrade/04_01_0150_delete_datacenterwithoutspm_conf_value.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
7 files changed, 18 insertions(+), 17 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/60663
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie11ac48f0c501677ccc972af10d2cd2070f86532
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months