August 2016 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: webadmin: Mark instance image as changed in new and attach

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Mark instance image as changed in new and attach ...................................................................... webadmin: Mark instance image as changed in new and attach Change I998e8c573c8afaf45668729cf15fb0ebe3edbad5 introduced a change where disk update for instance images will be invoked only upon edit, however, this made new and attach disk actions to be skipped as well. This patch adds the indication of a change to create and attach disk as well so the will not be skipped. Change-Id: I093ccc18a4ab70b4f2a5bcd3ef46abeb41cee55c Bug-Url: https://bugzilla.redhat.com/1371164 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImageLineModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I093ccc18a4ab70b4f2a5bcd3ef46abeb41cee55c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: Ignore failures fetching additional disk data

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Ignore failures fetching additional disk data ...................................................................... restapi: Ignore failures fetching additional disk data When disks are retrieved using version 3 of the API additional data is required, like the disk attachments. If the user doesn't have permission for the additional data then the complete operation fails. This is a problem for users that may not have permission for that additional data. In order to avoid that this patch changes the API so that failures to retrieve the additional data are just ignored. Change-Id: I37159aaa3d767df6c83e666bfcd70ad4ff503e87 Bug-Url: https://bugzilla.redhat.com/1368552 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VmOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDisksServer.java 3 files changed, 60 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37159aaa3d767df6c83e666bfcd70ad4ff503e87 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: core: minor cleanup in vm stop/shutdown parameters

by ahadas＠redhat.com

Arik Hadas has submitted this change and it was merged. Change subject: core: minor cleanup in vm stop/shutdown parameters ...................................................................... core: minor cleanup in vm stop/shutdown parameters Minor changes in the parameters classes of VM stop and shutdown operations. Change-Id: I2d56fd87a249caa113d3260de6abee81f66cda75 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ShutdownVmParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StopVmParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StopVmParametersBase.java 3 files changed, 13 insertions(+), 14 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/63028 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d56fd87a249caa113d3260de6abee81f66cda75 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 2 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Fix overwriting originalClusterVersion

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix overwriting originalClusterVersion ...................................................................... core: Fix overwriting originalClusterVersion Fix of overwriting originalClusterVersion in SnapshotManager. The VmBase.originalClusterVersion is persisted in OVF as CLUSTER_COMPATIBILITY_VERSION and points to the cluster version the snapshot was taken in. Later on, the value is used in UI to check whether the snapshot with memory can be properly restored. Change-Id: Ib6f93e9ef91f283ed5e7ebaea75b0351bbd0ed85 Bug-Url: https://bugzilla.redhat.com/1356172 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java 3 files changed, 11 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63019 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6f93e9ef91f283ed5e7ebaea75b0351bbd0ed85 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 2 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-4.0]: core: log reason for stopping vm only if set

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: log reason for stopping vm only if set ...................................................................... core: log reason for stopping vm only if set Previously we always tried to include the stop reason when auditing VM stop operation. When no reason was set, either because it is not enabled in the cluster or the user simply did not enter a reason, the audit log included the following redundant message: (Reason: No reason was returned for this operation failure. See logs for further details.) This patch changes that so audit logs will include the stop reason only when it is set. That way, we avoid messages as shown above. Change-Id: I25b3ffced6036796d20bfcce0d47c22a3365a80d Bug-Url: https://bugzilla.redhat.com/1340414 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 13 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/63051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25b3ffced6036796d20bfcce0d47c22a3365a80d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: core: VersionStorageFormatUtil redundant semicolon

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: VersionStorageFormatUtil redundant semicolon ...................................................................... core: VersionStorageFormatUtil redundant semicolon Change-Id: If1d60d40db4e1d2167002beb28991a65de9cfd12 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VersionStorageFormatUtil.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63067 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1d60d40db4e1d2167002beb28991a65de9cfd12 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 2 months

1
0
0 / 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Add example of import of external VM

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: Add example of import of external VM ...................................................................... Add example of import of external VM Added example code for importing a virtual machine from VmWare. Change-Id: I815d8c702a7b709027d4732fcf3592aa478bd259 Signed-off-by: Martin Betak <mbetak(a)redhat.com> (cherry picked from commit 0e9ae79c0deb5700906adb3d7c5f3aad9d4c967d) --- A sdk/examples/import_external_vm.rb 1 file changed, 56 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I815d8c702a7b709027d4732fcf3592aa478bd259 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: core: AutoRecoveryManager type inference

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: AutoRecoveryManager type inference ...................................................................... core: AutoRecoveryManager type inference Change-Id: I8a1e32a2a8cb9a492e68115136f882dd2fe0050a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/62980 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a1e32a2a8cb9a492e68115136f882dd2fe0050a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Fix AutoRecoveryManager feature page link

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix AutoRecoveryManager feature page link ...................................................................... core: Fix AutoRecoveryManager feature page link Change-Id: I27d7a6c03fd4b5995e1ef489cacde16fc1319343 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/62981 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27d7a6c03fd4b5995e1ef489cacde16fc1319343 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Simplify AutoRecoveryManager boolean expression

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: Simplify AutoRecoveryManager boolean expression ...................................................................... core: Simplify AutoRecoveryManager boolean expression Change-Id: I7de30c380ac2f6e4e128b2e0f6468e9d49f6c056 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/62982 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7de30c380ac2f6e4e128b2e0f6468e9d49f6c056 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 2 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits August 2016