Change in ovirt-engine[master]: core: StorageJobCallback - logging
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: StorageJobCallback - logging
......................................................................
core: StorageJobCallback - logging
This patch changes and aligns the logging in StorageJobCallback to
the "Command {} id: '{}': MESSAGE" pattern.
Change-Id: Ifc38c6dcb0088234c99d9a99c1d2226d200e70f6
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java
1 file changed, 12 insertions(+), 12 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62266
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc38c6dcb0088234c99d9a99c1d2226d200e70f6
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: adding support for entity polling
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: adding support for entity polling
......................................................................
core: adding support for entity polling
This patch adds the EntityPollingCommand which represents a command
that supports entity polling in case of NonResponsive host or a case
in which the host job cache was cleared before the polling was completed.
Additionally this patch adds the entity polling support to StorageJobCallback.
Change-Id: Ib991ff56a4334fd452e45119693ee982619d4545
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/EntityPollingCommand.java
2 files changed, 65 insertions(+), 13 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Liron Aravot: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/61633
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib991ff56a4334fd452e45119693ee982619d4545
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk[sdk_4.0]: Name plular element tag same as the member
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Name plular element tag same as the member
......................................................................
Name plular element tag same as the member
Previously when we send action and contruct XML with
list of the entity we named tags by the entity. This
patch changes the behavior, so we name it by the member
which is written.
For example if we want to create bonds, we will send following xml:
<action>
<modified_bonds>
<host_nic>
<bonding>
<options>...</options>
<slaves>
<host_nic>
<name>eth0</name>
</host_nic>
<host_nic>
<name>eth1</name>
</host_nic>
</slaves>
</bonding>
<name>bond0</name>
</host_nic>
</modified_bonds>
</action>
Previously we sent <host_nics> instead of <modified_bonds>.
Change-Id: Id1405d540f95abc8dc9dcfa0ac3b2a477b4cba06
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
(cherry picked from commit e6fe52809b0bbfc7390af364d645c4140d0095b6)
---
M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java
M sdk/tests/server.py
A sdk/tests/test_setupnetworks.py
3 files changed, 111 insertions(+), 2 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62532
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1405d540f95abc8dc9dcfa0ac3b2a477b4cba06
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi: Update to model 4.0.32
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Update to model 4.0.32
......................................................................
restapi: Update to model 4.0.32
The more relevant changes included in the new version of the model are
the following:
* Add the `clone_permissions` parameter to the operations that add
virtual machines and templates.
* Add the `clone` parameter to the operation that adds a new virtual
machine.
* Add the `ad_partner_mac` attribute to the bonding type.
* Add the `ad_aggregator_id` attribute to the host NIC type.
* Add the `ExternalVmImportsService` and related types.
* Add the `active` property back to the disk type.
Note that all those changes were actually introduced in version 4.0.31
of the model, but there was a small bug affecting the SDKs but not the
engine. Fixing that bug required making a new 4.0.32 release, and it is
better to keep the engine in sync with the latest model.
Change-Id: Iaf4ec501f1065ebb8a949c6cc3eb9f0a1315aee5
Related-To: https://bugzilla.redhat.com/1281666
Related-To: https://bugzilla.redhat.com/1346847
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
M pom.xml
2 files changed, 8 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62527
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf4ec501f1065ebb8a949c6cc3eb9f0a1315aee5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
8 years, 3 months
Change in ovirt-engine-sdk[sdk_4.0]: Send query parameters with Add/Update actions
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Send query parameters with Add/Update actions
......................................................................
Send query parameters with Add/Update actions
There are use cases where user can sent query parameters,
along with creating/updating entity action.
For example when creating virtual machine he can also
copy permissions from template to new virtual machine.
This patch add the support so the SDK sends the query parameters,
supported by backend.
Change-Id: Icac351dfd6f0e4acc18fd481b90be4adcfae69dd
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1366547
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
(cherry picked from commit 458c678c8f1904b7b4e492ff5a6a44221633beae)
---
M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java
A sdk/examples/add_independet_vm.py
M sdk/tests/server.py
M sdk/tests/test_vm_service.py
4 files changed, 124 insertions(+), 11 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62531
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icac351dfd6f0e4acc18fd481b90be4adcfae69dd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-host-deploy[master]: README: update and make less confusing
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: README: update and make less confusing
......................................................................
README: update and make less confusing
The readme is slightly wrong wrt vdsm-hook-faqemu, we fix that by
using correct variables. Additionally, we make the section explaining
hook installation slightly clearer by referring to the engine as
engine instead of manager, and improving the wording.
Change-Id: Ib06c9e47f5cd02be06442a22367d6b2b0fea9c03
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
---
M README
1 file changed, 17 insertions(+), 7 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Polednik: Verified
--
To view, visit https://gerrit.ovirt.org/62528
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib06c9e47f5cd02be06442a22367d6b2b0fea9c03
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk[sdk_4.0]: Update to model 4.0.32 and metamodel 1.0.17
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Update to model 4.0.32 and metamodel 1.0.17
......................................................................
Update to model 4.0.32 and metamodel 1.0.17
The more relevant changes in this new version of the model are the
following:
* Add the `clone_permissions` parameter to the operations that add
virtual machines and templates.
* Add the `clone` parameter to the operation that adds a new virtual
machine.
* Add the `ad_partner_mac` attribute to the bonding type.
* Add the `ad_aggregator_id` attribute to the host NIC type.
* Add the `upgradecheck` action to the host service.
* Add the `ExternalVmImportsService` and related types.
The new version of the metamodel isn't really needed, as the changes
only affect the Java code generators, but it is anyhow convenient to
use the same version that the other SDKs and the engine.
Change-Id: I79dd070a9c4ba2068a9b10ba884184f8889c4b42
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M pom.xml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62530
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79dd070a9c4ba2068a9b10ba884184f8889c4b42
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk[master]: Send query parameters with Add/Update actions
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Send query parameters with Add/Update actions
......................................................................
Send query parameters with Add/Update actions
There are use cases where user can sent query parameters,
along with creating/updating entity action.
For example when creating virtual machine he can also
copy permissions from template to new virtual machine.
This patch add the support so the SDK sends the query parameters,
supported by backend.
Change-Id: Icac351dfd6f0e4acc18fd481b90be4adcfae69dd
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1366546
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java
A sdk/examples/add_independet_vm.py
M sdk/tests/server.py
M sdk/tests/test_vm_service.py
4 files changed, 124 insertions(+), 11 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62457
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icac351dfd6f0e4acc18fd481b90be4adcfae69dd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk[master]: Name plular element tag same as the member
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Name plular element tag same as the member
......................................................................
Name plular element tag same as the member
Previously when we send action and contruct XML with
list of the entity we named tags by the entity. This
patch changes the behavior, so we name it by the member
which is written.
For example if we want to create bonds, we will send following xml:
<action>
<modified_bonds>
<host_nic>
<bonding>
<options>...</options>
<slaves>
<host_nic>
<name>eth0</name>
</host_nic>
<host_nic>
<name>eth1</name>
</host_nic>
</slaves>
</bonding>
<name>bond0</name>
</host_nic>
</modified_bonds>
</action>
Previously we sent <host_nics> instead of <modified_bonds>.
Change-Id: Id1405d540f95abc8dc9dcfa0ac3b2a477b4cba06
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java
M sdk/tests/server.py
A sdk/tests/test_setupnetworks.py
3 files changed, 111 insertions(+), 2 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62445
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1405d540f95abc8dc9dcfa0ac3b2a477b4cba06
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk[master]: Update to model 4.1.10 and metamodel 1.1.2
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Update to model 4.1.10 and metamodel 1.1.2
......................................................................
Update to model 4.1.10 and metamodel 1.1.2
The more relevant changes in this new version of the model are the
following:
* Add the `clone_permissions` parameter to the operations that add
virtual machines and templates.
* Add the `clone` parameter to the operation that adds a new virtual
machine.
* Add the `ad_partner_mac` attribute to the bonding type.
* Add the `ad_aggregator_id` attribute to the host NIC type.
* Add the `upgradecheck` action to the host service.
* Add the `ExternalVmImportsService` and related types.
The new version of the metamodel isn't really needed, as the changes
only affect the Java code generators, but it is anyhow convenient to
use the same version that the other SDKs and the engine.
Change-Id: I79dd070a9c4ba2068a9b10ba884184f8889c4b42
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M pom.xml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62526
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79dd070a9c4ba2068a9b10ba884184f8889c4b42
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months