Change in ovirt-engine[ovirt-engine-4.0]: engine: Fix taskhandler init - RemoveDisksSnapshot
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: Fix taskhandler init - RemoveDisksSnapshot
......................................................................
engine: Fix taskhandler init - RemoveDisksSnapshot
The method initTaskHandlers is called every time that the command is
initiated.
In RemoveDiskSnapshotsCommand, the number of task handlers created was
different after that the former handler finished its operation.
This situation created a mismatch between the task handler map in
BaseCommand and the command execution index.
In this patch, the images IDs are computed only once and not every time
that the initTaskHandlers is invoked, keeping the number of task
handlers consistent.
Also, the task handlers are not created if it is a live merge flow.
Change-Id: Ic2836d7f6430183eecef337ed6d1c667b2f2990c
Bug-Url: https://bugzilla.redhat.com/1365393
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommand.java
1 file changed, 7 insertions(+), 17 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/62175
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2836d7f6430183eecef337ed6d1c667b2f2990c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: engine : Async tasks should handle exception in creating task
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: engine : Async tasks should handle exception in creating task
......................................................................
engine : Async tasks should handle exception in creating task
When async tasks have multiple child commands and
one of them fails to be submitted to vdsm, the
AsyncTaskManager should be able to keep track of
the root command and invoke endWithFailure.
Change-Id: Ic51a7d94b7c593a178222fee2e0cf01eaa7cfc45
Bug-Url: https://bugzilla.redhat.com/1360373
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java
1 file changed, 11 insertions(+), 0 deletions(-)
Approvals:
Ravi Nori: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Liron Aravot: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/61689
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic51a7d94b7c593a178222fee2e0cf01eaa7cfc45
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: webadmin: v2v-improve loading of external vms
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: v2v-improve loading of external vms
......................................................................
webadmin: v2v-improve loading of external vms
Improve the loading performance of external VMs from external server
for the following sources: VMware, KVM, Xen.
This is done by receiving the VMs names only in the 1st phase, i.e. in
the 1st import dialog (New VDSM api was added for receiving
VMS names only on a seperate patch).
And only when choosing the VMS to import and clicking on the "Next"
button in order to display full VMs data on the 2nd dialog,
then we receive full info (xml+disks) for those choosen VMs only.
(changing the existed VDSM api for receiving full
VMs data on subset of VMS and not for all VMs existed was added in a
seperate patch).
The following functional changes were done to support it:
1. Displaying only VMs names in those two lists of 1st dialog. The CPU
architecture for each VM which was displayed in brackets was removed.
2. Checking the cpu architecture of the chosen VMS in order to find
appropriate cluster is done only after clicking the "Next" button
because we don't have this information earlier. In case of a problem
with the cpu architecture, a popup message is displayed as before.
3. The VMs status (up/down) is known only after clicking the "Next"
button. Therefore in case the user choose VMs in 1st dialog which are
discovered to be running or can't be retrieved with their full info,
they won't appear on 2nd dialog, BUT a warning message in
the appropriate dialog is displayed in such cases and
also a message in audit log listing the running VMs is
added.
So the user will be able to stop/fix those VMs, click "Back" and then
"Next" and those missing VMs will appear in the 2nd dialog.
4. Each clicking on the "Next" button "reloads" all VMs data for
all chosen VMs and not just for the added new ones.
5. backward compatibility - for handling old proxy hosts:
When choosing old proxy host < 4.1 then the flow is the old flow as
done before this fix.
Meaning that we get all VMs with full data in the 1st dialog.
The only changes for old proxy hosts are that no cpu architecture is
displayed and also better and new messages and logging in case of
running/non-retrieved VMs choosen to be imported.
6. Adding this new patch support for 4.1 and upper versions is
configurable via the vdc_options and can be disabled if needed.
Bug-Url: https://bugzilla.redhat.com/1294629
Change-Id: Ica95a150c656ad9b860914323b05ba466837be77
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsFromExternalProviderQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderProxyFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/vms/AbstractVmProviderProxy.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsFromExternalProviderQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetVmsFromExternalProviderParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVmsFullInfoFromExternalProviderVDSCommand.java
R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVmsNamesFromExternalProviderVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VMListReturnForXmlRpc.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VMNamesListReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalProviderModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalSourceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M frontend/webadmin/modules/uicompat/exclude-filters.xml
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
32 files changed, 479 insertions(+), 80 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
Arik Hadas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/60409
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica95a150c656ad9b860914323b05ba466837be77
Gerrit-PatchSet: 31
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: log num of running vms only upon change
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: log num of running vms only upon change
......................................................................
core: log num of running vms only upon change
The log of the number of running VMs on a host flooded the engine log.
Therefore, adding some logic in order to log it only when the number
of running VMs on a host is changed.
Change-Id: I7184e48d9ca5d87cab1491d58f63628a8a6d997e
Bug-Url: https://bugzilla.redhat.com/1366138
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsStatisticsFetcher.java
1 file changed, 16 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/62234
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7184e48d9ca5d87cab1491d58f63628a8a6d997e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: packaging: setup: Enroll missing pki on upgrade
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Enroll missing pki on upgrade
......................................................................
packaging: setup: Enroll missing pki on upgrade
Without this patch, imageio-proxy pki will not be generated on upgrade
from 3.6, because it did not exist then.
Change-Id: Ib5bbe9ddb45bfcbf6b7bf8aa7c6e2fb19fa206fe
Bug-Url: https://bugzilla.redhat.com/1365451
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
1 file changed, 9 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
Rafael Martins: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/62188
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5bbe9ddb45bfcbf6b7bf8aa7c6e2fb19fa206fe
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in jenkins[master]: Add ovirt-dwh build-artifact-manual jobs
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: Add ovirt-dwh build-artifact-manual jobs
......................................................................
Add ovirt-dwh build-artifact-manual jobs
Change-Id: Ie7fde03c84eaa0211e79181feeee17d6d4fe67ec
Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com>
---
M jobs/confs/projects/ovirt-dwh/ovirt-dwh_standard.yaml
1 file changed, 19 insertions(+), 0 deletions(-)
Approvals:
Sharon Naftaly: Verified
Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge
--
To view, visit https://gerrit.ovirt.org/61775
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7fde03c84eaa0211e79181feeee17d6d4fe67ec
Gerrit-PatchSet: 4
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <david(a)dcaro.es>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in jenkins[master]: Moving create-rpms-manual jobs to standard-ci
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: Moving create-rpms-manual jobs to standard-ci
......................................................................
Moving create-rpms-manual jobs to standard-ci
It will now be called build-artifacts-manual
Change-Id: Ib9570d56dd229d30063e469ea34b902f05c00711
Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com>
---
A jobs/confs/groovy-scripts/build-artifacts-manual-any_get-target-jobs.groovy
A jobs/confs/shell-scripts/build-artifacts-manual_any.sh
A jobs/confs/shell-scripts/standard_build_artifacts_manual.sh
M jobs/confs/yaml/builders/standard.yaml
A jobs/confs/yaml/templates/build-artifacts-manual-any_template.yaml
M jobs/confs/yaml/templates/standard-stage.yaml
M jobs/confs/yaml/triggers/standard.yaml
7 files changed, 133 insertions(+), 0 deletions(-)
Approvals:
Sharon Naftaly: Verified; Ready for review
Eyal Edri: Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60883
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9570d56dd229d30063e469ea34b902f05c00711
Gerrit-PatchSet: 10
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <david(a)dcaro.es>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: webadmin: RM EnumUtils#ConvertToStringWithSpaces
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: webadmin: RM EnumUtils#ConvertToStringWithSpaces
......................................................................
webadmin: RM EnumUtils#ConvertToStringWithSpaces
EnumUtils#ConvertToStringWithSpaces is a GWT-override of a method that
no longer exists.
As it's never used (and doesn't actually do anything besides returning
null), it can safely be removed.
Change-Id: I9c15a15ba22f58faaf46eff8dedc3b7d23ae0c22
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/common/utils/EnumUtils.java
1 file changed, 0 insertions(+), 17 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62225
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c15a15ba22f58faaf46eff8dedc3b7d23ae0c22
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: webadmin: moving a common method to AbstractDiskModel
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: moving a common method to AbstractDiskModel
......................................................................
webadmin: moving a common method to AbstractDiskModel
Moving a common method (getStorageDomainId) to AbstractDiskModel
from EditDiskModel and ReadOnlyDiskModel.
Change-Id: Id74c85beac3de24b4a5735bf6bc6af003d300956
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ReadOnlyDiskModel.java
3 files changed, 10 insertions(+), 20 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved; Passed CI tests
Amit Aviram: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/62187
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id74c85beac3de24b4a5735bf6bc6af003d300956
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: engine: Fix taskhandler init - RemoveDisksSnapshot
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: engine: Fix taskhandler init - RemoveDisksSnapshot
......................................................................
engine: Fix taskhandler init - RemoveDisksSnapshot
The method initTaskHandlers is called every time that the command is
initiated.
In RemoveDiskSnapshotsCommand, the number of task handlers created was
different after that the former handler finished its operation.
This situation created a mismatch between the task handler map in
BaseCommand and the command execution index.
In this patch, the images IDs are computed only once and not every time
that the initTaskHandlers is invoked, keeping the number of task
handlers consistent.
Also, the task handlers are not created if it is a live merge flow.
Change-Id: Ic2836d7f6430183eecef337ed6d1c667b2f2990c
Bug-Url: https://bugzilla.redhat.com/1365393
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommand.java
1 file changed, 7 insertions(+), 17 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Freddy Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/62158
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2836d7f6430183eecef337ed6d1c667b2f2990c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months