Change in ovirt-engine[master]: engine: RM MultilevelAdministrationsQueriesParameters
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: RM MultilevelAdministrationsQueriesParameters
......................................................................
engine: RM MultilevelAdministrationsQueriesParameters
MultilevelAdministrationsQueriesParameters has no state, making it
useless. There's no reason not to just use VdcQueryParametersBase
directly.
This patch removes this useless class and refines all its usages.
Change-Id: Ib6f0ff846908c179fc8157c562d63a27b2ce1cd5
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllRolesQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllRolesQueryTest.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/MultilevelAdministrationsQueriesParameters.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendRolesResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendRolesResourceTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleListModel.java
7 files changed, 12 insertions(+), 22 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/62066
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6f0ff846908c179fc8157c562d63a27b2ce1cd5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: RM CreateOvfStoresForStorageDomainCommandParameters
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: RM CreateOvfStoresForStorageDomainCommandParameters
......................................................................
core: RM CreateOvfStoresForStorageDomainCommandParameters
Change-Id: If137860a6d7e1eca4388397ebb991e52caeb7d10
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateOvfStoresForStorageDomainCommandParameters.java
1 file changed, 0 insertions(+), 32 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/62068
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If137860a6d7e1eca4388397ebb991e52caeb7d10
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: Remove unused ClusterNetworksParameters
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused ClusterNetworksParameters
......................................................................
core: Remove unused ClusterNetworksParameters
Change-Id: I82b4e70914c58e7cc524dcb173fb7e0a733a009b
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ClusterNetworksParameters.java
1 file changed, 0 insertions(+), 23 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/62067
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I82b4e70914c58e7cc524dcb173fb7e0a733a009b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: Remove GetFilteredAttachableDisksParameters
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove GetFilteredAttachableDisksParameters
......................................................................
core: Remove GetFilteredAttachableDisksParameters
Commit 6e55d137d5ca32085da8c4d2bf2b6841463422ae removed the
GetFilteredAttachableDisksQuery class, but left behind its parameter
class, GetFilteredAttachableDisksParameters.
This patch rectifies this mistake by removing this leftover class.
Change-Id: Ifa6c08b004062eb6f3fec58856e870ff1f97f671
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetFilteredAttachableDisksParameters.java
1 file changed, 0 insertions(+), 37 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/62046
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa6c08b004062eb6f3fec58856e870ff1f97f671
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: network: fixing the detection of existing management bridge
by stirabos＠redhat.com
Simone Tiraboschi has submitted this change and it was merged.
Change subject: network: fixing the detection of existing management bridge
......................................................................
network: fixing the detection of existing management bridge
Look for an already configured management bridge using the
management bridge name from the answerfile instead of the
default one.
Change-Id: I6688b55d7efed73bd759788048d4e6613514f153
Bug-Url: https://bugzilla.redhat.com/1364615
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/gr-he-common/network/bridge.py
2 files changed, 28 insertions(+), 12 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Simone Tiraboschi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62072
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6688b55d7efed73bd759788048d4e6613514f153
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-2.0
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-hosted-engine-setup[master]: network: fixing the detection of existing management bridge
by stirabos＠redhat.com
Simone Tiraboschi has submitted this change and it was merged.
Change subject: network: fixing the detection of existing management bridge
......................................................................
network: fixing the detection of existing management bridge
Look for an already configured management bridge using the
management bridge name from the answerfile instead of the
default one.
Change-Id: I6688b55d7efed73bd759788048d4e6613514f153
Bug-Url: https://bugzilla.redhat.com/1364615
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/gr-he-common/network/bridge.py
2 files changed, 28 insertions(+), 12 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Simone Tiraboschi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Rafael Martins: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/62065
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6688b55d7efed73bd759788048d4e6613514f153
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in jenkins[master]: Changed script to run on all archs
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: Changed script to run on all archs
......................................................................
Changed script to run on all archs
Script was hard coded to run on x86_64
Changed it to parameter being generated
from uname -i
Change-Id: I0d1fd3427bc766f4e4c5c959ced56aee46d949a9
Signed-off-by: gbenhaim <galbh2(a)gmail.com>
---
M jobs/confs/shell-scripts/mock_setup.sh
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Eyal Edri: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62034
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d1fd3427bc766f4e4c5c959ced56aee46d949a9
Gerrit-PatchSet: 5
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Gal Ben Haim <galbh2(a)gmail.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: webadmin: iSCSI initiator wrapping
by gshereme＠redhat.com
Greg Sheremeta has submitted this change and it was merged.
Change subject: webadmin: iSCSI initiator wrapping
......................................................................
webadmin: iSCSI initiator wrapping
- If you made the screen too small, the iSCSI initiator
name would not wrap since there is no natural break in
the string. Added a CSS force wrap statement to make it
break even if there is no natural break available.
Change-Id: Ifc40c6b74505dbc051e08e67bfcdbc4d13737a24
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1364337
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/GeneralFormPanel.ui.xml
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/62053
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc40c6b74505dbc051e08e67bfcdbc4d13737a24
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: userportal: Fix first vm creation in session
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin: userportal: Fix first vm creation in session
......................................................................
webadmin: userportal: Fix first vm creation in session
When creating a vm on a local storage domain it should be
pinned to a specific host that is available for this domain.
When creating a vm on local storage for the first time it wouldn't
be created with a pinned host due to an async code that would not run
in the expected order. When editing such a vm the user would get an
error since it seems that he is editing the pinned host.
To ensure the correct order of execution the handling of the local
storage was moved to the end of the block of code that is run
asynchronously.
Change-Id: I99918ef35099546734cf8835e5abe5bfcef33d08
Bug-Url: https://bugzilla.redhat.com/1284472
Signed-off-by: Jenny Tokar <jtokar(a)redhat.com>
(cherry picked from commit c12e312)
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
2 files changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Jenny Tokar: Verified
Yanir Quinn: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/62033
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I99918ef35099546734cf8835e5abe5bfcef33d08
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in mom[master]: Do not ignore ioTune when there is not policy yet
by alitke＠redhat.com
Adam Litke has submitted this change and it was merged.
Change subject: Do not ignore ioTune when there is not policy yet
......................................................................
Do not ignore ioTune when there is not policy yet
The existing logic for ignoring VMs with no ioTune support
caused an issue when a VM was started without any ioTune
set (all zeros) and a live update was attempted.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1201482
Change-Id: I10c1f558f0d69209a76d6eede8cbb534e9ebea36
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/61947
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Adam Litke <alitke(a)redhat.com>
---
M mom/Collectors/GuestIoTune.py
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Adam Litke: Looks good to me, approved
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Verified
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/61947
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I10c1f558f0d69209a76d6eede8cbb534e9ebea36
Gerrit-PatchSet: 3
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months