Change in ovirt-engine[master]: scheduling: Use the pending VM count in EvenGuestDistr. weig...
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: scheduling: Use the pending VM count in EvenGuestDistr. weight unit
......................................................................
scheduling: Use the pending VM count in EvenGuestDistr. weight unit
Change-Id: I01c04fec089af07308ac645b41f8bc857134a015
Bug-Url: https://bugzilla.redhat.com/1411460
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenGuestDistributionWeightPolicyUnit.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Yanir Quinn: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/69911
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I01c04fec089af07308ac645b41f8bc857134a015
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[ovirt-engine-4.1]: backend: fix logging of disks with illegal Pass Discard
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: backend: fix logging of disks with illegal Pass Discard
......................................................................
backend: fix logging of disks with illegal Pass Discard
Previously, when adding a cloned vm from a template, if at least one of
the target vm's disks had an illegal Pass Discard value, the wrong
disks' ids were logged (the source disks' ids instead of the target
ones).
This patch simplifies the way we log these disks by moving the log
handling to BlockStorageDiscardFunctionalityHelper and fixes this bug,
so that now the right ids are logged.
Change-Id: I566b36d3b7c25c4b8badfa59a9113fd3885eac4d
Bug-Url: https://bugzilla.redhat.com/1410017
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/DiskHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/utils/BlockStorageDiscardFunctionalityHelper.java
4 files changed, 32 insertions(+), 35 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/69887
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I566b36d3b7c25c4b8badfa59a9113fd3885eac4d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[ovirt-engine-4.1]: backend: move illegal Pass Discard logging to AddVmCommand
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: backend: move illegal Pass Discard logging to AddVmCommand
......................................................................
backend: move illegal Pass Discard logging to AddVmCommand
This patch moves the logging of disks with illegal Pass Discard value
from AddVmFromTemplateCommand to AddVmCommand.
Therefore, the log will not be shown only when creating a cloned vm from
a template, but also when creating a thin vm from a template, when
cloning a vm and when adding a vm from a snapshot.
Change-Id: I84349befab5c9752825b0667a327edddae1d3819
Bug-Url: https://bugzilla.redhat.com/1410019
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
2 files changed, 6 insertions(+), 5 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/69888
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I84349befab5c9752825b0667a327edddae1d3819
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[ovirt-engine-4.1]: backend: log disks with illegal Pass Discard on RestoreFromS...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: backend: log disks with illegal Pass Discard on RestoreFromSnapshot
......................................................................
backend: log disks with illegal Pass Discard on RestoreFromSnapshot
When restoring a snapshot, if at least one disk in that snapshot has an
illegal Pass Discard value, an audit log will be shown to warn the user
about it.
Change-Id: Ib69e4da3d4f012d79ca4ae85a7e2d25a381dd4de
Bug-Url: https://bugzilla.redhat.com/1410019
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreFromSnapshotCommand.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/69890
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib69e4da3d4f012d79ca4ae85a7e2d25a381dd4de
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[ovirt-engine-4.1]: backend: log disks with illegal Pass Discard on ImportVmTemp...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: backend: log disks with illegal Pass Discard on ImportVmTemplate
......................................................................
backend: log disks with illegal Pass Discard on ImportVmTemplate
When importing a vm template from an export domain, if at least one
disk from the imported template has an illegal Pass Discard value, an
audit log will be shown to warn the user about it.
Change-Id: I51a77c5e760d476fa3e541651ee1bc4800dc2952
Bug-Url: https://bugzilla.redhat.com/1410019
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/69889
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I51a77c5e760d476fa3e541651ee1bc4800dc2952
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: packaging: ovirt-engine-hosts-ansible-inventory: Add up_metr...
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: ovirt-engine-hosts-ansible-inventory: Add up_metrics hosts
......................................................................
packaging: ovirt-engine-hosts-ansible-inventory: Add up_metrics hosts
When originally writing this, I thought it will be easy to do the
intersection between 'ovirt_metrics_hosts' and 'ovirt_up_hosts' in
ansible itself. Appanrently that's not so easy, doing this here for now.
See also: https://github.com/ansible/ansible/issues/10131
Bug-Url: https://bugzilla.redhat.com/1405813
Change-Id: I3fa8d34f30fb553a298b4ff7d419c4ecfad7d61b
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/bin/ovirt-engine-hosts-ansible-inventory
1 file changed, 10 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/69908
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3fa8d34f30fb553a298b4ff7d419c4ecfad7d61b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: scheduling: Modify migration policy behavior
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: scheduling: Modify migration policy behavior
......................................................................
scheduling: Modify migration policy behavior
Migration policy unit modified to accept
target host with same id as the source host.
The host is not filtered out for balancing purposes,
where target host is as same as the source host.
Change-Id: I52835ade5ffbfdd50670fc0105e5c057d66b59d3
Bug-Url: https://bugzilla.redhat.com/1410040
Signed-off-by: Yanir Quinn <yquinn(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MigrationPolicyUnit.java
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
Yanir Quinn: Verified
--
To view, visit https://gerrit.ovirt.org/69863
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I52835ade5ffbfdd50670fc0105e5c057d66b59d3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.1]: API: add a default timeout for engine API
by Code Review
>From Simone Tiraboschi <stirabos(a)redhat.com>:
Simone Tiraboschi has submitted this change and it was merged.
Change subject: API: add a default timeout for engine API
......................................................................
API: add a default timeout for engine API
oVirt python SDK doesn't set a default timeout
on the API so, if for any reason an API call
got stuck, ovirt-hosted-engine-setup will
wait forever.
Change-Id: Id8fae577745b091c7831e255dfd72028be86a2a4
Bug-Url: https://bugzilla.redhat.com/1410501
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
(cherry picked from commit 581fc0031559f1a0046a42273bc5fe3b731c8479)
---
M src/ovirt_hosted_engine_setup/constants.py
M src/ovirt_hosted_engine_setup/engineapi.py
2 files changed, 5 insertions(+), 0 deletions(-)
Approvals:
Lev Veyde: Looks good to me, but someone else must approve
Simone Tiraboschi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Rafael Martins: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/69860
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8fae577745b091c7831e255dfd72028be86a2a4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-2.1
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[ovirt-engine-4.1]: Version bump
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: Version bump
......................................................................
Version bump
Bug-Url: https://bugzilla.redhat.com/1408870
Change-Id: Id509d9fb7cc0a4e07d5390a548ff6b0f6512f08d
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M ovirt-engine.spec.in
M pom.xml
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Jenkins CI: Passed CI tests
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69893
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id509d9fb7cc0a4e07d5390a548ff6b0f6512f08d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[ovirt-engine-4.1]: core: Add a Guid constructor to ImportHostedEngineStorageDom...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add a Guid constructor to ImportHostedEngineStorageDomain command
......................................................................
core: Add a Guid constructor to ImportHostedEngineStorageDomain command
This constructor is used by the Backend.compensate in case the
engine is restarted during the import.
Change-Id: I63ab881827b1cdea2df9af6fcc81214b13e3cdfd
Bug-Url: https://bugzilla.redhat.com/1409112
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
(cherry picked from commit 6649a5d1b25d334235a5de19d68b53d3aa72ddab)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ImportHostedEngineStorageDomainCommand.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Martin Sivák: Verified; Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Yanir Quinn: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/69904
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I63ab881827b1cdea2df9af6fcc81214b13e3cdfd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months