Change in ovirt-engine-sdk-ruby[master]: Don't use 'bundler' in RPM distributions
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Don't use 'bundler' in RPM distributions
......................................................................
Don't use 'bundler' in RPM distributions
Currently the SDK uses the 'bundler' tool to install the dependencies
and build the SDK. But in some platforms the latest version of this tool
doesn't work correctly with the version of the 'gem' tool. To avoid this
problem, and other potential problems in the future, this patch changes
the build scripts so that they provide a mechanism to build without
bundler. This mechanism consists on two new build profiles: 'bundler'
and 'rpm'. The first, 'bundler', will work as it used to work before
this patch. The new one, 'rpm', will assume that the required gems have
already been installed, with the RPM package manager, for example.
Note that 'bundler' is still the recommended tool for the build, and
will continue to be used in development environments and for the builds
released to 'rubygems.org'.
Change-Id: Ide97e6e6df3ca326f26563a7e3305fd50e0abc14
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M automation/build.packages.el7
M automation/build.packages.fc23
M automation/build.packages.fc24
M automation/build.py
M packaging/spec.el7.in
M packaging/spec.fc24.in
M pom.xml
M sdk/Rakefile
M sdk/pom.xml
9 files changed, 183 insertions(+), 86 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/72191
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ide97e6e6df3ca326f26563a7e3305fd50e0abc14
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: Change max vCPU count computation
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: Change max vCPU count computation
......................................................................
core: Change max vCPU count computation
Maximum vCPU count for a VM is currently determined by a defined
absolute maximum limit and the number of cores and threads. However, on
x86 the simple formula may cause overflow of an APIC ID limit due to the
bit-based layout of the APIC ID value and then QEMU refuses to run the
VM.
With this patch we make sure that the value always fits into the APIC
limits. See the bug report for explanation. In the future, when x2APIC
will be used, we can remove the restriction.
Change-Id: I9cced4317eebfd302230152e96c6c32dcf0fb13f
Bug-Url: https://bugzilla.redhat.com/1406243
Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmCpuCountHelper.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
12 files changed, 122 insertions(+), 8 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
Milan Zamazal: Verified
--
To view, visit https://gerrit.ovirt.org/71282
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9cced4317eebfd302230152e96c6c32dcf0fb13f
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[ovirt-engine-4.1]: engine: open iptables holes on OVN hosts
by Code Review
>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>:
Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: open iptables holes on OVN hosts
......................................................................
engine: open iptables holes on OVN hosts
OVN does not currently open any firewall holes for its hosts,
and the existing plans are only for firewalld.
VDSM needs iptables instead of firewalld.
Therefore we need to open iptables holes on our own.
Change-Id: I8cda3b30f9ea49cbe5c32c1dfccecce5db4d4f8f
Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1416748
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Marcin Mirecki: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/72157
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8cda3b30f9ea49cbe5c32c1dfccecce5db4d4f8f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine-sdk[sdk_4.1]: Don't fork the Maven source plugin
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Don't fork the Maven source plugin
......................................................................
Don't fork the Maven source plugin
Currently the project runs the 'jar' goal of the Maven source plugin.u
A side effect of this is that the plugin explicitly executes the
'generate-sources' phase of the build. As a result the code generation,
which is attached to that 'generate-sources' phase, runs twice. That
doesn't have a big impact, as the generated code is the same, but it
wastes resources. This patch changes the build process so that it uses
the 'jar-no-fork', which doesn't have that negative side effect.
Change-Id: I86fffee023f4cb76992b31d2f12a481f9ab9efe8
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/72242
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I86fffee023f4cb76992b31d2f12a481f9ab9efe8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine-sdk[sdk_4.1]: Remove duplicated Maven compiler plugin
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Remove duplicated Maven compiler plugin
......................................................................
Remove duplicated Maven compiler plugin
The Maven compiler plugin is listed twice in the root POM of the
project. This patch removes one of the copies.
Change-Id: I6183ab984a069400c944db10f29db3f44f9a5b8d
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M pom.xml
1 file changed, 0 insertions(+), 10 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/72241
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6183ab984a069400c944db10f29db3f44f9a5b8d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine-sdk[master]: Don't fork the Maven source plugin
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Don't fork the Maven source plugin
......................................................................
Don't fork the Maven source plugin
Currently the project runs the 'jar' goal of the Maven source plugin.u
A side effect of this is that the plugin explicitly executes the
'generate-sources' phase of the build. As a result the code generation,
which is attached to that 'generate-sources' phase, runs twice. That
doesn't have a big impact, as the generated code is the same, but it
wastes resources. This patch changes the build process so that it uses
the 'jar-no-fork', which doesn't have that negative side effect.
Change-Id: I86fffee023f4cb76992b31d2f12a481f9ab9efe8
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ondra Machacek: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/72204
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I86fffee023f4cb76992b31d2f12a481f9ab9efe8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine-sdk[master]: Remove duplicated Maven compiler plugin
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Remove duplicated Maven compiler plugin
......................................................................
Remove duplicated Maven compiler plugin
The Maven compiler plugin is listed twice in the root POM of the
project. This patch removes one of the copies.
Change-Id: I6183ab984a069400c944db10f29db3f44f9a5b8d
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M pom.xml
1 file changed, 0 insertions(+), 10 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/72203
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6183ab984a069400c944db10f29db3f44f9a5b8d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: userportal: Expand vm interface dialog to fit all the content
by Code Review
>From Alona Kaplan <alkaplan(a)redhat.com>:
Alona Kaplan has submitted this change and it was merged.
Change subject: userportal: Expand vm interface dialog to fit all the content
......................................................................
userportal: Expand vm interface dialog to fit all the content
Also removed related unnecessary classes.
Change-Id: I483c161f951d300830b46d5bf85613ef52072249
Bug-Url: https://bugzilla.redhat.com/1419529
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/template/TemplateNetworkInterfacePopupWidget.java
D frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/vm/VmNetworkInterfacePopupWidget.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/template/TemplateInterfacePopupView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmInterfacePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/template/TemplateInterfacePopupView.java
5 files changed, 7 insertions(+), 43 deletions(-)
Approvals:
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/72183
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I483c161f951d300830b46d5bf85613ef52072249
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: UpdateHostNicVfsConfigCommand type inference
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: core: UpdateHostNicVfsConfigCommand type inference
......................................................................
core: UpdateHostNicVfsConfigCommand type inference
Change-Id: I22bab7a910389fdd0668d2f49100858d48f1eefe
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UpdateHostNicVfsConfigCommand.java
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/72236
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I22bab7a910389fdd0668d2f49100858d48f1eefe
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine-sdk[sdk_4.0]: Add Sysprep example
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Add Sysprep example
......................................................................
Add Sysprep example
This patch adds an example that shows how to add a virtual machine and
then start it with a custom Sysprep configuration file.
Change-Id: If04f421c88aced61c6cd53611c2168e2bc920f37
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit d1fb33ebbaebad4277432ad1043ffdfb3f9e686d)
(cherry picked from commit c805df0e1582751b5d6581c6e5e00bd6d6d88017)
---
A sdk/examples/add_vm_with_sysprep.py
1 file changed, 95 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/72229
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If04f421c88aced61c6cd53611c2168e2bc920f37
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months