June 2017 - Engine-commits - Ovirt List Archives

Change in ovirt-log-collector[ovirt-log-collector-4.1]: vms_check_no_timezone_set: SQL AS statement should be in caps

by Code Review

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: vms_check_no_timezone_set: SQL AS statement should be in caps ...................................................................... vms_check_no_timezone_set: SQL AS statement should be in caps Change-Id: I12fa276a6264560efaa44397bdbcb45dede79248 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/sqls/vms_check_no_timezone_set.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78446 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12fa276a6264560efaa44397bdbcb45dede79248 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

7 years, 5 months

1
0
0 / 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: improve layout output from hosts health

by Code Review

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: improve layout output from hosts health ...................................................................... inventory: improve layout output from hosts health Now in the HTML version show a table and important icon Change-Id: I0e0c09b4c423ef210cd954080273282041d7be71 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/sqls/hosts_query_check_health.sql 2 files changed, 16 insertions(+), 18 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78445 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e0c09b4c423ef210cd954080273282041d7be71 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

7 years, 5 months

1
0
0 / 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: use adoc WARNING for vms_no_timezone_set

by Code Review

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: use adoc WARNING for vms_no_timezone_set ...................................................................... inventory: use adoc WARNING for vms_no_timezone_set Change-Id: Id21b1ee6ec86db987690057d996efb333756ae1d Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/pre-upgrade-checks 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id21b1ee6ec86db987690057d996efb333756ae1d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

7 years, 5 months

1
0
0 / 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory_report: improve layout of data for cluster < 3.6

by Code Review

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory_report: improve layout of data for cluster < 3.6 ...................................................................... inventory_report: improve layout of data for cluster < 3.6 Instead of show all the virtual machines name which can be a huge list, let's show the number of virtual machines. Change-Id: I5ae3e418351c6ef8c28471fb46883093ea635595 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/sqls/vms_query_check_obsolete_cluster.sql 2 files changed, 8 insertions(+), 7 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78443 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ae3e418351c6ef8c28471fb46883093ea635595 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

7 years, 5 months

1
0
0 / 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: check if vms timezone are not set

by Code Review

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: check if vms timezone are not set ...................................................................... inventory: check if vms timezone are not set Share in the report vms without timezone data Change-Id: I7a75096e4d89f5df2465ae8e7e38fc6b3f92e62f Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/vms_check_no_timezone_set.sql 4 files changed, 31 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78442 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a75096e4d89f5df2465ae8e7e38fc6b3f92e62f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

7 years, 5 months

1
0
0 / 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: produceReport: Extract DWS SQL query from shell script to .sql

by Code Review

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: produceReport: Extract DWS SQL query from shell script to .sql ...................................................................... produceReport: Extract DWS SQL query from shell script to .sql For portabilitiy let's keep the .sql out from the shell script when possible. Change-Id: Ia22e25092e7145c042e3fd4220c37dcd0737057f Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/dws_query_check_if_its_running.sql 3 files changed, 20 insertions(+), 7 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78441 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia22e25092e7145c042e3fd4220c37dcd0737057f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

7 years, 5 months

1
0
0 / 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: pre-upgrade-checks: Let's add passed output for users

by Code Review

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: pre-upgrade-checks: Let's add passed output for users ...................................................................... pre-upgrade-checks: Let's add passed output for users Let's show to users which tests passed instead of only showing when error appear. Change-Id: I2e2143f93b9725b025fe6afeac0e1bbe32a8fcf9 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/pre-upgrade-checks 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e2143f93b9725b025fe6afeac0e1bbe32a8fcf9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

7 years, 5 months

1
0
0 / 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Check for vms with cluster level < 3.6

by Code Review

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: Check for vms with cluster level < 3.6 ...................................................................... inventory: Check for vms with cluster level < 3.6 Add a new verification step, check for vms with cluster level < 3.6 Change-Id: If028cd1ff4b2e0ec381783945d8687751c04f6a9 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/vms_query_check_obsolete_cluster.sql 4 files changed, 47 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78439 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If028cd1ff4b2e0ec381783945d8687751c04f6a9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

7 years, 5 months

1
0
0 / 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: importDumpIntoNewDb: initdb - do not redirect standard outpu...

by Code Review

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: importDumpIntoNewDb: initdb - do not redirect standard output error ...................................................................... importDumpIntoNewDb: initdb - do not redirect standard output error Currently, if users execute initdb with root or other users not allowed to use postgres, the error message will be redirected to initdb.log and won't show in the console. This patch removes the redirect and the error now show in the console to users as soon an it appears. Change-Id: I22a2336f3b52cc11d9fd2a4027dddfa03d0ba169 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/importDumpIntoNewDb.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78438 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22a2336f3b52cc11d9fd2a4027dddfa03d0ba169 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

7 years, 5 months

1
0
0 / 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: Makefile: Adjust path for execution via rpm install

by Code Review

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: Makefile: Adjust path for execution via rpm install ...................................................................... Makefile: Adjust path for execution via rpm install Make sure we follow commit 377e0575 Change-Id: If04b651d17b7b83033509436a1a59a8dfc290951 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If04b651d17b7b83033509436a1a59a8dfc290951 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

7 years, 5 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits June 2017